We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Via analysing crash stacks on dev play console I found out that we often crash on that place https://github.com/brave/brave-core/blob/1.16.x/browser/android/brave_cosmetic_resources_tab_helper.cc#L81 That is place is better to rewrite to use frame_id instead of a raw pointer, that way we can check if the host is still alive after IO operations. It looks like it happens non consistently sometimes in diff behaviour, I wasn't able to replicate that.
No steps unfortunately
Sometimes crashes randomly on browsing
No crashes
0 times for me, but we have plenty of reports about crashes lately.
every channel, starting from 1.16.x
1.16.x
The text was updated successfully, but these errors were encountered:
SergeyZhukovsky
Successfully merging a pull request may close this issue.
Description
Via analysing crash stacks on dev play console I found out that we often crash on that place https://github.com/brave/brave-core/blob/1.16.x/browser/android/brave_cosmetic_resources_tab_helper.cc#L81
That is place is better to rewrite to use frame_id instead of a raw pointer, that way we can check if the host is still alive after IO operations.
It looks like it happens non consistently sometimes in diff behaviour, I wasn't able to replicate that.
Steps to reproduce
No steps unfortunately
Actual result
Sometimes crashes randomly on browsing
Expected result
No crashes
Issue reproduces how often
0 times for me, but we have plenty of reports about crashes lately.
Version/Channel Information:
every channel, starting from
1.16.x
Device details
Brave version
Website problems only
Additional information
The text was updated successfully, but these errors were encountered: