Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

execute js script only when render_frame_host is still alive (uplift to 1.18.x) #7173

Merged
merged 1 commit into from
Nov 18, 2020
Merged

execute js script only when render_frame_host is still alive (uplift to 1.18.x) #7173

merged 1 commit into from
Nov 18, 2020

Conversation

brave-builds
Copy link
Collaborator

@brave-builds brave-builds commented Nov 17, 2020 •
edited by kjozwiak
Loading

Uplift of #7171
Resolves brave/brave-browser#12745

Approved, please ensure that before merging:

  • You have checked CI and the builds, lint, and tests all pass or are not related to your PR.
  • You have tested your change on Nightly.
  • The PR milestones match the branch they are landing to.

After you merge:

  • The associated issue milestone is set to the smallest version that the changes is landed on.

@brave-builds brave-builds requested a review from a team November 17, 2020 22:44
@brave-builds brave-builds self-assigned this Nov 17, 2020
@brave-builds brave-builds added this to the 1.18.x - Beta milestone Nov 17, 2020
@SergeyZhukovsky SergeyZhukovsky added CI/skip-ios Do not run CI builds for iOS CI/skip-linux CI/skip-macos-x64 Do not run CI builds for macOS x64 labels Nov 17, 2020
kjozwiak
kjozwiak approved these changes Nov 18, 2020
View reviewed changes
Copy link
Member

@kjozwiak kjozwiak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Uplift into 1.18.x approved after deliberating with @brave/uplift-approvers.

@kjozwiak kjozwiak merged commit 69fdce2 into 1.18.x Nov 18, 2020
@kjozwiak kjozwiak deleted the pr7171_android_cf_crash_1.18.x branch November 18, 2020 00:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kjozwiak kjozwiak kjozwiak approved these changes

Assignees

@brave-builds brave-builds

Labels
CI/skip-ios Do not run CI builds for iOS CI/skip-macos-x64 Do not run CI builds for macOS x64
Projects
None yet
Milestone
1.18.x - Release
Development

Successfully merging this pull request may close these issues.
4 participants
@brave-builds @kjozwiak @SergeyZhukovsky @brave-browser-releases