Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Brave Ads notification close button hit area is too small #12956

Closed
tmancey opened this issue Dec 1, 2020 · 1 comment
Closed

Brave Ads notification close button hit area is too small #12956

tmancey opened this issue Dec 1, 2020 · 1 comment
Labels
closed/wontfix design/needs-mock-up needs-mockup A feature which needs design mockup to be implemented. feature/ads OS/Android Fixes related to Android browser functionality

Comments

@tmancey
Copy link
Contributor

tmancey commented Dec 1, 2020

Description

Steps to reproduce

  1. View ad notification
  2. Click close X button

Actual result

Hit area is too small and does not follow Android UX guidelines

Expected result

Hit area should follow Android UX guidelines

Issue reproduces how often

Version/Channel Information:

  • Can you reproduce this issue with the current Play Store version? No
  • Can you reproduce this issue with the current Play Store Beta version? No
  • Can you reproduce this issue with the current Play Store Nightly version? Yes

Device details

  • Install type (ARM, x86):
  • Device type (Phone, Tablet, Phablet):
  • Android version:

Brave version

Website problems only

  • Does the issue resolve itself when disabling Brave Shields? N/A
  • Does the issue resolve itself when disabling Brave Rewards? N/A
  • Is the issue reproducible on the latest version of Chrome? N/A

Additional information
@tmancey tmancey added design/needs-mock-up needs-mockup A feature which needs design mockup to be implemented. feature/ads OS/Android Fixes related to Android browser functionality labels Dec 1, 2020
yachtcaptain23 added a commit to brave/brave-core that referenced this issue Dec 1, 2020
@yachtcaptain23
Ads fixes:
9bc0a09 
(1) Font size and background
(2) Fix buttons to use 48dp

Closes brave/brave-browser#12956
@yachtcaptain23
Copy link

yachtcaptain23 commented Dec 3, 2020 •
edited
Loading

Closing in favor of #13038 which will track effort to use swipe-to-dismiss

yachtcaptain23 added a commit to brave/brave-core that referenced this issue Apr 19, 2021
@yachtcaptain23
Ads fixes:
bab3a40 
(1) Font size and background
(2) Fix buttons to use 48dp

Closes brave/brave-browser#12956
yachtcaptain23 added a commit to brave/brave-core that referenced this issue Apr 20, 2021
@yachtcaptain23
Ads fixes:
1d1ed14 
(1) Font size and background
(2) Fix buttons to use 48dp

Closes brave/brave-browser#12956
yachtcaptain23 added a commit to brave/brave-core that referenced this issue Apr 30, 2021
@yachtcaptain23
Ads fixes:
53eba57 
(1) Font size and background
(2) Fix buttons to use 48dp

Support dismiss instead of X.

Closes brave/brave-browser#12956
yachtcaptain23 added a commit to brave/brave-core that referenced this issue May 16, 2021
@yachtcaptain23
Ads fixes:
3c27368 
(1) Font size and background
(2) Fix buttons to use 48dp

Support dismiss instead of X.

Closes brave/brave-browser#12956
yachtcaptain23 added a commit to brave/brave-core that referenced this issue May 18, 2021
@yachtcaptain23
Ads fixes:
be42315 
(1) Font size and background
(2) Fix buttons to use 48dp

Support dismiss instead of X.

Closes brave/brave-browser#12956
@tmancey tmancey added this to Ads Jun 10, 2024
@tmancey tmancey moved this to Done in Ads Jun 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
closed/wontfix design/needs-mock-up needs-mockup A feature which needs design mockup to be implemented. feature/ads OS/Android Fixes related to Android browser functionality
Projects
Ads
Archived in project
Milestone
No milestone
Development

No branches or pull requests
2 participants
@tmancey @yachtcaptain23