[Desktop] Update Brave Rewards panel within welcome UI

[zenparsing]

The welcome UI should be updated with new designs for the Brave Rewards onboarding panel.

When the user clicks the "Start Using Rewards" button, a new tab should open for the rewards settings page with ads and AC enabled.

[GeetaSarvadnya]

Verification passed on

Brave | 1.19.76 Chromium: 87.0.4280.101 (Official Build) dev (64-bit)
-- | --
Revision | 9407c80213cda69c2b7abcb4fa8e3f74488f4956-refs/branch-heads/4280@{#1807}
OS | Windows 10 OS Version 2004 (Build 19041.685)

• Verified the test plan from Update rewards onboarding panel in welcome UI brave-core#7467

Clean profile

• Verified that ToS and Privacy policy links provided in Brave Rewards slide-in brave://welcome
• Verified that the content and graphics of the slide is matching with the design mentioned in [Desktop] Update Brave Rewards panel within welcome UI #13119 (comment)
• Verified that ToS link redirects to https://basicattentiontoken.org/user-terms-of-service/
• Verified that Privacy Policy redirects to https://brave.com/privacy/browser/#rewards
• Click on Start using Rewards opens up brave://rewards/ page in a new tab with Ads and Auto-Contribute switches enabled
• Verified that Rewards onboarding modal is not displayed once rewards is enabled via brave://welcome slide
  

Upgrade profile

• Install 1.17.x dev build and upgrade to 1.19.x and navigate to Brave rewards in brave://welcome screen and ensured that rewards slide content and graphics is updated as the per the design mentioned in the description, click on Start using Rewards opens up brave://rewards/ page in a new tab with Ads and Auto-Contribute switches enabled
• Install 1.17.x dev build and enable rewards via BR panel or NTP, upgrade to 1.19.x and navigate to Brave rewards in brave://welcome screen, click on Start using Rewards button redirects to brave://rewards tab which is already opened in 1.17.x

---

Verification passed on

Brave	1.19.78 Chromium: 87.0.4280.101 (Official Build) dev (64-bit)
Revision	9407c80213cda69c2b7abcb4fa8e3f74488f4956-refs/branch-heads/4280@{#1807}
OS	Ubuntu 18.04 LTS

• Verified the test plan from Update rewards onboarding panel in welcome UI brave-core#7467

Clean profile

• Verified that ToS and Privacy policy links provided in Brave Rewards slide-in brave://welcome
• Verified that the content and graphics of the slide is matching with the design mentioned in [Desktop] Update Brave Rewards panel within welcome UI #13119 (comment)
• Verified that ToS link redirects to https://basicattentiontoken.org/user-terms-of-service/
• Verified that Privacy Policy redirects to https://brave.com/privacy/browser/#rewards
• Click on Start using Rewards opens up brave://rewards/ page in a new tab with Ads and Auto-Contribute switches enabled
• Verified that Rewards onboarding modal is not displayed once rewards is enabled via brave://welcome slide
  Light theme:
  
  Dark theme:
  

Upgrade profile

• Install 1.17.x build and upgrade to 1.19.x and navigate to Brave rewards in brave://welcome screen and ensured that rewards slide content and graphics is updated as the per the design mentioned in the description, click on Start using Rewards opens up brave://rewards/ page in a new tab with Ads and Auto-Contribute switches enabled

---

Verified passed with

Brave | 1.19.82 Chromium: 88.0.4324.79 (Official Build) dev (x86_64)
-- | --
Revision | bd1e9353659b2491dac971226a973ca3b5684a14-refs/branch-heads/4324@{#1520}
OS | macOS Version 10.15.7 (Build 19H15)

Verified test plan from brave/brave-core#7467 (comment)
Verified items listed in brave/brave-core#7467 (comment)

Confirmed rewards slide of onboarding for both light and dark themes

Light	Dark

Confirmed Terms of Service link is shown. When clicked a new tab is opened which navigates to `https://basicattentiontoken.org/user-terms-of-service/` as expected.

Light	Dark

Confirmed Privacy Policy link is shown. When clicked a new tab is opened which navigates to `https://brave.com/privacy/browser/#rewards` as expected.

Light	Dark

Confirmed light and dark theme graphic designs from figma: https://www.figma.com/file/0dbMYs8Wp8W3RgrG1yTdki/RE-1.0?node-id=99%3A0

Confirmed when clicking on "Start using Rewards" button a new tab opens to show brave://rewards with Ads and AC enabled.

Per brave/brave-core#7467 (comment), confirmed that there is no onboarding tour option displayed in 1.19.x when selecting "Start using Rewards" from brave://welcome.

[GeetaSarvadnya]

@zenparsing In a clean profile 1.19.x or upgraded profile, If I enable rewards via NTP or BR panel and then turn OFF the Ads and Auto-Contribute switches in brave://rewards tab and then enable rewards via brave://welcome screen by clicking on Start using rewards , a new tab brave://rewards is opened up with Ads and Auto-Contribute switches enabled, shouldn't it point to already opened brave://rewards tab?

[zenparsing]

@GeetaSarvadnya After we introduced rewards everywhere in 1.18 and removed the global rewards opt-in, the "Start using Rewards" buttons now just enable ads and AC. I think this is expected behavior, but cc @codybanxs for UX perspective.

[ghost]

If I am understanding this correctly @GeetaSarvadnya, the 2nd time you click "Start using Rewards" it should open up the rewards settings page with those settings turned on. Now I believe the logic that is baked in here is that it will automatically open the rewards settings page once you opt-in regardless of what other tabs are open prior to that interaction. I am not sure if we have a way to tell if the settings page is open or not and to just use the existing screen @zenparsing.