Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rewards panel being opened after 4 days even though it was viewed/dismissed via NTP SI entry point #13160

Closed
kjozwiak opened this issue Dec 11, 2020 · 4 comments
Closed

rewards panel being opened after 4 days even though it was viewed/dismissed via NTP SI entry point #13160

kjozwiak opened this issue Dec 11, 2020 · 4 comments
Assignees
@deeppandya
Labels
feature/rewards onboarding Front-end related to helping a new user learn about features within the browser. OS/Android Fixes related to Android browser functionality QA Pass - Android ARM QA Pass - Android Tab QA/Yes release/blocking release-notes/exclude
Milestone
1.18.x - Release #2

Comments

@kjozwiak
Copy link
Member

Description

If you view the rewards panel/onboarding through NTP SI, it will automatically re-open again on the fourth day. From my understanding, if a user has already viewed the panel by clicking on the rewards icon via the URL or NTP SI, it shouldn't be displayed on the fourth day.

Steps to reproduce

  1. launch a brave version that has RE onboarding (1.20.23 CR: 88.0.4315.5 in this case)
  2. view several tabs so you get a NTP SI and tap on the panel at the bottom
  3. rewards panel should open at the top, dismiss onboarding and I'm In modals via the X
  4. close brave and move the system time +4 days
  5. launch brave and the rewards panel will automatically launch again

Actual result

Example of issue occurring: https://youtu.be/uNF8J6wI7dg

Expected result

As per the spec and https://www.figma.com/file/0dbMYs8Wp8W3RgrG1yTdki/RE-1.0?node-id=541%3A19529, I believe the panel shouldn't be launching.

Issue reproduces how often

100% reproducible using the above STR.

Version/Channel Information:

  • Can you reproduce this issue with the current Play Store version? N/A
  • Can you reproduce this issue with the current Play Store Beta version? Yes
  • Can you reproduce this issue with the current Play Store Nightly version? Yes

Device details

  • Install type (ARM, x86): ARM
  • Device type (Phone, Tablet, Phablet): Samsung S10+ (Phone)
  • Android version: Android 10

Brave version

  • 1.20.23 CR: 88.0.4315.5

Website problems only

  • Does the issue resolve itself when disabling Brave Shields? N/A
  • Does the issue resolve itself when disabling Brave Rewards? N/A
  • Is the issue reproducible on the latest version of Chrome? N/A

Additional information

CCing @LaurenWags @deeppandya @codybanxs @bsclifton
@kjozwiak kjozwiak added feature/rewards onboarding Front-end related to helping a new user learn about features within the browser. OS/Android Fixes related to Android browser functionality labels Dec 11, 2020
@kjozwiak kjozwiak mentioned this issue Dec 11, 2020
Merged
23 tasks
@kjozwiak
Copy link
Member Author

kjozwiak commented Dec 11, 2020 •
edited
Loading

Going to label this as release/blocking but I'll let @bsclifton & @LaurenWags make the call. Probably don't want to annoy users with panel popups. CCing @deeppandya @codybanxs

@kjozwiak kjozwiak added this to the 1.18.x - Release #2 milestone Dec 11, 2020
@LaurenWags
Copy link
Member

LaurenWags commented Dec 11, 2020 •
edited
Loading

Also reproduces in the following case:

  1. launch a brave version that has RE onboarding (1.18.71)
  2. Tap on panel, "x" out of large onboarding UI. "x" out of small onboarding UI also
  3. close brave and move the system time +4 days
  4. launch brave and the rewards panel will automatically launch again

Confirmed if you started using BR during days 1-3, then on day 4 the panel does not open on launch.

This was referenced Dec 11, 2020
Merged
Closed
Merged
Merged
@kjozwiak
Copy link
Member Author

Closing this as it was fixed via brave/brave-core#7411 and was merged into 1.19.x & 1.18.x via brave/brave-core#7421 and brave/brave-core#7423.

@LaurenWags
Copy link
Member

LaurenWags commented Dec 15, 2020 •
edited by kjozwiak
Loading

Verification passed on LG Nexus 5 with Android 5.1 running 1.18.72 Bravearm.apk

Scenario 1 - don't interact with BAT logo
  1. Clean profile 1.18.x. Do not tap on BAT logo.
  2. Close app, remove from memory. Advance Date/Time 24h.
  3. Launch, do not tap on BAT logo. Observe panel does not open automatically.
  4. Close app, remove from memory. Advance Date/Time 24h.
  5. Launch, do not tap on BAT logo. Observe panel does not open automatically.
  6. Close app, remove from memory. Advance Date/Time 24h.
  7. Launch, do not tap on BAT logo. Observe panel does not open automatically.
  8. Close app, remove from memory. Advance Date/Time 24h.
  9. Launch.
  10. Confirmed panel opens automatically and shows large onboarding UI.
Scenario 2 - interact with BAT logo
  1. Clean profile 1.18.x. Tap on BAT logo. Dismiss large and small onboarding.
  2. Close app, remove from memory. Advance Date/Time 4 days.
  3. Launch.
  4. Confirmed panel does not open automatically as the user has already interacted with it.

Verification PASSED on Samsung Galaxy S10+ running Android 10 using 1.18.72 CR: 87.0.4280.101

Case 1 - No interaction with rewards panel

  • installed & launched 1.18.72 CR: 87.0.4280.101
  • open several tabs till you get a NTP SI and either close the tab/dismiss the NTP SI modal
  • closed Brave and moved the device time ahead by 24hrs
  • re-opened Brave and ensured that the rewards panel didn't open after launching
  • repeated the above 4 times until 4 days has been reached
  • launched Brave and ensured that the rewards panel appeared with the new opt-in onboarding flow
  • ran through onboarding by tapping on Start using Brave Rewards

Case 2 - Interact with rewards panel via NTP SI

  • installed & launched 1.18.72 CR: 87.0.4280.101
  • open several tabs till you get a NTP SI and click on the NTP SI modal
  • closed both the Start using Rewards& I'm In modals
  • closed Brave and moved the device time ahead by 24hrs
  • re-opened Brave and ensured that the rewards panel didn't open after launching
  • repeated the above 4 times until 4 days has been reached
  • launched Brave and ensured that the rewards panel wasn't automatically being opened

Verification PASSED on Samsung Galaxy Tablet A running Android 10 using 1.18.72 CR: 87.0.4280.101

Case 1 - No interaction with rewards panel

  • installed & launched 1.18.72 CR: 87.0.4280.101
  • open several tabs till you get a NTP SI and either close the tab/dismiss the NTP SI modal
  • closed Brave and moved the device time ahead by 24hrs
  • re-opened Brave and ensured that the rewards panel didn't open after launching
  • repeated the above 4 times until 4 days has been reached
  • launched Brave and ensured that the rewards panel appeared with the new opt-in onboarding flow
  • ran through onboarding by tapping on Start using Brave Rewards

Case 2 - Interact with rewards panel via NTP

  • installed & launched 1.18.72 CR: 87.0.4280.101
  • tapped on the BAT icon to open the rewards panel
  • dismiss the
  • moved the device time 4 days ahead
  • launched Brave and ensured that the rewards panel wasn't automatically being opened

Case 3 - Interact with rewards panel via NTP SI

  • installed & launched 1.18.72 CR: 87.0.4280.101
  • open several tabs till you get a NTP SI and click on the NTP SI modal
  • closed both the Start using Rewards& I'm In modals
  • closed Brave and moved the device time ahead by 24hrs
  • re-opened Brave and ensured that the rewards panel didn't open after launching
  • repeated the above 4 times until 4 days has been reached
  • launched Brave and ensured that the rewards panel wasn't automatically being opened

@kjozwiak kjozwiak mentioned this issue Dec 15, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@deeppandya deeppandya

Labels
feature/rewards onboarding Front-end related to helping a new user learn about features within the browser. OS/Android Fixes related to Android browser functionality QA Pass - Android ARM QA Pass - Android Tab QA/Yes release/blocking release-notes/exclude
Projects
None yet
Milestone
1.18.x - Release #2
Development

No branches or pull requests
3 participants
@kjozwiak @deeppandya @LaurenWags