Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix ac amount react page android 1.19.x (Uplift to 1.19.x) #7421

Merged
merged 7 commits into from
Dec 14, 2020
Merged

Fix ac amount react page android 1.19.x (Uplift to 1.19.x) #7421

merged 7 commits into from
Dec 14, 2020

Conversation

deeppandya
Copy link
Contributor

@deeppandya deeppandya commented Dec 12, 2020 •
edited by kjozwiak
Loading

Uplift of #7411
Resolves brave/brave-browser#13148 brave/brave-browser#13150 brave/brave-browser#13158 brave/brave-browser#13160 brave/brave-browser#13161 brave/brave-browser#13166

Approved, please ensure that before merging:

  • You have checked CI and the builds, lint, and tests all pass or are not related to your PR.
  • You have tested your change on Nightly.
  • The PR milestones match the branch they are landing to.

After you merge:

  • The associated issue milestone is set to the smallest version that the changes is landed on.

@deeppandya deeppandya added CI/skip-linux CI/skip-macos-x64 Do not run CI builds for macOS x64 CI/skip-ios Do not run CI builds for iOS labels Dec 12, 2020
@deeppandya deeppandya added this to the 1.19.x - Beta milestone Dec 12, 2020
@deeppandya deeppandya requested a review from a team December 12, 2020 09:50
@deeppandya deeppandya requested a review from a team as a code owner December 12, 2020 09:50
@deeppandya deeppandya requested review from marshall and emerick and removed request for a team December 12, 2020 09:50
@deeppandya deeppandya self-assigned this Dec 12, 2020
@kjozwiak
Copy link
Member

Looks like audit-deps failed as per https://ci.brave.com/job/pr-brave-browser-fix_ac_amount_react_page_android_1.19.x-android/3/execution/node/157/log/. However, the above audit-deps`` failures were already reported and are being addressed.

kjozwiak
kjozwiak approved these changes Dec 14, 2020
View reviewed changes
Copy link
Member

@kjozwiak kjozwiak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Uplift into 1.19.x after deliberating with @brave/uplift-approvers. QA has verified the PR on Nightly as per #7411 (comment).

@kjozwiak kjozwiak merged commit c5a2621 into 1.19.x Dec 14, 2020
@kjozwiak kjozwiak deleted the fix_ac_amount_react_page_android_1.19.x branch December 14, 2020 16:25
This was referenced Dec 14, 2020
Closed
Closed
Closed
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@que89 que89 que89 approved these changes

@kjozwiak kjozwiak kjozwiak approved these changes

@marshall marshall Awaiting requested review from marshall

@emerick emerick Awaiting requested review from emerick

Assignees

@deeppandya deeppandya

Labels
CI/skip-ios Do not run CI builds for iOS CI/skip-macos-x64 Do not run CI builds for macOS x64
Projects
None yet
Milestone
1.19.x - Release
Development

Successfully merging this pull request may close these issues.
3 participants
@deeppandya @kjozwiak @que89