[Android] crash when claiming promotions

[LaurenWags]

Description

Crash when attempting to claim a promotion.

Steps to reproduce

1. Clean install 1.20.23
2. Go to settings, enable Staging environment
3. Relaunch when prompted
4. Tap on BAT logo.
5. "x" out of large and small onboarding UI
6. UGP Grant notification is displayed.
7. Tap on "Claim" button.

Actual result

Get spinner for a second, then Brave crashes

Expected result

No crash, get grant as expected

Issue reproduces how often

100%

Version/Channel Information:

• Can you reproduce this issue with the current Play Store version? no
• Can you reproduce this issue with the current Play Store Beta version? n/a - beta crashes when tapping on BAT logo.
• Can you reproduce this issue with the current Play Store Nightly version? yes

Device details

• Install type (ARM, x86): ARM
• Device type (Phone, Tablet, Phablet): all
• Android version: all

Brave version

Website problems only

• Does the issue resolve itself when disabling Brave Shields? n/a
• Does the issue resolve itself when disabling Brave Rewards? n/a
• Is the issue reproducible on the latest version of Chrome? n/a

Additional information

cc @deeppandya @brave/legacy_qa

[kjozwiak]

@deeppandya we'll need to get this fixed QA won't be able to claim grants on staging and check tipping/a-c etc.. CCing @bsclifton @anthonypkeane.

[kjozwiak]

Closing this as it was fixed via brave/brave-core#7411 and was merged into 1.19.x & 1.18.x via brave/brave-core#7421 and brave/brave-core#7423.

[kjozwiak]

Verification PASSED on Samsung Galaxy Tablet A running Android 10 using 1.18.72 CR: 87.0.4280.101

• verified the STR/Cases outlined via [Android] crash when claiming promotions #13150 (comment) and claimed a UGP grant several times without crashing
  • claimed several UGP grants while the RE opt-in modal was visible via the rewards panel without crashes
  • claimed UGP via rewards panel and brave://rewards

---

Verification passed on LG Nexus 5 with Android 5.1 running 1.18.72 Bravearm.apk

• Verified able to claim UGP grant from panel without crash (staging env)
  

• Verified able to claim UGP grant from chrome://rewards without crash (staging env)