Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Default ad-block settings doesn't work as intended #1317

Closed
srirambv opened this issue Sep 27, 2018 · 2 comments
Closed

Default ad-block settings doesn't work as intended #1317

srirambv opened this issue Sep 27, 2018 · 2 comments

Comments

@srirambv
Copy link
Contributor

Description

While verifying #1288 found changing shields settings in preferences doesn't work as intended

Steps to Reproduce

  1. Clean launch profile
  2. Visit dailymail.co.uk in a new tab, ensure ads/trackers are blocked
  3. Change default ad settings to Allow all ads and trackers
  4. Go back to dailymail.co.uk tab and reload, shields still shows 3 blocked items all tracking scripts
  5. Change back default ad settings to Block ads and trackers
  6. Reload dailymail.co.uk and toggle ad settings in shields, count show 0, page loads all tracking scripts and ads on the page

Actual result:

https://youtu.be/l75ZWlgbySA

Expected result:

Should work as intended setting is set

Reproduces how often:

Easy

Brave version (chrome://version info)

Brave 0.55.10 Chromium: 70.0.3538.22 (Official Build) beta (64-bit)
Revision ac9418ba9c3bd7f6baaffa0b055dfe147e0f8364-refs/branch-heads/3538@{#468}
OS Windows

Reproducible on current release:

No b-l settings work as expected

Website problems only:

  • Does the issue resolve itself when disabling Brave Shields?
  • Is the issue reproducible on the latest version of Chrome?

Additional Information

#1288

@srirambv srirambv added bug feature/shields The overall Shields feature in Brave. release/blocking feature/global-settings Settings at browser level independent of shields settings labels Sep 27, 2018
@srirambv srirambv added this to the Releasable builds 0.55.x milestone Sep 27, 2018
@bbondy bbondy changed the title Default shields settings doesn't work as intended Default ad-block settings doesn't work as intended Sep 29, 2018
@bbondy
Copy link
Member

bbondy commented Sep 29, 2018

Pretty sure it was all working correctly except for just the ad-block setting, but that should be fixed with the latest merge.

@LaurenWags
Copy link
Member

LaurenWags commented Oct 12, 2018

Verified passed on

Brave 0.55.12 Chromium: 70.0.3538.45 (Official Build) beta(64-bit)
Revision cbdc32e4334458954e9def214d7e5fa1ca1960eb-refs/branch-heads/3538@{#830}
OS Mac OS X
  • Verified STR from description

Verification Passed on

Brave 0.55.13 Chromium: 70.0.3538.54 (Official Build) beta (64-bit)
Revision 4f8e578b6680574714e9ed3bb9f02922b4dde40d-refs/branch-heads/3538@{#937}
OS Windows
  • Verified STR from description

Verification Passed on

Brave 0.55.14 Chromium: 70.0.3538.54 (Official Build) beta(64-bit)
Revision 4f8e578b6680574714e9ed3bb9f02922b4dde40d-refs/branch-heads/3538@{#937}
OS Linux

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

5 participants