Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Default brave shield pref settings - Basic UI #1288

Closed
bbondy opened this issue Sep 26, 2018 · 5 comments · Fixed by brave/brave-core#436
Closed

Default brave shield pref settings - Basic UI #1288

bbondy opened this issue Sep 26, 2018 · 5 comments · Fixed by brave/brave-core#436

Comments

@bbondy
Copy link
Member

bbondy commented Sep 26, 2018

Test plan

  1. Fresh profile
  2. In tab 1, open chrome://settings and verify there is a new section Brave shields defaults
  3. In tab 2, open https://dailymail.co.uk and verify ads are being blocked (visually and using shields menu)
  4. In tab 1 (chrome://settings), set Ad Control to Allow ads and tracking
  5. Refresh tab 2 (dailymail) and verify that ads are being shown (and that shields has 0 blocked)
  6. Use the shields icon in the top right of the page and set Ad Control to Block ads
  7. tab 2 will refresh itself after the change; verify that ads are being blocked again (which overrides the global setting)
  8. Repeat the above steps for Cookie control, Fingerprinting protection, HTTPS Everywhere, and Script blocking

The above can be tested in a private window too- but it may not work because of a known issue which is captured here: #1198

Description

Have a global shield settings, similar to the one available in our Muon based product. We only need to implement the raw functionality. Updating the styling to match our brand is covered with #606
screen shot 2018-09-26 at 11 58 47 am

@bbondy
Copy link
Member Author

bbondy commented Sep 26, 2018

screen shot 2018-09-26 at 1 53 57 pm

@srirambv
Copy link
Contributor

This fails on 0.55.10.

  1. Setting Allow ads and tracking in global settings still blocks tracking scripts on shields
  2. Changing shields settings to Allow ads and tracking sets count to 0

Here's the steps recording https://youtu.be/l75ZWlgbySA

@bbondy
Copy link
Member Author

bbondy commented Sep 27, 2018

@srirambv can you try with a fresh page load and not a reload? Same results?

@srirambv
Copy link
Contributor

With new page load in a new tab still same result. 3 tracking scripts are still blocked even if global shield settings is set to Allow ads and tracking.

@srirambv
Copy link
Contributor

srirambv commented Oct 16, 2018

Verification Passed on

Brave 0.55.14 Chromium: 70.0.3538.54 (Official Build) beta(64-bit)
Revision 4f8e578b6680574714e9ed3bb9f02922b4dde40d-refs/branch-heads/3538@{#937}
OS Linux
  • Verified global settings can be overridden from shields
  • Verified global settings take effect on a page when loaded

Verified passed with

Brave 0.55.14 Chromium: 70.0.3538.54 (Official Build) beta(64-bit)
Revision 4f8e578b6680574714e9ed3bb9f02922b4dde40d-refs/branch-heads/3538@{#937}
OS Mac OS X
  • Verified test plan from description. Global settings take effect on a page when loaded and can be overridden from shields.

Verification Passed on

Brave 0.55.16 Chromium: 70.0.3538.54 (Official Build) (64-bit)
Revision 4f8e578b6680574714e9ed3bb9f02922b4dde40d-refs/branch-heads/3538@{#937}
OS Windows
  • Verified test plan from description. Global settings take effect on a page when loaded and can be overridden from shields.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment