-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Default brave shield pref settings - Basic UI #1288
Labels
Milestone
Comments
bbondy
added a commit
that referenced
this issue
Sep 26, 2018
bbondy
added a commit
that referenced
this issue
Sep 26, 2018
Requires: brave/brave-core#436 Fix #1288
This was referenced Sep 26, 2018
bbondy
added a commit
to brave/brave-core
that referenced
this issue
Sep 26, 2018
This fails on 0.55.10.
Here's the steps recording https://youtu.be/l75ZWlgbySA |
@srirambv can you try with a fresh page load and not a reload? Same results? |
With new page load in a new tab still same result. 3 tracking scripts are still blocked even if global shield settings is set to Allow ads and tracking. |
Verification Passed on
Verified passed with
Verification Passed on
|
petemill
pushed a commit
to brave/brave-core
that referenced
this issue
Jul 27, 2020
petemill
pushed a commit
to brave/brave-core
that referenced
this issue
Jul 28, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Test plan
Brave shields defaults
Ad Control
toAllow ads and tracking
Ad Control
toBlock ads
Cookie control
,Fingerprinting protection
,HTTPS Everywhere
, andScript blocking
The above can be tested in a private window too- but it may not work because of a known issue which is captured here: #1198
Description
Have a global shield settings, similar to the one available in our Muon based product. We only need to implement the raw functionality. Updating the styling to match our brand is covered with #606
The text was updated successfully, but these errors were encountered: