-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update styles in Shields panel #1339
Comments
@rebron |
@srirambv Let me get the screenshot updated to remove that text. I didn't have it defined in the initial issue. |
@srirambv I updated the screenshot for Shields down view. Should be accurate now. |
Moving redesigned shields to 0.56.x but if it's done and tested I have no problem moving it back to 0.55.x. I hope we can do that but I don't want to introduce slippage risk for the rest which was spec'ed on time, so until that is the case it will live in 0.56.x. |
Updated screenshot and issue description. |
Here's the updated specification for this feature. Please QA against the spec. |
Verification Passed on
Verification Passed on
Shield up Shield Down Verified passed with
|
Update Shields UI to match brave-core styling.
Design
Shields Up View
Shields Down View
Description
For Shields Up View, match design above with shields toggle on.
Label ‘Shields Up for this site’ with text below
‘If a site appears broken, try shields down’
Display favicon if available and first party domain name
Display total items blocked
Display 'Ads and trackers blocked' with toggle
Display number of items blocked
Toggle is Default on
Display '3rd-party cookies blocked' with drop down
Display number of items blocked
Drop down menu items:
‘3rd-party cookies blocked’ (default)
‘All cookies blocked'
‘Allow all cookies’
Display '3rd-party scripts blocked' with drop down
Display number of items blocked
Drop down menu items:
‘3rd-party scripts blocked’ (default)
‘All scripts blocked'
‘Allow all scripts’
Display '3rd-party device recognition attempts blocked' (this is fingerprinting) with drop down
Display number of items blocked
Drop down menu items:
‘3rd-party device recognition attempts blocked’ (default)
‘All device recognition attempts blocked'
‘Allow all device recognition attempts’
Display number of ‘Connections encrypted’
Link to Global Shield defaults with icon
chrome://settings/shields
For Shields Down View - Second screenshot
Shields toggle off with label 'Shields Down for this site'
Display favicon and first party domain name
Display shield ! alert icon with text:
‘You’re browsing this site without any privacy and security protections.’
Link to Global Shield defaults with icon
chrome://settings/shields
The text was updated successfully, but these errors were encountered: