Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Brave Ads fails to upgrade segment database table from 1.19.x to 1.20.x and above #13719

Closed
tmancey opened this issue Jan 22, 2021 · 3 comments · Fixed by brave/brave-core#7678
Closed

Brave Ads fails to upgrade segment database table from 1.19.x to 1.20.x and above #13719

tmancey opened this issue Jan 22, 2021 · 3 comments · Fixed by brave/brave-core#7678
Assignees
@tmancey
Labels
bug feature/ads OS/Desktop priority/P1 A very extremely bad problem. We might push a hotfix for it. QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Yes release-notes/exclude
Milestone
1.20.x - Release

Comments

@tmancey
Copy link
Contributor

tmancey commented Jan 22, 2021 •
edited
Loading

Description

Brave Ads fails to upgrade segment database table from 1.19.x to 1.20.x and above

Steps to Reproduce

Test Case 1:

  1. Install 1.19.x
  2. Upgrade to 1.20.x

Test Case 2:

  1. Install 1.19.x
  2. Upgrade to 1.21.x

Actual result:

Brave ads are not delivered due to failing to initialize ads

Expected result:

Brave ads should be delivered

Reproduces how often:

Easily reproduced

Brave version (brave://version info)

Version/Channel Information:

  • Can you reproduce this issue with the current release? No
  • Can you reproduce this issue with the beta channel? Yes
  • Can you reproduce this issue with the nightly channel? Yes

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields? N/A
  • Does the issue resolve itself when disabling Brave Rewards? N/A
  • Is the issue reproducible on the latest version of Chrome? N/A

Miscellaneous Information:

No user data is lost, ads will work as expected after applying this fix.
@tmancey tmancey added bug priority/P1 A very extremely bad problem. We might push a hotfix for it. QA/Yes release-notes/exclude feature/ads OS/Desktop labels Jan 22, 2021
@tmancey tmancey self-assigned this Jan 22, 2021
@tmancey tmancey mentioned this issue Jan 22, 2021
Merged
23 tasks
@tmancey tmancey changed the title Brave Ads fails to upgrade segment database table from 1.19.x to 1.20.x and 1.21.x Brave Ads fails to upgrade segment database table from 1.19.x to 1.20.x and above Jan 22, 2021
This was referenced Jan 22, 2021
Merged
Closed
@tmancey tmancey added this to the 1.21.x - Nightly milestone Jan 23, 2021
@tmancey tmancey mentioned this issue Jan 27, 2021
Closed
@kjozwiak
Copy link
Member

kjozwiak commented Jan 29, 2021 •
edited
Loading

@tmancey should this also be QA'd/verified on Android? Assuming Android also uses the same DB? If so, mind adding the OS/Android label?

@tmancey
Copy link
Contributor Author

tmancey commented Jan 29, 2021

@kjozwiak Android testing would not hurt, however this is shared logic so desktop is good enough for me. Thanks

@LaurenWags
Copy link
Member

LaurenWags commented Feb 1, 2021 •
edited by GeetaSarvadnya
Loading

Verified passed with

Brave	1.20.95 Chromium: 88.0.4324.96 (Official Build) beta (x86_64)
Revision	68dba2d8a0b149a1d3afac56fa74648032bcf46b-refs/branch-heads/4324@{#1784}
OS	macOS Version 10.15.7 (Build 19H15)

Verified STR from description and brave/brave-core#7678 (comment)

Test Case 1
  1. Installed 1.19.88 CR: 88.0.4324.96 and confirmed ads were working via notifications/NTP
  2. Set Maximum number of ads displayed to 5 before viewing ads
  3. Confirmed Estimated pending rewards, Ads received this month and the 7 Day History were being updated
  4. Installed 1.20.95 CR: 88.0.4324.96
  5. Renamed profile folder from Brave-Browser to Brave-Browser-Beta
  6. Launched 1.20.95 CR: 88.0.4324.96
  7. Confirmed NTP ads are being counted/displayed in brave://rewards. Example:
[12344:775:0201/085959.347651:VERBOSE3:new_tab_page_ad_event_viewed.cc(26)] Viewed new tab page ad with uuid 6fca2fe7-384a-4913-954b-9299683d3e73 and creative instance id 0d2619aa-ce2f-42fc-a05f-bad9303494ec
[12344:775:0201/085959.347833:VERBOSE1:confirmations.cc(90)] Confirming view ad for creative instance id 0d2619aa-ce2f-42fc-a05f-bad9303494ec
  1. Confirmed ad notifications are being counted/displayed in brave://rewards. Example:
[12344:775:0201/090126.800320:VERBOSE1:text_classification_model.cc(94)] No text classification probabilities found for en-US locale
[12344:775:0201/090126.809581:VERBOSE1:ad_notification_serving.cc(165)] Serve ad for segments:
[12344:775:0201/090126.809692:VERBOSE1:ad_notification_serving.cc(167)]   untargeted
[12344:775:0201/090126.877298:VERBOSE2:ad_notification_serving.cc(273)] 67 eligible ads before pacing
[12344:775:0201/090126.877753:VERBOSE2:eligible_ads_priority_filter.cc(81)] 67 eligible ads with a priority of 2
[12344:775:0201/090126.877982:VERBOSE2:ad_notification_serving.cc(278)] 67 eligible ads after pacing
[12344:775:0201/090126.878029:VERBOSE1:ad_notification_serving.cc(264)] Found 67 eligible ads
[12344:775:0201/090126.878821:VERBOSE1:ads_service_impl.cc(1769)] Timeout ad notification with uuid d79f09b0-3e4e-4a62-a82f-20bdb1ab8d3f in 120 seconds
[12344:775:0201/090126.878974:VERBOSE1:ad_notification_serving.cc(101)] Ad notification delivered:
  uuid: d79f09b0-3e4e-4a62-a82f-20bdb1ab8d3f
  creativeInstanceId: 54828e19-a43c-409b-aeae-b3f14a30e49b
  creativeSetId: 23582adc-9c20-4cde-bc56-f3b21d1aaf33
  campaignId: 4e232dcf-adeb-477a-ab48-49223da3da4c
  segment: untargeted
  title: eBay Activewear 
  body: Up to 60% off activewear from Champion, Puma and more. 
  targetUrl: https://rover.ebay.com/rover/1/711-53200-19255-0/1?ff3=4&pub=5575569333&toolid=10001&campid=5338653463&customid=activewear&mpre=https%3A%2F%2Fwww.ebay.com%2Fe%2Ffashion%2Fnyny-activewear-123019
[12344:775:0201/090126.879022:VERBOSE3:ad_notification_event_viewed.cc(24)] Viewed ad notification with uuid d79f09b0-3e4e-4a62-a82f-20bdb1ab8d3f and creative instance id 54828e19-a43c-409b-aeae-b3f14a30e49b
[12344:775:0201/090126.879111:VERBOSE1:confirmations.cc(90)] Confirming view ad for creative instance id 54828e19-a43c-409b-aeae-b3f14a30e49b
  1. Confirmed Estimated pending rewards, Ads received this month and the 7 Day History were being updated.
TC 1 a TC 1 b 
Brave	1.21.36 Chromium: 88.0.4324.96 (Official Build) nightly (x86_64)
Revision	68dba2d8a0b149a1d3afac56fa74648032bcf46b-refs/branch-heads/4324@{#1784}
OS	macOS Version 10.15.7 (Build 19H15)
Test Case 2
  1. Installed 1.19.88 CR: 88.0.4324.96 and confirmed ads were working via notifications/NTP
  2. Set Maximum number of ads displayed to 5 before viewing ads
  3. Confirmed Estimated pending rewards, Ads received this month and the 7 Day History were being updated
  4. Installed 1.21.36 CR: 88.0.4324.96
  5. Renamed profile folder from Brave-Browser to Brave-Browser-Nightly
  6. Launched 1.21.36 CR: 88.0.4324.96
  7. Confirmed NTP ads are being counted/displayed in brave://rewards. Example:
[12601:775:0201/092259.006880:VERBOSE3:new_tab_page_ad_event_viewed.cc(24)] Viewed new tab page ad with uuid 2dfb1e82-8510-42ee-87ef-7c77b634f99b and creative instance id 0d2619aa-ce2f-42fc-a05f-bad9303494ec
[12601:775:0201/092259.007061:VERBOSE1:confirmations.cc(90)] Confirming view ad for creative instance id 0d2619aa-ce2f-42fc-a05f-bad9303494ec
  1. Confirmed ad notifications are being counted/displayed in brave://rewards. Example:
[12601:775:0201/091924.743282:VERBOSE1:ad_notification_serving.cc(165)] Serve ad for segments:
[12601:775:0201/091924.743350:VERBOSE1:ad_notification_serving.cc(167)]   technology & computing-software
[12601:775:0201/091924.743391:VERBOSE1:ad_notification_serving.cc(167)]   personal finance-personal finance
[12601:775:0201/091924.743427:VERBOSE1:ad_notification_serving.cc(167)]   home-appliances
[12601:775:0201/091924.744682:VERBOSE1:ad_notification_serving.cc(182)] No eligible ads found for segments
[12601:775:0201/091924.744754:VERBOSE1:ad_notification_serving.cc(197)] Serve ad for parent segments:
[12601:775:0201/091924.744795:VERBOSE1:ad_notification_serving.cc(199)]   technology & computing
[12601:775:0201/091924.744831:VERBOSE1:ad_notification_serving.cc(199)]   personal finance
[12601:775:0201/091924.744866:VERBOSE1:ad_notification_serving.cc(199)]   home
[12601:775:0201/091924.977453:VERBOSE2:ad_notification_serving.cc(273)] 244 eligible ads before pacing
[12601:775:0201/091924.977714:VERBOSE2:ad_notification_pacing.cc(46)] Pacing ad delivery for creative instance id fb2addd4-9d52-4b09-a131-443f41b8b2b9 [Roll(0.915838):0.947382]
[12601:775:0201/091924.978744:VERBOSE2:eligible_ads_priority_filter.cc(81)] 112 eligible ads with a priority of 1
[12601:775:0201/091924.978788:VERBOSE3:eligible_ads_priority_filter.cc(89)] 131 ads with a lower priority of 2
[12601:775:0201/091924.979283:VERBOSE2:ad_notification_serving.cc(278)] 112 eligible ads after pacing
[12601:775:0201/091924.979316:VERBOSE1:ad_notification_serving.cc(264)] Found 112 eligible ads
[12601:775:0201/091924.985659:VERBOSE1:ads_service_impl.cc(1780)] Timeout ad notification with uuid 0680c508-7e24-4d60-a1a3-64147191feaf in 120 seconds
[12601:775:0201/091924.988952:VERBOSE1:ad_notification_serving.cc(101)] Ad notification delivered:
  uuid: 0680c508-7e24-4d60-a1a3-64147191feaf
  creativeInstanceId: 75e501ff-4fa6-4cbe-beaf-2d6accdb7a41
  creativeSetId: 9e63ad28-0753-4bb9-ae69-043725af72e6
  campaignId: 35831709-9187-4ebf-b584-6096138064eb
  segment: personal finance
  title: Gemini - Bitcoin Is Up 300%
  body: Build your crypto empire with Gemini!
  targetUrl: https://getstarted.gemini.com/time-for-crypto/
[12601:775:0201/091924.989116:VERBOSE3:ad_notification_event_viewed.cc(24)] Viewed ad notification with uuid 0680c508-7e24-4d60-a1a3-64147191feaf and creative instance id 75e501ff-4fa6-4cbe-beaf-2d6accdb7a41
[12601:775:0201/091924.989241:VERBOSE1:confirmations.cc(90)] Confirming view ad for creative instance id 75e501ff-4fa6-4cbe-beaf-2d6accdb7a41
  1. Confirmed Estimated pending rewards, Ads received this month and the 7 Day History were being updated.
TC2a TC2b

Verification passed on

Brave 1.20.97 Chromium: 88.0.4324.96 (Official Build) dev (64-bit)
Revision 68dba2d8a0b149a1d3afac56fa74648032bcf46b-refs/branch-heads/4324@{#1784}
OS Ubuntu 18.04 LTS

Verified STR from description and brave/brave-core#7678 (comment)

Test Case 1
  1. Installed 1.19.88 CR: 88.0.4324.96 and confirmed ads were working via notifications/NTP
  2. Set Maximum number of ads displayed to 5 before viewing ads
  3. Confirmed Estimated pending rewards, Ads received this month and the 7 Day History were being updated
  4. Renamed profile folder from Brave-Browser to Brave-Browser-Beta
  5. Launched 1.20.x

Note: Needed to restart the browser to show ads

Verified NTP ads are being counted. Example:

[27207:27207:0202/222517.310474:VERBOSE3:new_tab_page_ad_event_viewed.cc(26)] Viewed new tab page ad with uuid 0662a353-64e2-4ca6-bb17-cde90002b016 and creative instance id 23c56f6c-4632-41d5-8b96-8af84f0d324a
[27207:27207:0202/222517.310850:VERBOSE1:confirmations.cc(90)] Confirming view ad for creative instance id 23c56f6c-4632-41d5-8b96-8af84f0d324a

Verified ad notifications are being counted. Example:

[27207:27207:0202/222922.453191:VERBOSE1:ad_notification_serving.cc(165)] Serve ad for segments:
[27207:27207:0202/222922.453370:VERBOSE1:ad_notification_serving.cc(167)]   untargeted
[27207:27207:0202/222922.457441:VERBOSE2:ad_notification_serving.cc(273)] 18 eligible ads before pacing
[27207:27207:0202/222922.457706:VERBOSE2:eligible_ads_priority_filter.cc(81)] 18 eligible ads with a priority of 2
[27207:27207:0202/222922.457891:VERBOSE2:ad_notification_serving.cc(278)] 18 eligible ads after pacing
[27207:27207:0202/222922.458024:VERBOSE1:ad_notification_serving.cc(264)] Found 18 eligible ads
[27207:27207:0202/222922.471934:VERBOSE1:ad_notification_serving.cc(101)] Ad notification delivered:
  uuid: f0d7474e-7197-4e8c-820a-c3739578eb3c
  creativeInstanceId: 98acf8ac-9071-45eb-a161-8d790e73679c
  creativeSetId: 21dc5dff-7146-432d-b819-e4174b6ac7b5
  campaignId: 90dcffe3-348e-4af1-a399-2ec632b92256
  segment: untargeted
  title: Fiverr
  body: Find the perfect freelance services for your business
[27207:27207:0202/222923.054014:VERBOSE1:confirmations.cc(224)] Successfully redeemed unblinded token with confirmation id 51b671f5-63f3-4149-ae4c-f19566415b3c, creative instance id 98acf8ac-9071-45eb-a161-8d790e73679c and view
[27207:27207:0202/222923.055483:VERBOSE1:confirmations.cc(245)] Added 1 unblinded payment token with an estimated redemption value of 0.01 BAT, you now have 4 unblinded payment tokens

Verified Estimated pending rewards, Ads received this month and the 7 Day History were being updated.
image
image

Encountered #13815 while testing

Verification passed on

Brave 1.21.38 Chromium: 88.0.4324.96 (Oficjalna wersja) nightly (64-bitowa)
Wersja 68dba2d8a0b149a1d3afac56fa74648032bcf46b-refs/branch-heads/4324@{#1784}
OS Ubuntu 18.04 LTS
Test Case 2
  1. Installed 1.19.88 CR: 88.0.4324.96 and confirmed ads were working via notifications/NTP
  2. Set Maximum number of ads displayed to 5 before viewing ads
  3. Confirmed Estimated pending rewards, Ads received this month and the 7 Day History were being updated
  4. Renamed profile folder from Brave-Browser to Brave-Browser-Nightly
  5. Launched 1.21.x

Verified NTP ads are being counted. Example:

[29913:29913:0202/231348.096927:VERBOSE3:new_tab_page_ad_event_viewed.cc(24)] Viewed new tab page ad with uuid 21d2bd85-78dd-4336-b347-cef5b6692535 and creative instance id 23c56f6c-4632-41d5-8b96-8af84f0d324a
[29913:29913:0202/231348.098088:VERBOSE1:confirmations.cc(90)] Confirming view ad for creative instance id 23c56f6c-4632-41d5-8b96-8af84f0d324a
[29913:29913:0202/231348.682838:VERBOSE1:confirmations.cc(224)] Successfully redeemed unblinded token with confirmation id 5a8a1b4e-2ddb-45f5-b960-7bb6d0f98bee, creative instance id 23c56f6c-4632-41d5-8b96-8af84f0d324a and view
[29913:29913:0202/231348.682986:VERBOSE1:confirmations.cc(245)] Added 1 unblinded payment token with an estimated redemption value of 0.01 BAT, you now have 4 unblinded payment tokens

Verified ad notifications are being counted. Example:

[29913:29913:0202/234155.228397:VERBOSE1:ad_notification_serving.cc(165)] Serve ad for segments:
[29913:29913:0202/234155.228504:VERBOSE1:ad_notification_serving.cc(167)]   untargeted
[29913:29913:0202/234155.232395:VERBOSE2:ad_notification_serving.cc(273)] 18 eligible ads before pacing
[29913:29913:0202/234155.232598:VERBOSE2:eligible_ads_priority_filter.cc(81)] 18 eligible ads with a priority of 2
[29913:29913:0202/234155.232742:VERBOSE2:ad_notification_serving.cc(278)] 18 eligible ads after pacing
[29913:29913:0202/234155.232859:VERBOSE1:ad_notification_serving.cc(264)] Found 18 eligible ads
[29913:29913:0202/234155.259264:VERBOSE1:ad_notification_serving.cc(101)] Ad notification delivered:
  uuid: 5fa8d5a4-c167-4471-b8d6-fd97f833a153
  creativeInstanceId: b80dffc0-00d4-432b-9103-3b6b55d5190b
  creativeSetId: 21dc5dff-7146-432d-b819-e4174b6ac7b5
  campaignId: 90dcffe3-348e-4af1-a399-2ec632b92256
  segment: untargeted
  title: Learn. from Fiverr
  body: In-Demand Skills, On-Demand Courses.
[29913:29913:0202/234155.875269:VERBOSE1:confirmations.cc(224)] Successfully redeemed unblinded token with confirmation id 899c7549-770f-4f15-a2f7-bac65eb12134, creative instance id b80dffc0-00d4-432b-9103-3b6b55d5190b and view
[29913:29913:0202/234155.876003:VERBOSE1:confirmations.cc(245)] Added 1 unblinded payment token with an estimated redemption value of 0.01 BAT, you now have 5 unblinded payment tokens

Verified Estimated pending rewards, Ads received this month and the 7 Day History were being updated.
image
image

Verification passed on


Brave | 1.20.97 Chromium: 88.0.4324.96 (Official Build) dev (64-bit)
-- | --
Revision | 68dba2d8a0b149a1d3afac56fa74648032bcf46b-refs/branch-heads/4324@{#1784}
OS | Windows 10 OS Version 2004 (Build 19041.746)

Verified STR from description and brave/brave-core#7678 (comment)

Test Case 1
  1. Installed 1.19.88 CR: 88.0.4324.96 and confirmed ads were working via notifications/NTP
  2. Set Maximum number of ads displayed to 5 before viewing ads
  3. Confirmed Estimated pending rewards, Ads received this month and the 7 Day History were being updated
  4. Installed 1.20.97 CR: 88.0.4324.96
  5. Renamed profile folder from Brave-Browser to Brave-Browser-Dev
  6. Launched 1.20.97 CR: 88.0.4324.96
  7. Confirmed NTP ads are being counted/displayed in brave://rewards. Example:
[22648:15512:0204/184213.143:VERBOSE3:new_tab_page_ad_event_viewed.cc(26)] Viewed new tab page ad with uuid 859880d1-bfcb-46e4-bbaa-75696f7f3f72 and creative instance id f4cbc2b4-a69e-482b-802e-d5e59da17252
[22648:15512:0204/184213.143:VERBOSE1:confirmations.cc(90)] Confirming view ad for creative instance id f4cbc2b4-a69e-482b-802e-d5e59da17252
  1. Confirmed ad notifications are being counted/displayed in brave://rewards. Example:
[22648:15512:0204/185518.712:VERBOSE1:ad_notification_serving.cc(165)] Serve ad for segments:
[22648:15512:0204/185518.715:VERBOSE1:ad_notification_serving.cc(167)]   technology & computing-software
[22648:15512:0204/185518.716:VERBOSE1:ad_notification_serving.cc(167)]   home-appliances
[22648:15512:0204/185518.717:VERBOSE1:ad_notification_serving.cc(167)]   personal finance-personal finance
[22648:15512:0204/185518.718:VERBOSE1:ad_notification_serving.cc(182)] No eligible ads found for segments
[22648:15512:0204/185518.718:VERBOSE1:ad_notification_serving.cc(197)] Serve ad for parent segments:
[22648:15512:0204/185518.719:VERBOSE1:ad_notification_serving.cc(199)]   technology & computing
[22648:15512:0204/185518.719:VERBOSE1:ad_notification_serving.cc(199)]   home
[22648:15512:0204/185518.720:VERBOSE1:ad_notification_serving.cc(199)]   personal finance
[22648:15512:0204/185518.729:VERBOSE2:ad_notification_serving.cc(273)] 129 eligible ads before pacing
[22648:15512:0204/185518.730:VERBOSE2:eligible_ads_priority_filter.cc(81)] 56 eligible ads with a priority of 1
[22648:15512:0204/185518.730:VERBOSE3:eligible_ads_priority_filter.cc(89)] 73 ads with a lower priority of 2
[22648:15512:0204/185518.730:VERBOSE2:ad_notification_serving.cc(278)] 56 eligible ads after pacing
[22648:15512:0204/185518.731:VERBOSE1:ad_notification_serving.cc(264)] Found 56 eligible ads
[22648:15512:0204/185518.731:VERBOSE1:ads_service_impl.cc(1769)] Timeout ad notification with uuid f20f38ca-4e10-47bd-bad8-000a3fa57bd2 in 120 seconds
[22648:15512:0204/185518.732:VERBOSE1:ad_notification_serving.cc(101)] Ad notification delivered:
  uuid: f20f38ca-4e10-47bd-bad8-000a3fa57bd2
  creativeInstanceId: 8f161dfa-7bf3-433b-9590-9d098635b544
  creativeSetId: 5e0743eb-a516-4bcd-8605-f52982a57af3
  campaignId: cc3a515f-cc43-4816-aa93-749c2b942a8f
  segment: personal finance
  title: BAT for Blockchain Gaming
  body: Splinterlands and Gala Games accept BAT. Learn more.
  targetUrl: https://basicattentiontoken.org/#participants?utility=gaming
[22648:15512:0204/185518.732:VERBOSE3:ad_notification_event_viewed.cc(24)] Viewed ad notification with uuid f20f38ca-4e10-47bd-bad8-000a3fa57bd2 and creative instance id 8f161dfa-7bf3-433b-9590-9d098635b544
[22648:15512:0204/185518.733:VERBOSE1:confirmations.cc(90)] Confirming view ad for creative instance id 8f161dfa-7bf3-433b-9590-9d098635b544
  1. Confirmed Estimated pending rewards, Ads received this month and the 7 Day History were being updated.
    image

image


Brave | 1.21.42 Chromium: 88.0.4324.146 (Official Build) nightly (64-bit)
-- | --
Revision | 406dc88511162d6598242f2c709be1414a042fb0-refs/branch-heads/4324@{#2088}
OS | Windows 10 OS Version 2004 (Build 19041.746)
Test Case 2
  1. Installed 1.19.88 CR: 88.0.4324.96 and confirmed ads were working via notifications/NTP
  2. Set Maximum number of ads displayed to 5 before viewing ads
  3. Confirmed Estimated pending rewards, Ads received this month and the 7 Day History were being updated
  4. Installed 1.21.42 CR: 88.0.4324.146
  5. Renamed profile folder from Brave-Browser to Brave-Browser-Nightly
  6. Launched 1.21.42 CR: 88.0.4324.146
  7. Confirmed NTP ads are being counted/displayed in brave://rewards. Example:
[19084:15496:0204/200653.399:VERBOSE3:new_tab_page_ad_event_viewed.cc(24)] Viewed new tab page ad with uuid 7a48cd5a-029d-43bb-b3c5-55a05896ac9b and creative instance id f4cbc2b4-a69e-482b-802e-d5e59da17252
[19084:15496:0204/200653.399:VERBOSE1:confirmations.cc(90)] Confirming view ad for creative instance id f4cbc2b4-a69e-482b-802e-d5e59da17252
  1. Confirmed ad notifications are being counted/displayed in brave://rewards. Example:
[19084:15496:0204/200731.398:VERBOSE1:ad_notification_serving.cc(167)]   technology & computing-software
[19084:15496:0204/200731.404:VERBOSE1:ad_notification_serving.cc(167)]   personal finance-personal finance
[19084:15496:0204/200731.404:VERBOSE1:ad_notification_serving.cc(167)]   home-appliances
[19084:15496:0204/200731.406:VERBOSE1:ad_notification_serving.cc(182)] No eligible ads found for segments
[19084:15496:0204/200731.406:VERBOSE1:ad_notification_serving.cc(197)] Serve ad for parent segments:
[19084:15496:0204/200731.407:VERBOSE1:ad_notification_serving.cc(199)]   technology & computing
[19084:15496:0204/200731.408:VERBOSE1:ad_notification_serving.cc(199)]   personal finance
[19084:15496:0204/200731.409:VERBOSE1:ad_notification_serving.cc(199)]   home
[19084:15496:0204/200731.421:VERBOSE2:ad_notification_serving.cc(273)] 135 eligible ads before pacing
[19084:15496:0204/200731.421:VERBOSE2:eligible_ads_priority_filter.cc(81)] 56 eligible ads with a priority of 1
[19084:15496:0204/200731.424:VERBOSE3:eligible_ads_priority_filter.cc(89)] 79 ads with a lower priority of 2
[19084:15496:0204/200731.424:VERBOSE2:ad_notification_serving.cc(278)] 56 eligible ads after pacing
[19084:15496:0204/200731.425:VERBOSE1:ad_notification_serving.cc(264)] Found 56 eligible ads
[19084:15496:0204/200731.433:VERBOSE1:ads_service_impl.cc(1780)] Timeout ad notification with uuid 2068b968-3613-4455-898a-bb577bed8100 in 120 seconds
[19084:15496:0204/200731.435:VERBOSE1:ad_notification_serving.cc(101)] Ad notification delivered:
  uuid: 2068b968-3613-4455-898a-bb577bed8100
  creativeInstanceId: 2bbfe04a-2bdd-49ae-a74f-692bb9265a7d
  creativeSetId: 5e0743eb-a516-4bcd-8605-f52982a57af3
  campaignId: cc3a515f-cc43-4816-aa93-749c2b942a8f
  segment: personal finance
  title: Learn about BAT
  body: One of the most successful cryptocurrency projects to date.
  targetUrl: https://basicattentiontoken.org/#bat-utility?utility=co
[19084:15496:0204/200731.436:VERBOSE3:ad_notification_event_viewed.cc(24)] Viewed ad notification with uuid 2068b968-3613-4455-898a-bb577bed8100 and creative instance id 2bbfe04a-2bdd-49ae-a74f-692bb9265a7d
[19084:15496:0204/200731.437:VERBOSE1:confirmations.cc(90)] Confirming view ad for creative instance id 2bbfe04a-2bdd-49ae-a74f-692bb9265a7d
  1. Confirmed Estimated pending rewards, Ads received this month and the 7 Day History were being updated.
    image
    image

@tmancey tmancey added this to Ads Jun 10, 2024
@tmancey tmancey moved this to Done in Ads Jun 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tmancey tmancey

Labels
bug feature/ads OS/Desktop priority/P1 A very extremely bad problem. We might push a hotfix for it. QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Yes release-notes/exclude
Projects
Ads
Archived in project
Milestone
1.20.x - Release
5 participants
@tmancey @kjozwiak @LaurenWags @btlechowski @GeetaSarvadnya