Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Users are not rewarded for viewing an NTP SI until the browser is restarted #13815

Closed
GeetaSarvadnya opened this issue Jan 28, 2021 · 10 comments · Fixed by brave/brave-core#12766

Comments

@GeetaSarvadnya
Copy link

GeetaSarvadnya commented Jan 28, 2021

Description

Users are not rewarded for viewing an NTP SI until the browser is restarted.

Steps to Reproduce

Scenario 1:

  1. Clean profile 1.19.86
  2. Enable rewards & Ads via brave://rewards
  3. Upgrade to 1.19.88
  4. View an NTP SI
  5. Users are not rewarded for viewing NTP SI
  6. Restart the browser fixes the issue

Scenario 2:

  1. Clean profile 1.19.86
  2. Enable rewards and disable Ads
  3. Upgrade to 1.19.88 and enable Ads
  4. View an NTP SI
  5. Users are not rewarded for viewing NTP SI
  6. Restart the browser fixes the issue

Note: Restart browser fixes the issue only for US locale not for India

Actual result:

Users are not rewarded for viewing an NTP SI until the browser is restarted

[14580:13968:0128/183408.571:INFO:creative_new_tab_page_ads_database_table.cc(426)] Failed to get creative new tab page ad
[14580:13968:0128/183408.571:VERBOSE1:new_tab_page_ad.cc(77)] Failed to fire new tab page ad event for wallpaper id

Expected result:

Users should be rewarded for viewing an NTP SI without a browser restart

Reproduces how often:

Easy

Brave version (brave://version info)

Brave 1.19.88 Chromium: 88.0.4324.96 (Official Build) (64-bit)
Revision 68dba2d8a0b149a1d3afac56fa74648032bcf46b-refs/branch-heads/4324@{#1784}
OS Windows 10 OS Version 2004 (Build 19041.746)

Version/Channel Information:

  • Can you reproduce this issue with the current release? No
  • Can you reproduce this issue with the beta channel? No
  • Can you reproduce this issue with the nightly channel? No

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields? NA
  • Does the issue resolve itself when disabling Brave Rewards? NA
  • Is the issue reproducible on the latest version of Chrome? NA

Miscellaneous Information:

cc: @brave/legacy_qa @tmancey @jsecretan @rebron

Issue is Reproduced by @btlechowski for poland region

@btlechowski
Copy link

btlechowski commented Jan 28, 2021

Reproduced on Linux

Brave 1.19.88 Chromium: 88.0.4324.96 (Official Build) (64-bit)
Revision 68dba2d8a0b149a1d3afac56fa74648032bcf46b-refs/branch-heads/4324@{#1784}
OS Ubuntu 18.04 LTS
NTP SI logs

Was not rewarded for NTP SI

[7494:7494:0128/151803.807719:INFO:creative_new_tab_page_ads_database_table.cc(426)] Failed to get creative new tab page ad
[7494:7494:0128/151803.808073:VERBOSE1:new_tab_page_ad.cc(77)] Failed to fire new tab page ad event for wallpaper id

Issue was fixed after browser restart

[14159:14159:0128/160959.141510:VERBOSE3:new_tab_page_ad_event_viewed.cc(26)] Viewed new tab page ad with uuid 76b82841-9786-4ed8-bfdc-ea0bddef1cdc and creative instance id ae0843a5-2859-45ed-be26-b91bd08420b4

Ad notification logs

Was unable to view ads

[7494:7494:0128/152037.687266:VERBOSE1:ad_notification_serving.cc(242)] No eligible ads found for untargeted category
[7494:7494:0128/152037.687338:VERBOSE1:ad_notification_serving.cc(243)] Ad notification not served: No eligible ads found

Issue was fixed after browser restart

[14159:14159:0128/161126.889501:VERBOSE1:ad_notification_serving.cc(98)] Ad notification delivered:
  uuid: 74e5e773-5f53-49a3-b135-ee32de5d2fa6
  creativeInstanceId: e5a7f7d5-b93d-443e-ab07-21fcf096bb83
  creativeSetId: dce1b0d8-cf10-410e-936f-96b2a0b84e00
  campaignId: 028af44e-dca7-4f50-97b0-31b2aa8d0bcc
  category: untargeted
  title: Nexo 12% Fiat Savings Account
  body: Enjoy up to 12% APY on your USD, EUR and GBP with Nexo.

@kjozwiak
Copy link
Member

Reproduced on macOS 11.1 x64 as well after upgrading from 1.19.86 CR: 88.0.4324.96 to 1.19.88 CR: 88.0.4324.96. Another quick work around is disabling/enabling again rather than restarting the browser. Reproduced using the following:

Brave | 1.19.88 Chromium: 88.0.4324.96 (Official Build) (x86_64)
--- | ---
Revision | 68dba2d8a0b149a1d3afac56fa74648032bcf46b-refs/branch-heads/4324@{#1784}
OS | macOS Version 11.1 (Build 20C69)

Provided @tmancey a full log via Slack as well.

@kjozwiak kjozwiak added priority/P2 A bad problem. We might uplift this to the next planned release. release/blocking labels Jan 28, 2021
@kjozwiak kjozwiak added this to the 1.19.x - Release #3 milestone Jan 28, 2021
@tmancey tmancey self-assigned this Jan 28, 2021
@tmancey tmancey added priority/P3 The next thing for us to work on. It'll ride the trains. and removed priority/P2 A bad problem. We might uplift this to the next planned release. labels Jan 28, 2021
@tmancey tmancey removed this from the 1.19.x - Release #3 milestone Jan 28, 2021
@srirambv
Copy link
Contributor

srirambv commented Feb 23, 2021

+1 on Linux. It does on the first launch for me but subsequent NTP SI's don't get rewarded.

@tmancey tmancey removed their assignment Mar 7, 2021
@tmancey
Copy link
Contributor

tmancey commented May 14, 2021

As a temporary workaround, users will be rewarded again for NTP SI once the catalog updates.

@tmancey tmancey removed QA/Test-Plan-Specified QA/Yes priority/P3 The next thing for us to work on. It'll ride the trains. labels May 14, 2021
@tmancey
Copy link
Contributor

tmancey commented Jul 30, 2021

This issue will occur if the database is migrated. We need to clear the following prefs after the database has successfully upgraded.

brave.brave_ads.catalog_id
brave.brave_ads.catalog_version
brave.brave_ads.catalog_ping
brave.brave_ads.catalog_last_updated

@btlechowski
Copy link

btlechowski commented May 2, 2022

Verification passed on

Brave 1.39.87 Chromium: 101.0.4951.41 (Official Build) beta (64-bit)
Revision 93c720db8323b3ec10d056025ab95c23a31997c9-refs/branch-heads/4951@{#904}
OS Ubuntu 18.04 LTS

Important: OS locale and actual geolocation need to be the same, for example: US locale and US based IP.
Important: Make sure unblinded tokens are fetched from the server before checking if user was paid for the ad

Brave - ads enabled, catalog downloaded before upgrade from 1.38.x

Verified catalog was downloaded after upgrade to 1.39.x

[4211:4211:0502/151214.490315:VERBOSE1:ad_server.cc(80)] OnGetCatalog
[4211:4211:0502/151214.490465:VERBOSE1:ad_server.cc(88)] Successfully fetched catalog
[4211:4211:0502/151214.490511:VERBOSE1:ad_server.cc(90)] Parsing catalog

Verified NTPSI was shown
image

Verified user was paid for the NTPSI

[4211:4211:0502/151248.540240:VERBOSE3:new_tab_page_ad_event_viewed.cc(23)] Viewed new tab page ad with placement id 6fd21432-4fa3-4d12-852f-fd3aa177419e and creative instance id 7b710122-1ec3-4073-8e6b-45b9f85f70bb
[4211:4211:0502/151248.559224:VERBOSE6:new_tab_page_ad_event_viewed.cc(31)] Successfully logged new tab page ad viewed event
[4211:4211:0502/151248.559560:VERBOSE3:new_tab_page_ad_event_served.cc(23)] Served new tab page ad with placement id 6fd21432-4fa3-4d12-852f-fd3aa177419e and creative instance id 7b710122-1ec3-4073-8e6b-45b9f85f70bb
[4211:4211:0502/151248.579238:VERBOSE3:ads_impl.cc(807)] Successfully processed deposit for new_tab_page_ad with creative instance id 7b710122-1ec3-4073-8e6b-45b9f85f70bb and view valued at 0.01
[4211:4211:0502/151248.579360:VERBOSE1:confirmations.cc(60)] Confirming view for new_tab_page_ad with transaction id 39cd7989-0c54-482e-af89-65755aa8ba90 and creative instance id 7b710122-1ec3-4073-8e6b-45b9f85f70bb
[4211:4211:0502/151325.981713:VERBOSE1:confirmations.cc(296)] Successfully redeemed unblinded token for new_tab_page_ad with confirmation id 4ab29ff8-1cf5-4423-93e2-3daad590fc8c, transaction id 39cd7989-0c54-482e-af89-65755aa8ba90, creative instance id 7b710122-1ec3-4073-8e6b-45b9f85f70bb and view.

Brave - ads enabled, catalog not downloaded before upgrade from 1.38.x

Made sure that catalog was not downloaded on 1.38.x by overriding the response code 200->500

[6881:6881:0502/164949.893966:VERBOSE1:ad_server.cc(81)] OnGetCatalog
[6881:6881:0502/164949.895121:VERBOSE1:ad_server.cc(111)] Failed to parse catalog

Verified catalog was downloaded after upgrade to 1.39.x

[8091:8091:0502/165937.207326:VERBOSE1:ad_server.cc(80)] OnGetCatalog
[8091:8091:0502/165937.207501:VERBOSE1:ad_server.cc(88)] Successfully fetched catalog
[8091:8091:0502/165937.207557:VERBOSE1:ad_server.cc(90)] Parsing catalog

Verified NTPSI was shown
image

Verified user was paid for the NTPSI

[8091:8091:0502/170309.887129:VERBOSE3:new_tab_page_ad_event_viewed.cc(23)] Viewed new tab page ad with placement id 4c249904-072b-445e-b2a4-69aaeb38ec06 and creative instance id 7b710122-1ec3-4073-8e6b-45b9f85f70bb
[8091:8091:0502/170309.915907:VERBOSE6:new_tab_page_ad_event_viewed.cc(31)] Successfully logged new tab page ad viewed event
[8091:8091:0502/170309.933982:VERBOSE3:new_tab_page_ad_event_served.cc(23)] Served new tab page ad with placement id 4c249904-072b-445e-b2a4-69aaeb38ec06 and creative instance id 7b710122-1ec3-4073-8e6b-45b9f85f70bb
[8091:8091:0502/170309.971324:VERBOSE3:ads_impl.cc(807)] Successfully processed deposit for new_tab_page_ad with creative instance id 7b710122-1ec3-4073-8e6b-45b9f85f70bb and view valued at 0.01
[8091:8091:0502/170309.971423:VERBOSE1:confirmations.cc(60)] Confirming view for new_tab_page_ad with transaction id e973381c-ca5e-42ac-addd-8cd4a6a7a09a and creative instance id 7b710122-1ec3-4073-8e6b-45b9f85f70bb
[8091:8091:0502/170325.164604:VERBOSE1:confirmations.cc(296)] Successfully redeemed unblinded token for new_tab_page_ad with confirmation id 522f44fc-2935-414f-baa7-cfa07edc4dcc, transaction id e973381c-ca5e-42ac-addd-8cd4a6a7a09a, creative instance id 7b710122-1ec3-4073-8e6b-45b9f85f70bb and view.

Brave - ads re-enabled, catalog downloaded before upgrade from 1.38.x

In 1.38.x:

[11420:11420:0502/194001.117588:VERBOSE1:ads_service_impl.cc(707)] Shutting down ads
[11420:11420:0502/194001.168011:VERBOSE1:ads_service_impl.cc(723)] Successfully shutdown ads

Verified user was paid for the NTPSI

[11956:11956:0502/194239.389147:VERBOSE3:new_tab_page_ad_event_viewed.cc(23)] Viewed new tab page ad with placement id 9d8297ce-8132-4739-a0ed-3947667f5af1 and creative instance id 7b710122-1ec3-4073-8e6b-45b9f85f70bb
[11956:11956:0502/194239.399412:VERBOSE6:new_tab_page_ad_event_viewed.cc(31)] Successfully logged new tab page ad viewed event
[11956:11956:0502/194239.408627:VERBOSE3:new_tab_page_ad_event_served.cc(23)] Served new tab page ad with placement id 9d8297ce-8132-4739-a0ed-3947667f5af1 and creative instance id 7b710122-1ec3-4073-8e6b-45b9f85f70bb
[11956:11956:0502/194239.475641:VERBOSE3:ads_impl.cc(807)] Successfully processed deposit for new_tab_page_ad with creative instance id 7b710122-1ec3-4073-8e6b-45b9f85f70bb and view valued at 0.01
[11956:11956:0502/194239.477515:VERBOSE1:confirmations.cc(60)] Confirming view for new_tab_page_ad with transaction id db8ebb59-906c-4708-bec8-c9c44ec0fa4e and creative instance id 7b710122-1ec3-4073-8e6b-45b9f85f70bb
[11956:11956:0502/194247.779814:VERBOSE1:confirmations.cc(296)] Successfully redeemed unblinded token for new_tab_page_ad with confirmation id 5e00717e-2b15-492a-8fd3-ec12fa0b912c, transaction id db8ebb59-906c-4708-bec8-c9c44ec0fa4e, creative instance id 7b710122-1ec3-4073-8e6b-45b9f85f70bb and view. 

Brave - ads re-enabled, catalog not downloaded before upgrade from 1.38.x

Made sure that catalog was not downloaded on 1.38.x by overriding the response code 200->500

[14457:14457:0502/200049.164356:VERBOSE1:ad_server.cc(81)] OnGetCatalog
[14457:14457:0502/200049.164482:VERBOSE1:ad_server.cc(111)] Failed to parse catalog

In 1.38.x:

[14457:14457:0502/200227.884380:VERBOSE1:ads_service_impl.cc(707)] Shutting down ads
[14457:14457:0502/200227.935675:VERBOSE1:ads_service_impl.cc(723)] Successfully shutdown ads

Verified user was paid for the NTPSI after upgrade

[15171:15171:0502/200517.321713:VERBOSE3:new_tab_page_ad_event_viewed.cc(23)] Viewed new tab page ad with placement id 24d02476-bbba-4d58-b746-14990954e635 and creative instance id 7b710122-1ec3-4073-8e6b-45b9f85f70bb
[15171:15171:0502/200517.328738:VERBOSE6:new_tab_page_ad_event_viewed.cc(31)] Successfully logged new tab page ad viewed event
[15171:15171:0502/200517.335097:VERBOSE3:new_tab_page_ad_event_served.cc(23)] Served new tab page ad with placement id 24d02476-bbba-4d58-b746-14990954e635 and creative instance id 7b710122-1ec3-4073-8e6b-45b9f85f70bb
[15171:15171:0502/200517.340677:VERBOSE3:ads_impl.cc(807)] Successfully processed deposit for new_tab_page_ad with creative instance id 7b710122-1ec3-4073-8e6b-45b9f85f70bb and view valued at 0.01
[15171:15171:0502/200517.340858:VERBOSE1:confirmations.cc(60)] Confirming view for new_tab_page_ad with transaction id 8fd0ceae-db14-488d-a019-2878329ed10b and creative instance id 7b710122-1ec3-4073-8e6b-45b9f85f70bb
[15171:15171:0502/200647.406561:VERBOSE1:confirmations.cc(296)] Successfully redeemed unblinded token for new_tab_page_ad with confirmation id 173b9591-c3b7-474f-881c-68d75c1ac458, transaction id 8fd0ceae-db14-488d-a019-2878329ed10b, creative instance id 7b710122-1ec3-4073-8e6b-45b9f85f70bb and view. 

Brave - ads enabled, catalog downloaded before upgrade from 1.19.86

Installed 1.19.86 and enabled rewards and ads
Because it is an old version, catalog failed to parse:

[9123:9123:0502/174732.953963:VERBOSE1:ad_server.cc(109)] Failed to parse catalog

Also the wallet failed to be created.

Verified catalog was downloaded after upgrade to 1.39.x

[9428:9428:0502/175033.440890:VERBOSE1:ad_server.cc(80)] OnGetCatalog
[9428:9428:0502/175033.441124:VERBOSE1:ad_server.cc(88)] Successfully fetched catalog
[9428:9428:0502/175033.441224:VERBOSE1:ad_server.cc(90)] Parsing catalog

I was unable to view ads due to unblinded tokens not being downloaded. Logged #22654

[9428:9428:0502/175033.529794:INFO:refill_unblinded_tokens.cc(88)] Failed to refill unblinded tokens due to an invalid wallet

@btlechowski
Copy link

Added QA/Test-All-Platforms back. When testing please use different locales than previous verifications.

@LaurenWags
Copy link
Member

LaurenWags commented May 4, 2022

Verified with

Brave | 1.39.89 Chromium: 101.0.4951.41 (Official Build) beta (x86_64)
-- | --
Revision | 93c720db8323b3ec10d056025ab95c23a31997c9-refs/branch-heads/4951@{#904}
OS | macOS Version 12.3.1 (Build 21E258)
Brave - ads enabled, catalog downloaded before upgrade from 1.38.x - PASSED

Verified catalog was downloaded after upgrade to 1.39.x

[1898:259:0504/082841.191289:VERBOSE1:ad_server.cc(80)] OnGetCatalog
[1898:259:0504/082841.192952:VERBOSE1:ad_server.cc(88)] Successfully fetched catalog
[1898:259:0504/082841.192975:VERBOSE1:ad_server.cc(90)] Parsing catalog

Verified NTPSI was shown:

1

Verified user was paid for the NTPSI

[1898:259:0504/084200.342354:VERBOSE3:new_tab_page_ad_event_viewed.cc(23)] Viewed new tab page ad with placement id df27db19-bfaa-4ec9-93e2-1a0eff060188 and creative instance id 50fbd528-a0c9-487e-b306-82029e67997f
.........
[1898:259:0504/084200.343953:VERBOSE6:new_tab_page_ad_event_viewed.cc(31)] Successfully logged new tab page ad viewed event
.............
[1898:259:0504/084200.368130:VERBOSE3:new_tab_page_ad_event_served.cc(23)] Served new tab page ad with placement id df27db19-bfaa-4ec9-93e2-1a0eff060188 and creative instance id 50fbd528-a0c9-487e-b306-82029e67997f
[1898:259:0504/084200.369639:VERBOSE3:ads_impl.cc(807)] Successfully processed deposit for new_tab_page_ad with creative instance id 50fbd528-a0c9-487e-b306-82029e67997f and view valued at 0.01
[1898:259:0504/084200.369691:VERBOSE1:confirmations.cc(60)] Confirming view for new_tab_page_ad with transaction id c8b79f0b-0c95-4e95-b567-8ed6cb699969 and creative instance id 50fbd528-a0c9-487e-b306-82029e67997f
.........
[1898:259:0504/084200.371593:VERBOSE6:new_tab_page_ad_event_served.cc(31)] Successfully logged new tab page ad served event
.........
[1898:259:0504/084221.572898:VERBOSE1:confirmations.cc(296)] Successfully redeemed unblinded token for new_tab_page_ad with confirmation id b3fba0b3-5dc9-4de6-99a7-05e1bae85917, transaction id c8b79f0b-0c95-4e95-b567-8ed6cb699969, creative instance id 50fbd528-a0c9-487e-b306-82029e67997f and view. You now have 1 unblinded payment tokens which will be redeemed on Friday, May 6, 2022 at 10:20:14 AM
Brave - ads enabled, catalog not downloaded before upgrade from 1.38.x - PASSED

Made sure that catalog was not downloaded on 1.38.x by overriding the response code 200->500

[2952:259:0504/091316.701704:VERBOSE1:ad_server.cc(81)] OnGetCatalog
[2952:259:0504/091316.701958:VERBOSE1:ad_server.cc(111)] Failed to parse catalog

Verified catalog was downloaded after upgrade to 1.39.x

[3170:259:0504/091517.852882:VERBOSE1:ad_server.cc(80)] OnGetCatalog
[3170:259:0504/091517.854126:VERBOSE1:ad_server.cc(88)] Successfully fetched catalog
[3170:259:0504/091517.854156:VERBOSE1:ad_server.cc(90)] Parsing catalog

Verified NTPSI was shown

2

Verified user was paid for the NTPSI

[3170:259:0504/091625.131956:VERBOSE3:new_tab_page_ad_event_viewed.cc(23)] Viewed new tab page ad with placement id 835a2696-d550-45f9-b624-1c339c116b9b and creative instance id 50fbd528-a0c9-487e-b306-82029e67997f
.........
[3170:259:0504/091625.134004:VERBOSE6:new_tab_page_ad_event_viewed.cc(31)] Successfully logged new tab page ad viewed event
.........
[3170:259:0504/091625.156030:VERBOSE3:new_tab_page_ad_event_served.cc(23)] Served new tab page ad with placement id 835a2696-d550-45f9-b624-1c339c116b9b and creative instance id 50fbd528-a0c9-487e-b306-82029e67997f
[3170:259:0504/091625.158021:VERBOSE3:ads_impl.cc(807)] Successfully processed deposit for new_tab_page_ad with creative instance id 50fbd528-a0c9-487e-b306-82029e67997f and view valued at 0.01
[3170:259:0504/091625.158094:VERBOSE1:confirmations.cc(60)] Confirming view for new_tab_page_ad with transaction id 93285d7a-370a-4040-bd22-a1bb749ffaa3 and creative instance id 50fbd528-a0c9-487e-b306-82029e67997f
..........
[3170:259:0504/091656.474766:VERBOSE1:confirmations.cc(296)] Successfully redeemed unblinded token for new_tab_page_ad with confirmation id ade2aa05-85c2-4d58-a919-bc8ad1cf0659, transaction id 93285d7a-370a-4040-bd22-a1bb749ffaa3, creative instance id 50fbd528-a0c9-487e-b306-82029e67997f and view. You now have 1 unblinded payment tokens which will be redeemed in 9 hours, 29 minutes, 15 seconds at 18:46:11.581
Brave - ads re-enabled, catalog downloaded before upgrade from 1.38.x - PASSED

In 1.38.x:

[4637:259:0504/102735.026282:VERBOSE1:ads_service_impl.cc(707)] Shutting down ads
[4637:259:0504/102735.027957:VERBOSE1:ads_service_impl.cc(723)] Successfully shutdown ads

Verified user was paid for the NTPSI

[4765:259:0504/102931.331045:VERBOSE3:new_tab_page_ad_event_viewed.cc(23)] Viewed new tab page ad with placement id fd5b3310-0ea0-4e61-b89b-f8a3973d2c0e and creative instance id 50fbd528-a0c9-487e-b306-82029e67997f
...........
[4765:259:0504/102931.333528:VERBOSE6:new_tab_page_ad_event_viewed.cc(31)] Successfully logged new tab page ad viewed event
..........
[4765:259:0504/102931.358295:VERBOSE3:new_tab_page_ad_event_served.cc(23)] Served new tab page ad with placement id fd5b3310-0ea0-4e61-b89b-f8a3973d2c0e and creative instance id 50fbd528-a0c9-487e-b306-82029e67997f
[4765:259:0504/102931.359773:VERBOSE3:ads_impl.cc(807)] Successfully processed deposit for new_tab_page_ad with creative instance id 50fbd528-a0c9-487e-b306-82029e67997f and view valued at 0.01
[4765:259:0504/102931.359861:VERBOSE1:confirmations.cc(60)] Confirming view for new_tab_page_ad with transaction id 7a73b3a6-0e51-47fa-ab1a-372ceb6491a0 and creative instance id 50fbd528-a0c9-487e-b306-82029e67997f
...........
[4765:259:0504/103009.654513:VERBOSE1:confirmations.cc(296)] Successfully redeemed unblinded token for new_tab_page_ad with confirmation id 1aaa16ce-9d75-41ed-9eca-37975dc86112, transaction id 7a73b3a6-0e51-47fa-ab1a-372ceb6491a0, creative instance id 50fbd528-a0c9-487e-b306-82029e67997f and view. You now have 1 unblinded payment tokens which will be redeemed on Friday, May 6, 2022 at 4:33:15 AM
Brave - ads re-enabled, catalog not downloaded before upgrade from 1.38.x - PASSED

Made sure that catalog was not downloaded on 1.38.x by overriding the response code 200->500

[5186:259:0504/104445.972657:VERBOSE1:ad_server.cc(81)] OnGetCatalog
[5186:259:0504/104445.972895:VERBOSE1:ad_server.cc(111)] Failed to parse catalog

In 1.38.x:

[5186:259:0504/104549.516886:VERBOSE1:ads_service_impl.cc(707)] Shutting down ads
[5186:259:0504/104549.518918:VERBOSE1:ads_service_impl.cc(723)] Successfully shutdown ads

Verified user was paid for the NTPSI after upgrade

[5377:259:0504/104734.771275:VERBOSE3:new_tab_page_ad_event_viewed.cc(23)] Viewed new tab page ad with placement id 018e47ac-932e-4cc0-8d45-550345bd64fe and creative instance id 50fbd528-a0c9-487e-b306-82029e67997f
..........
[5377:259:0504/104734.773208:VERBOSE6:new_tab_page_ad_event_viewed.cc(31)] Successfully logged new tab page ad viewed event
.......
[5377:259:0504/104734.797689:VERBOSE3:new_tab_page_ad_event_served.cc(23)] Served new tab page ad with placement id 018e47ac-932e-4cc0-8d45-550345bd64fe and creative instance id 50fbd528-a0c9-487e-b306-82029e67997f
[5377:259:0504/104734.800560:VERBOSE3:ads_impl.cc(807)] Successfully processed deposit for new_tab_page_ad with creative instance id 50fbd528-a0c9-487e-b306-82029e67997f and view valued at 0.01
[5377:259:0504/104734.800646:VERBOSE1:confirmations.cc(60)] Confirming view for new_tab_page_ad with transaction id c0921435-2788-4933-b961-f5fd8d051e63 and creative instance id 50fbd528-a0c9-487e-b306-82029e67997f
........
[5377:259:0504/104755.268534:VERBOSE1:confirmations.cc(296)] Successfully redeemed unblinded token for new_tab_page_ad with confirmation id 396bbf4f-4bcb-46c5-965b-bddc4faa9a99, transaction id c0921435-2788-4933-b961-f5fd8d051e63, creative instance id 50fbd528-a0c9-487e-b306-82029e67997f and view. You now have 1 unblinded payment tokens which will be redeemed in 7 hours, 37 minutes, 55 seconds at 18:25:50.723
Brave - ads enabled, catalog downloaded before upgrade from 1.19.86 - PASSED

Installed 1.19.86 and enabled rewards and ads
Because it is an old version, catalog failed to parse:

[5764:259:0504/110222.764004:VERBOSE1:ad_server.cc(109)] Failed to parse catalog

Also the wallet failed to be created.

Verified catalog was downloaded after upgrade to 1.39.x

[5956:259:0504/110424.521619:VERBOSE1:ad_server.cc(80)] OnGetCatalog
[5956:259:0504/110424.522517:VERBOSE1:ad_server.cc(88)] Successfully fetched catalog
[5956:259:0504/110424.522537:VERBOSE1:ad_server.cc(90)] Parsing catalog

Did not encounter #22654, my tokens were refilled:

[5956:259:0504/110429.630586:VERBOSE1:refill_unblinded_tokens.cc(322)] Added 50 unblinded tokens, you now have 50 unblinded tokens

Verified user was paid for the NTPSI after upgrade

[5956:259:0504/110620.189347:VERBOSE3:new_tab_page_ad_event_viewed.cc(23)] Viewed new tab page ad with placement id 7450e71c-adc7-4d08-9c2f-79cf1e10c30b and creative instance id 50fbd528-a0c9-487e-b306-82029e67997f
..........
[5956:259:0504/110620.192124:VERBOSE6:new_tab_page_ad_event_viewed.cc(31)] Successfully logged new tab page ad viewed event
.........
[5956:259:0504/110620.214614:VERBOSE3:new_tab_page_ad_event_served.cc(23)] Served new tab page ad with placement id 7450e71c-adc7-4d08-9c2f-79cf1e10c30b and creative instance id 50fbd528-a0c9-487e-b306-82029e67997f
[5956:259:0504/110620.216291:VERBOSE3:ads_impl.cc(807)] Successfully processed deposit for new_tab_page_ad with creative instance id 50fbd528-a0c9-487e-b306-82029e67997f and view valued at 0.01
[5956:259:0504/110620.216350:VERBOSE1:confirmations.cc(60)] Confirming view for new_tab_page_ad with transaction id 25d8cd7b-2088-47ef-af6d-5ac7e856b59f and creative instance id 50fbd528-a0c9-487e-b306-82029e67997f
.........
[5956:259:0504/110631.771016:VERBOSE1:confirmations.cc(296)] Successfully redeemed unblinded token for new_tab_page_ad with confirmation id 081e4eaf-1b72-4e9e-b133-08b7d66d006f, transaction id 25d8cd7b-2088-47ef-af6d-5ac7e856b59f, creative instance id 50fbd528-a0c9-487e-b306-82029e67997f and view. You now have 1 unblinded payment tokens which will be redeemed on Friday, May 6, 2022 at 4:05:30 AM

@MadhaviSeelam
Copy link

MadhaviSeelam commented May 12, 2022

Verified Passed using

Brave | 1.39.101 Chromium: 101.0.4951.64 (Official Build) beta (64-bit)
-- | --
Revision | d1daa9897e1bc1d507d6be8f2346e377e5505905-refs/branch-heads/4951@{#1208}
OS | Windows 11 Version 21H2 (Build 22000.613)
Brave - ads enabled, catalog downloaded before upgrade from 1.38.x - PASSED

Verified catalog was downloaded after upgrade to 1.39.x

[6976:4344:0512/081333.886:VERBOSE1:ad_server.cc(80)] OnGetCatalog
[6976:4344:0512/081333.887:VERBOSE1:ad_server.cc(88)] Successfully fetched catalog
[6976:4344:0512/081333.887:VERBOSE1:ad_server.cc(90)] Parsing catalog

Verified NTPSI was shown

ntpsi

Verified user was paid for the NTPSI

[21752:10376:0512/100830.059:VERBOSE3:new_tab_page_ad_event_viewed.cc(23)] Viewed new tab page ad with placement id 47c415eb-5c95-40a5-aa70-5f369281cf2a and creative instance id e31b56de-023b-489f-89e0-afdbfd2e41e9
.........
[21752:10376:0512/100830.073:VERBOSE6:new_tab_page_ad_event_viewed.cc(31)] Successfully logged new tab page ad viewed event
.........
[21752:10376:0512/100830.079:VERBOSE3:new_tab_page_ad_event_served.cc(23)] Served new tab page ad with placement id 47c415eb-5c95-40a5-aa70-5f369281cf2a and creative instance id e31b56de-023b-489f-89e0-afdbfd2e41e9
[21752:10376:0512/100830.082:VERBOSE3:ads_impl.cc(807)] Successfully processed deposit for new_tab_page_ad with creative instance id e31b56de-023b-489f-89e0-afdbfd2e41e9 and view valued at 0.01
[21752:10376:0512/100830.082:VERBOSE1:confirmations.cc(60)] Confirming view for new_tab_page_ad with transaction id 63b92053-2519-4a54-9174-8ddcfed0768c and creative instance id e31b56de-023b-489f-89e0-afdbfd2e41e9
.........
[21752:10376:0512/100830.085:VERBOSE6:new_tab_page_ad_event_served.cc(31)] Successfully logged new tab page ad served event
.........
[21752:10376:0512/100830.082:VERBOSE1:confirmations.cc(60)] Confirming view for new_tab_page_ad with transaction id 63b92053-2519-4a54-9174-8ddcfed0768c and creative instance id e31b56de-023b-489f-89e0-afdbfd2e41e9
Brave - ads enabled, catalog not downloaded before upgrade from 1.38.x - PASSED

Made sure that catalog was not downloaded on 1.38.x by overriding the response code 200->500

[23400:26184:0512/130436.789:VERBOSE1:ad_server.cc(81)] OnGetCatalog
[23400:26184:0512/130436.789:VERBOSE1:ad_server.cc(111)] Failed to parse catalog

Verified catalog was downloaded after upgrade to 1.39.x

[16132:26880:0512/144719.869:VERBOSE1:ad_server.cc(80)] OnGetCatalog
[16132:26880:0512/144719.869:VERBOSE1:ad_server.cc(88)] Successfully fetched catalog
[16132:26880:0512/144719.870:VERBOSE1:ad_server.cc(90)] Parsing catalog

Verified NTPSI was shown
ntpsi2

Verified user was paid for the NTPSI

[16132:26880:0512/144934.403:VERBOSE3:new_tab_page_ad_event_viewed.cc(23)] Viewed new tab page ad with placement id c0e996a4-65b9-4da3-9620-39874be403f6 and creative instance id e31b56de-023b-489f-89e0-afdbfd2e41e9
..........
[16132:26880:0512/144934.407:VERBOSE6:new_tab_page_ad_event_viewed.cc(31)] Successfully logged new tab page ad viewed event
..........
[16132:26880:0512/144934.413:VERBOSE3:new_tab_page_ad_event_served.cc(23)] Served new tab page ad with placement id c0e996a4-65b9-4da3-9620-39874be403f6 and creative instance id e31b56de-023b-489f-89e0-afdbfd2e41e9
[16132:26880:0512/144934.416:VERBOSE3:ads_impl.cc(807)] Successfully processed deposit for new_tab_page_ad with creative instance id e31b56de-023b-489f-89e0-afdbfd2e41e9 and view valued at 0.01
[16132:26880:0512/144934.416:VERBOSE1:confirmations.cc(60)] Confirming view for new_tab_page_ad with transaction id f4f80596-bcf5-4ccc-9549-c5c3b1307439 and creative instance id e31b56de-023b-489f-89e0-afdbfd2e41e9
..........
[16132:26880:0512/144940.807:VERBOSE1:confirmations.cc(296)] Successfully redeemed unblinded token for new_tab_page_ad with confirmation id 6e6aafae-572a-4f37-a762-b0efe6d9a9c2, transaction id f4f80596-bcf5-4ccc-9549-c5c3b1307439, creative instance id e31b56de-023b-489f-89e0-afdbfd2e41e9 and view. You now have 1 unblinded payment tokens which will be redeemed in 8 hours, 12 minutes, 25 seconds at 23:02:05.737
Brave - ads re-enabled, catalog downloaded before upgrade from 1.38.x - PASSED

in 1.38.x:

[8252:15612:0512/110043.323:VERBOSE1:ads_service_impl.cc(707)] Shutting down ads
[8252:15612:0512/110043.327:VERBOSE1:ads_service_impl.cc(723)] Successfully shutdown ads

Verified user was paid for the NTPSI

[23196:9540:0512/110431.597:VERBOSE3:new_tab_page_ad_event_viewed.cc(23)] Viewed new tab page ad with placement id 6af20545-bddb-4100-829d-290981ca6626 and creative instance id e31b56de-023b-489f-89e0-afdbfd2e41e9
........
[23196:9540:0512/110431.611:VERBOSE6:new_tab_page_ad_event_viewed.cc(31)] Successfully logged new tab page ad viewed event
........
[23196:9540:0512/110431.618:VERBOSE3:new_tab_page_ad_event_served.cc(23)] Served new tab page ad with placement id 6af20545-bddb-4100-829d-290981ca6626 and creative instance id e31b56de-023b-489f-89e0-afdbfd2e41e9
[23196:9540:0512/110431.622:VERBOSE3:ads_impl.cc(807)] Successfully processed deposit for new_tab_page_ad with creative instance id e31b56de-023b-489f-89e0-afdbfd2e41e9 and view valued at 0.01
[23196:9540:0512/110431.622:VERBOSE1:confirmations.cc(60)] Confirming view for new_tab_page_ad with transaction id f98ab886-061c-4ec6-ba49-d141c68abf95 and creative instance id e31b56de-023b-489f-89e0-afdbfd2e41e9
........
[23196:9540:0512/110434.183:VERBOSE1:confirmations.cc(296)] Successfully redeemed unblinded token for new_tab_page_ad with confirmation id db782ba8-3931-4af4-83c9-567ffb87bd9e, transaction id f98ab886-061c-4ec6-ba49-d141c68abf95, creative instance id e31b56de-023b-489f-89e0-afdbfd2e41e9 and view. You now have 2 unblinded payment tokens which will be redeemed in 0 hours, 0 minutes, 0 seconds at 11:04:25.855
Brave - ads re-enabled, catalog not downloaded before upgrade from 1.38.x - PASSED

Made sure that catalog was not downloaded on 1.38.x by overriding the response code 200->500

[24444:23464:0512/142848.581:VERBOSE1:ad_server.cc(81)] OnGetCatalog
[24444:23464:0512/142848.582:VERBOSE1:ad_server.cc(111)] Failed to parse catalog

In 1.38.x

[19380:14608:0512/153110.141:VERBOSE1:ads_service_impl.cc(706)] Shutting down ads
[19380:14608:0512/153110.142:VERBOSE1:ads_service_impl.cc(722)] Successfully shutdown ads

Verified user was paid for the NTPSI after upgrade

[17192:15544:0512/153721.231:VERBOSE3:new_tab_page_ad_event_viewed.cc(23)] Viewed new tab page ad with placement id 775dbdb7-7dcd-4b94-b566-e40beb762164 and creative instance id 5898b093-a173-4530-93aa-a2a3e9523217
........
[17192:15544:0512/153721.236:VERBOSE6:new_tab_page_ad_event_viewed.cc(31)] Successfully logged new tab page ad viewed event
........
[17192:15544:0512/153721.244:VERBOSE3:new_tab_page_ad_event_served.cc(23)] Served new tab page ad with placement id 775dbdb7-7dcd-4b94-b566-e40beb762164 and creative instance id 5898b093-a173-4530-93aa-a2a3e9523217
[17192:15544:0512/153721.248:VERBOSE3:ads_impl.cc(807)] Successfully processed deposit for new_tab_page_ad with creative instance id 5898b093-a173-4530-93aa-a2a3e9523217 and view valued at 0.01
[17192:15544:0512/153721.248:VERBOSE1:confirmations.cc(60)] Confirming view for new_tab_page_ad with transaction id 8bd2561c-59b9-4087-b5fe-46176f20dd88 and creative instance id 5898b093-a173-4530-93aa-a2a3e9523217
........
[17192:15544:0512/153747.257:VERBOSE1:confirmations.cc(296)] Successfully redeemed unblinded token for new_tab_page_ad with confirmation id fefe469f-8b82-4f3f-be39-46d9aab7796c, transaction id 8bd2561c-59b9-4087-b5fe-46176f20dd88, creative instance id 5898b093-a173-4530-93aa-a2a3e9523217 and view. You now have 1 unblinded payment tokens which will be redeemed in 0 hours, 0 minutes, 0 seconds at 15:35:57.159
Brave - ads enabled, catalog downloaded before upgrade from 1.19.86 - PASSED

Installed 1.19.86 and enabled rewards and ads
Because it is an old version, catalog failed to parse:

[22388:24136:0513/120526.052:VERBOSE1:ad_server.cc(109)] Failed to parse catalog

Also the wallet failed to be created.

[22388:24136:0513/120524.612:VERBOSE1:wallet_balance.cc(41)] Wallet is not created

Verified catalog was downloaded after upgrade to 1.39.x

[12472:20172:0513/122741.509:VERBOSE1:ad_server.cc(80)] OnGetCatalog
[12472:20172:0513/122741.509:VERBOSE1:ad_server.cc(88)] Successfully fetched catalog
[12472:20172:0513/122741.509:VERBOSE1:ad_server.cc(90)] Parsing catalog

Did not encounter #22654, my tokens were refilled:

[12472:20172:0513/122755.100:VERBOSE1:refill_unblinded_tokens.cc(322)] Added 50 unblinded tokens, you now have 50 unblinded tokens

Verified user was paid for the NTPSI after upgrade

[12472:20172:0513/123039.618:VERBOSE3:new_tab_page_ad_event_viewed.cc(23)] Viewed new tab page ad with placement id b3ba1511-afbc-4716-b11d-f6742513a531 and creative instance id 680a6fb2-b67f-4256-87ab-bb212794b345
.......
[12472:20172:0513/123039.621:VERBOSE6:new_tab_page_ad_event_viewed.cc(31)] Successfully logged new tab page ad viewed event
.......
[12472:20172:0513/123039.631:VERBOSE3:new_tab_page_ad_event_served.cc(23)] Served new tab page ad with placement id b3ba1511-afbc-4716-b11d-f6742513a531 and creative instance id 680a6fb2-b67f-4256-87ab-bb212794b345
[12472:20172:0513/123039.634:VERBOSE3:ads_impl.cc(807)] Successfully processed deposit for new_tab_page_ad with creative instance id 680a6fb2-b67f-4256-87ab-bb212794b345 and view valued at 0.01
[12472:20172:0513/123039.634:VERBOSE1:confirmations.cc(60)] Confirming view for new_tab_page_ad with transaction id a5fc812b-f15c-40b2-94e1-111fb6ccc818 and creative instance id 680a6fb2-b67f-4256-87ab-bb2127
.......
[12472:20172:0513/123055.967:VERBOSE1:confirmations.cc(296)] Successfully redeemed unblinded token for new_tab_page_ad with confirmation id 601e32ae-d809-4df8-895c-9ef49ca781ce, transaction id a5fc812b-f15c-4

@tmancey tmancey added this to Ads Jun 10, 2024
@tmancey tmancey moved this to Done in Ads Jun 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment