-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Users are not rewarded for viewing an NTP SI until the browser is restarted #13815
Comments
Reproduced on Linux
NTP SI logsWas not rewarded for NTP SI
Issue was fixed after browser restart
Ad notification logsWas unable to view ads
Issue was fixed after browser restart
|
Reproduced on
Provided @tmancey a full log via Slack as well. |
+1 on Linux. It does on the first launch for me but subsequent NTP SI's don't get rewarded. |
As a temporary workaround, users will be rewarded again for NTP SI once the catalog updates. |
This issue will occur if the database is migrated. We need to clear the following prefs after the database has successfully upgraded.
|
Verification passed on
Important: OS locale and actual geolocation need to be the same, for example: US locale and US based IP. Brave - ads enabled, catalog downloaded before upgrade from 1.38.xVerified catalog was downloaded after upgrade to 1.39.x
Verified user was paid for the NTPSI
Brave - ads enabled, catalog not downloaded before upgrade from 1.38.xMade sure that catalog was not downloaded on 1.38.x by overriding the response code 200->500
Verified catalog was downloaded after upgrade to 1.39.x
Verified user was paid for the NTPSI
Brave - ads re-enabled, catalog downloaded before upgrade from 1.38.xIn 1.38.x:
Verified user was paid for the NTPSI
Brave - ads re-enabled, catalog not downloaded before upgrade from 1.38.xMade sure that catalog was not downloaded on 1.38.x by overriding the response code 200->500
In 1.38.x:
Verified user was paid for the NTPSI after upgrade
Brave - ads enabled, catalog downloaded before upgrade from 1.19.86Installed 1.19.86 and enabled rewards and ads
Also the wallet failed to be created. Verified catalog was downloaded after upgrade to 1.39.x
I was unable to view ads due to unblinded tokens not being downloaded. Logged #22654
|
Added |
Verified with
Brave - ads enabled, catalog downloaded before upgrade from 1.38.x - PASSEDVerified catalog was downloaded after upgrade to 1.39.x
Verified NTPSI was shown: Verified user was paid for the NTPSI
Brave - ads enabled, catalog not downloaded before upgrade from 1.38.x - PASSEDMade sure that catalog was not downloaded on 1.38.x by overriding the response code 200->500
Verified catalog was downloaded after upgrade to 1.39.x
Verified NTPSI was shown Verified user was paid for the NTPSI
Brave - ads re-enabled, catalog downloaded before upgrade from 1.38.x - PASSEDIn 1.38.x:
Verified user was paid for the NTPSI
Brave - ads re-enabled, catalog not downloaded before upgrade from 1.38.x - PASSEDMade sure that catalog was not downloaded on 1.38.x by overriding the response code 200->500
In 1.38.x:
Verified user was paid for the NTPSI after upgrade
Brave - ads enabled, catalog downloaded before upgrade from 1.19.86 - PASSEDInstalled 1.19.86 and enabled rewards and ads
Also the wallet failed to be created. Verified catalog was downloaded after upgrade to 1.39.x
Did not encounter #22654, my tokens were refilled:
Verified user was paid for the NTPSI after upgrade
|
Verified
Brave - ads enabled, catalog downloaded before upgrade from 1.38.x - PASSEDVerified catalog was downloaded after upgrade to 1.39.x
Verified NTPSI was shown Verified user was paid for the NTPSI
Brave - ads enabled, catalog not downloaded before upgrade from 1.38.x - PASSEDMade sure that catalog was not downloaded on 1.38.x by overriding the response code 200->500
Verified catalog was downloaded after upgrade to 1.39.x
Verified user was paid for the NTPSI
Brave - ads re-enabled, catalog downloaded before upgrade from 1.38.x - PASSEDin 1.38.x:
Verified user was paid for the NTPSI
Brave - ads re-enabled, catalog not downloaded before upgrade from 1.38.x - PASSEDMade sure that catalog was not downloaded on 1.38.x by overriding the response code 200->500
In 1.38.x
Verified user was paid for the NTPSI after upgrade
Brave - ads enabled, catalog downloaded before upgrade from 1.19.86 - PASSEDInstalled 1.19.86 and enabled rewards and ads
Also the wallet failed to be created.
Verified catalog was downloaded after upgrade to 1.39.x
Did not encounter #22654, my tokens were refilled:
Verified user was paid for the NTPSI after upgrade
|
Description
Users are not rewarded for viewing an NTP SI until the browser is restarted.
Steps to Reproduce
Scenario 1:
1.19.86
1.19.88
Scenario 2:
1.19.86
1.19.88
and enable AdsNote: Restart browser fixes the issue only for US locale not for India
Actual result:
Users are not rewarded for viewing an NTP SI until the browser is restarted
Expected result:
Users should be rewarded for viewing an NTP SI without a browser restart
Reproduces how often:
Easy
Brave version (brave://version info)
Version/Channel Information:
Other Additional Information:
Miscellaneous Information:
cc: @brave/legacy_qa @tmancey @jsecretan @rebron
Issue is Reproduced by @btlechowski for poland region
The text was updated successfully, but these errors were encountered: