Users are not rewarded for viewing an NTP SI until the browser is restarted #12766
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tmancey
force-pushed
the
issues/13815
branch
7 times, most recently
from
8b4fdb5 to
eb1a297
Compare
tmancey
commented
Mar 25, 2022
| @@ -43,6 +44,10 @@ void Migration::FromVersion(const int from_version, ResultCallback callback) { | |||
| return; | |||
| } | |||
|
|
|||
| // TODO(https://github.com/brave/brave-browser/issues/14728): Decouple catalog | |||
| // business logic once we have implemented database observers | |||
| ResetCatalog(); | |||
There was a problem hiding this comment.
Database migration deletes the catalog database tables, therefore we need to reset the catalog to force a new catalog to be fetched after upgrade
tmancey
commented
Mar 25, 2022
| .WillByDefault( | ||
| Invoke([](const std::string& path) { g_prefs.erase(path); })); | ||
| .WillByDefault(Invoke([](const std::string& path) { | ||
| const std::string pref_path = GetUuidForCurrentTest(path); |
There was a problem hiding this comment.
Fixes a bug where mocks did not clear the pref due to using the wrong path
brave-builds
force-pushed
the
issues/13815
branch
from
ee63de1 to
cdb1a32
Compare
aseren
approved these changes
Mar 28, 2022
tmancey
force-pushed
the
issues/13815
branch
4 times, most recently
from
43d5fab to
f6322b9
Compare
kylehickinson
requested changes
Mar 28, 2022
Brandon-T
approved these changes
Mar 28, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves brave/brave-browser#13815
Submitter Checklist:
QA/YesorQA/No;release-notes/includeorrelease-notes/exclude;OS/...) to the associated issuenpm run test -- brave_browser_tests,npm run test -- brave_unit_tests,npm run lint,npm run gn_check,npm run tslintgit rebase master(if needed)Reviewer Checklist:
gnAfter-merge Checklist:
changes has landed on
Test Plan:
Catalog should download after upgrading from 1.34.x to this version