Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sometimes the rewards tour is initialized twice #13945

Closed
btlechowski opened this issue Feb 3, 2021 · 3 comments
Closed

Sometimes the rewards tour is initialized twice #13945

btlechowski opened this issue Feb 3, 2021 · 3 comments
Labels
closed/stale Issue is no longer relevant, perhaps because the feature it refers to has been deprecated. feature/rewards OS/Desktop QA/Test-Plan-Specified QA/Yes

Comments

@btlechowski
Copy link

This happens after user takes the tour through Take a quick tour and after the tour clicks Start using Brave Rewards

Note: the second tour can be skipped

Steps to Reproduce

  1. Clean profile
  2. Open Rewards Panel
  3. Click Take a quick tour
  4. Go through the tour
  5. Click Start using Brave Rewards

Actual result:

The tour is initiated again
rewards tour

Expected result:

The tour is not initiated again

Reproduces how often:

100% repro rate

Brave version (brave://version info)

Brave 1.20.97 Chromium: 88.0.4324.96 (Official Build) dev (64-bit)
Revision 68dba2d8a0b149a1d3afac56fa74648032bcf46b-refs/branch-heads/4324@{#1784}
OS Ubuntu 18.04 LTS

cc @zenparsing @rebron @brave/legacy_qa

@LaurenWags
Copy link
Member

cc @codybanxs

@ghost
Copy link

ghost commented Feb 18, 2021

I will create a new issue but in this case if a user goes through 'take a tour' and immediately goes through the 'Start using Brave Rewards' we should only show the last two slides that setup a users Rewards preferences for the second time.

@zenparsing
Copy link

Thanks @codybanxs ! No need to create a new issue, we can just use this one to track.

@Miyayes Miyayes closed this as not planned Won't fix, can't repro, duplicate, stale Sep 7, 2022
@Miyayes Miyayes added the closed/stale Issue is no longer relevant, perhaps because the feature it refers to has been deprecated. label Sep 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
closed/stale Issue is no longer relevant, perhaps because the feature it refers to has been deprecated. feature/rewards OS/Desktop QA/Test-Plan-Specified QA/Yes
Projects
None yet
Development

No branches or pull requests

4 participants