Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Configure Brave Ads next payment date from variations seed #14067

Closed
tmancey opened this issue Feb 9, 2021 · 4 comments · Fixed by brave/brave-core#7894
Closed

Configure Brave Ads next payment date from variations seed #14067

tmancey opened this issue Feb 9, 2021 · 4 comments · Fixed by brave/brave-core#7894
Assignees

Comments

@tmancey
Copy link
Contributor

tmancey commented Feb 9, 2021

No description provided.

@tmancey tmancey added enhancement priority/P3 The next thing for us to work on. It'll ride the trains. QA/Yes release-notes/exclude feature/ads OS/Android Fixes related to Android browser functionality OS/Desktop labels Feb 9, 2021
@tmancey tmancey self-assigned this Feb 9, 2021
@tmancey tmancey added this to the 1.22.x - Nightly milestone Feb 10, 2021
@btlechowski btlechowski added QA/In-Progress Indicates that QA is currently in progress for that particular issue QA/Blocked labels Mar 3, 2021
@btlechowski
Copy link

QA/Blocked as the issue has no test plan.

@kjozwiak
Copy link
Member

At this time we just need to make sure the next payment date matches previously releases, i.e. 5th or 6th depending on timezone. We will test the seed when we need to make a change.

@tmancey added the above case via brave/brave-core#7894. For now, we just need to make sure that the payment date matches the previous release after upgrading.

@srirambv
Copy link
Contributor

Verification passed on One Plus 6T with Android 10 running 1.22.58 x64 beta build


Verification passed on Samsung Tab A with Android 10 running 1.22.58 x64 beta build

@btlechowski
Copy link

Verification passed on

Brave 1.22.58 Chromium: 89.0.4389.86 (Official Build) beta (64-bit)
Revision 0c2dac31bc21e806a791641316e99920f84ea52c-refs/branch-heads/4389@{#1472}
OS Ubuntu 18.04 LTS

Verified next payment date matches previous release
Verified test plan from https://github.com/brave/internal/issues/759
Verified the date was changed to 2nd:
image

@LaurenWags LaurenWags removed the QA/In-Progress Indicates that QA is currently in progress for that particular issue label Sep 28, 2022
@tmancey tmancey added this to Ads Jun 10, 2024
@tmancey tmancey moved this to Done in Ads Jun 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

5 participants