Configure Brave Ads next payment date from variations seed #7894
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
moritzhaller
reviewed
Feb 9, 2021
|
|
||
| const base::Feature kAdRewards{kFeatureName, base::FEATURE_ENABLED_BY_DEFAULT}; | ||
|
|
||
| bool IskAdRewardsEnabled() { |
There was a problem hiding this comment.
typo, should be IsAdRewardsEnabled ?
moritzhaller
reviewed
Feb 9, 2021
| return base::FeatureList::IsEnabled(kkAdRewards); | ||
| } | ||
|
|
||
| int GetkAdRewardsNextPaymentDay() { |
There was a problem hiding this comment.
typo, should be GetAdRewardsNextPaymentDay?
tmancey
force-pushed
the
issues/14067
branch
4 times, most recently
from
b332b7a
to
8b6aec4
Compare
tmancey
force-pushed
the
issues/14067
branch
from
8b6aec4
to
41c2e2f
Compare
|
CI failed due to BraveShieldsAPIBrowserTest.AllowScriptsOnceIframe (../../brave/browser/extensions/api/brave_shields_api_browsertest.cc:185) which is a known issue |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves brave/brave-browser#14067
Submitter Checklist:
QA/YesorQA/No;release-notes/includeorrelease-notes/exclude;OS/...) to the associated issuenpm run test -- brave_browser_tests,npm run test -- brave_unit_tests,npm run lint,npm run gn_check,npm run tslintgit rebase master(if needed)Reviewer Checklist:
gnAfter-merge Checklist:
changes has landed on
Test Plan:
At this time we just need to make sure the next payment date matches previously releases, i.e. 5th or 6th depending on timezone. We will test the seed when we need to make a change.