-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Maybe tone down "NOT A RECOMMENDED BRAVE EXTENSION!" #1408
Comments
WHAT'S WRONG WITH SHOUTING?? |
Text edit only. |
cc: @bbondy |
I can take this one whilst we're only changing the title and not modifying the content yet (for 0.55). We should open another issue for a cleaner dialog which adds in the text we want to the content area @rebron |
Verification Passed on
Verification Passed on
Verified passed with
|
The wording is a bit hard, and comes across as hinting suspicion of maliciousness. @davidtemkin suggested the following, which I think more accurately communicates our intended message:
|
Thanks @jonathansampson -- let's get feedback from @rebron @bradleyrichter |
also please get approval from @tomlowenthal we did originally intend for the wording to make users think twice before installing. extensions are one of the biggest security risks to browsers IMO and many of them are indeed malicious. see https://www.wired.com/story/chrome-extension-malware/ for instance personally i am suspicious of almost all extensions in the chrome web store |
I agree. What about
|
AGAIN chrome HAS reviewed the extension before it went into the store, so no meed for the ridiculous message in brave. |
@2635599 So what are they looking for in their review if Chrome Extensions keep ending up with malware? I'm not saying I agree that the message needs to be there at all (people mostly ignore messages), but if it's going to be there, it should be more unbiased. |
@MisinformedDNA and in the real world peeps see a message in all caps they figure the manufacture did something wrong. since the extension HAS been vetted alreday by google there is no need for the warning / message in brave. if there must be any kind of warning something like this WITHOUT the extensions name being added to it right across the top of the extensions page. "Installing 3rd Party Extensions In Brave May Damage The Browser." |
i think everyone here agrees there's no need for all-caps. maybe "Brave has not reviewed this extension for security and safety. Only install extensions you trust." |
We should consider re-opening, and working on the messaging a bit more (per the comments above). I think @diracdeltas and @davidtemkin both had excellent suggestions for alternative wording that isn't as abrasive out of the gate. |
@karenkliu i like it! only change i would suggest is change "trust it" to "trust the developer" |
@jonathansampson since this issue was closed with a PR and did its purpose, please open a new issue for this. It makes it hard for tracking across milestones and we lose what landed in which milestone by re-using issues. |
Thanks @jonathansampson ! |
New issue is here #3231 |
Description
When I try to add the "Cisco Webex Extension" (and other extensions), I get a message screaming "NOT A RECOMMENDED BRAVE EXTENSION! Add "Cisco Webex Extension"? This makes me think that I'm doing something wrong/dangerous/damaging. Furthermore, I couldn't find anything about recommended extensions anywhere in the documentation, community or GitHub.
We should improve the warning message to not drive fear into the heart of the users. Maybe something like '"Cisco Webex Extension" has not been verified by Brave'?
And then if we could either add a link or open a tab to explain what "verified" or "recommended" actually means, I think that would help.
Steps to Reproduce
Actual result:
Get install message with a shouting warning

Expected result:
Get install message
Reproduces how often:
Easily reproduced
Brave version (chrome://version info)
Brave | 0.55.10 Chromium: 70.0.3538.22 (Official Build) beta (64-bit)
Revision | ac9418ba9c3bd7f6baaffa0b055dfe147e0f8364-refs/branch-heads/3538@{#468}
OS | Windows
The text was updated successfully, but these errors were encountered: