Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closing last tab should open a new tab (not exit browser) #1002

Closed
bsclifton opened this issue Sep 7, 2018 · 23 comments · Fixed by brave/brave-core#14092
Closed

Closing last tab should open a new tab (not exit browser) #1002

bsclifton opened this issue Sep 7, 2018 · 23 comments · Fixed by brave/brave-core#14092

Comments

@bsclifton
Copy link
Member

Carried over from brave/browser-laptop#5873

Description

If there is only one window and you close all the tabs, Brave will exit on Linux and Windows. Instead of exiting, it should open a new tab

On macOS, when the last tab is closed the browser is left open with no windows. This proposal would also open a new tab

@bsclifton bsclifton added this to the Triage Backlog milestone Sep 7, 2018
@bsclifton bsclifton modified the milestones: Triage Backlog, 2.x Backlog Sep 7, 2018
@nCrazed
Copy link

nCrazed commented Sep 7, 2018

This sounds like how one of the chrome extensions used to work. The problem was that it would sometimes not open the new tab fast enough so the window would die anyway.

@franco27
Copy link

I close the last tab and Brave closes.
Closing a last open tab should not cause the browser to close.

@bbondy bbondy modified the milestones: 2.x Backlog, 1.x Backlog Sep 30, 2018
@lostpebble
Copy link

Yes please. For some reason I do this often, and coming from Chrome where it simply gave me a dashboard with recently opened tabs, this is surprising behavior.

I guess sometimes you just want a clean slate to start with again. Maybe its a lil OCD, but would be nice to have the option at least.

@srirambv srirambv mentioned this issue Oct 17, 2018
@notDavid
Copy link

Fyi, the Firefox equivalent of this is setting browser.tabs.closeWindowWithLastTab to false :

This preference controls whether closing the last tab, closes the window.

True: Close window when closing last tab (default)
False: Do not close the window when closing last tab (pre Firefox 3.5 behavior)

Note: Changing to False prevents Firefox from closing the window when you close the last tab such as with Ctrl+W, and subsequently from closing Firefox itself when closing the last tab of the last Firefox window.

@MadhaviSeelam
Copy link

MadhaviSeelam commented Jul 29, 2022

Verification Passed using

Brave 1.43.53 Chromium: 104.0.5112.69 (Official Build) beta (64-bit)
Revision 7ce2902023c722af8564068e6b26e934b83fd774-refs/branch-heads/5112@{#1213}
OS Windows 11 Version 21H2 (Build 22000.795)

Steps:

  • Install 1.43.53
  • launch Brave
  • open multiple tabs
  • open brave://settings/system
  • toggle OFF Close window when closing last tab
  • close all the tabs except last one
  • confirmed when last tab is closed, a new tab opened
  • when the browser window is closed, close all tabs warning message is displayed as it's the existing functionality
  • toggle ON Close window when closing last tab
  • closing all tabs, closes the browser
2022-07-29_15h53_13.mp4

Verification passed on

Brave 1.43.78 Chromium: 104.0.5112.102 (Official Build) beta (64-bit)
Revision 8e5396254975ef939f2ef7d0bd334e48a052b536-refs/branch-heads/5112@{#1478}
OS Ubuntu 18.04 LTS

Verified able to turn of Close window when closing last tab
image

Verified when closing last tab a new tab is created
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.