Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement keyboard shortcut for private tab and private tab with Tor #446

Closed
srirambv opened this issue Jun 28, 2018 · 2 comments
Closed
Labels
design A design change, especially one which needs input from the design team feature/keyboard-shortcuts QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Yes

Comments

@srirambv
Copy link
Contributor

Description

Implement keyboard shortcut for private tab and private tab with Tor

Expected result:

mac
Cmd+Shift+P for Private tab using Tor
Cmd+Shift+N for Private tab not using Tor

Windows/Linux
Ctrl+Shift+P for Private tab using Tor
Ctrl+Shift+N for Private tab not using Tor

@srirambv srirambv added design A design change, especially one which needs input from the design team feature/keyboard-shortcuts labels Jun 28, 2018
@srirambv srirambv added this to the Backlog milestone Jun 28, 2018
@riastradh-brave
Copy link
Contributor

Ctrl-Shift-P/Cmd-Shift-P is taken for printing. We settled on Alt-Shift-N/Cmd-Opt-N for new private window with Tor for now in #1387.

@bbondy bbondy modified the milestones: 1.x Backlog, FROZEN: 0.55.x - Release Oct 17, 2018
@srirambv
Copy link
Contributor Author

srirambv commented Oct 18, 2018

Verification Passed on

Brave 0.55.17 Chromium: 70.0.3538.67 (Official Build) (64-bit)
Revision 9ab0cfab84ded083718d3a4ff830726efd38869f-refs/branch-heads/3538@{#1002}
OS Linux

Verified passed with

Brave 0.55.17 Chromium: 70.0.3538.67 (Official Build) (64-bit)
Revision 9ab0cfab84ded083718d3a4ff830726efd38869f-refs/branch-heads/3538@{#1002}
OS Mac OS X
  • Verified Cmd+Shift+N opens a new private window
  • Verified Cmd+Option+N opens a new Tor window

Verification Passed on

Brave 0.55.17 Chromium: 70.0.3538.67 (Official Build) (32-bit)
Revision 9ab0cfab84ded083718d3a4ff830726efd38869f-refs/branch-heads/3538@{#1002}
OS Windows

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
design A design change, especially one which needs input from the design team feature/keyboard-shortcuts QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Yes
Projects
None yet
Development

No branches or pull requests

5 participants