Menu items & keyboard shortcuts to launch private windows with Tor #1387
Comments
Renaming for Incognito will be done here: |
tildelowengrimm
changed the title
fix brave/brave-browser#1387 - Main hamburger menu in non-Tor windows: New private window with Tor - Context menu for right-click on links: Open link in private window with Tor This pushes IsTorProfile() into BrowserContext where it now resides alongside IsOffTheRecord(), since we need it in order to determine whether the 'Open link in private window with Tor' item should be greyed out or not. (Is this a little silly? Maybe, but it's what the browser already does with 'Open link in incognito window' item.) Test plan: 1. 1. Open a fresh browser instance. 2. Confirm that hamburger -> 'New private window with Tor' (NPWWT) opens a private window with Tor. 3. In the _Tor_ window, open <https://check.torproject.org/>. 4. Confirm that you are using Tor. 5. Right-click any link on the page. 6. Confirm that items to open in a private window, with or without Tor, are greyed out. 7. Confirm that in the _normal_ window's hamburger, NPWWT switches to the private window with Tor it just opened. 8. Confirm that in the _Tor_ window's hamburger, 'New window' opens a new private window with Tor. 9. Confirm that in the _Tor_ window's hamburger, there is no NPWWT. 3. 1. Open a fresh browser instance. 2. In a _normal_ window, open <https://www.example.com/>. 3. Right-click the 'More information...' link. 4. Select 'Open link in private window with Tor'. 5. Confirm that the link opens in a Tor window. 6. In the normal window, do it again. 7. Confirm that the link opens in a new tab in the existing Tor window. TODO: Rename IsTorProfile to make more sense for BrowserContext.
|
PR ready for review now: brave/brave-core#605 Caveats:
Neither of these is critical, so I figured it's better to make progress on getting the baseline functionality merged before worrying about these details. |
|
That is expected behavior, it should behave just like "Open Tor window" in avatar menu. If users need new tor window, use "New Window" in tor window. The main purpose of the item in regular profile is making users easier to access tor window |
|
PR actually addresses the whole issue including keyboard shortcut now: fb73c75eeafa87aa035e55ff84d97f02d7a1fc16 |
|
The key sequence Ctrl-Alt-N is apparently problematic in Chromium on Windows, as is Ctrl-Alt-anythingelse. So, we need to find an alternative. (I wonder what Emacs does on Windows, when every third keyboard command is control-meta-something?) |
|
If the way to create a new private window with Tor from an existing one is the "New Window" menu option, then that menu option needs to be renamed to "New Private Window with Tor" with the same keyboard shortcut when within an existing private window with Tor. I understand that we made the technical decision to implement this as a separate user profile. But nobody using their browser needs to understand that. All they need is for it to feel the same as regular private windows. |
|
Correction: brave/brave-core#605 did not update the File menu on macOS. |
|
@riastradh-brave could you leave this one closed and rename it and then post a new one with the remaining items? Typically if some part is fixed it's best to post a new issue for the remaining issues. |
|
Superseded by #1627. |
|
Verification Passed on
Verification Passed on
Verified passed with
|
Two changes need to be made to the UI for launching private windows with Tor:
Ctrl + Alt + N/Cmd + Opt + N.The Incognito window menu item exists in three places:
The text was updated successfully, but these errors were encountered: