Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Menu fixes for private windows with Tor #1627

Closed
2 tasks done
riastradh-brave opened this issue Oct 16, 2018 · 5 comments · Fixed by brave/brave-core#2373
Closed
2 tasks done

Menu fixes for private windows with Tor #1627

riastradh-brave opened this issue Oct 16, 2018 · 5 comments · Fixed by brave/brave-core#2373
Assignees
@simonhong @riastradh-brave
Labels
feature/private-browsing feature/tor/guest-semantics Exposing the fact that private windows with Tor are built on guest sessions. feature/tor OS/macOS priority/P3 The next thing for us to work on. It'll ride the trains.
Milestone
0.66.x - Release ...

Comments

@riastradh-brave
Copy link
Contributor

riastradh-brave commented Oct 16, 2018 •
edited by simonhong
Loading

Unfinished business from #1387:

  • Update the macOS File menu to include New private window with Tor like the hamburger menu does.
  • Make the menu items match with or without Tor. (In private windows with Tor, New window and Ctrl-N should still open a new window in Tor; you can always get back to a non-private window, without Tor, in the profile menu.)
@riastradh-brave riastradh-brave self-assigned this Oct 16, 2018
@riastradh-brave riastradh-brave mentioned this issue Oct 16, 2018
Closed
2 tasks
@riastradh-brave
Copy link
Contributor Author

File menu is implemented here: src/chrome/browser/ui/cocoa/main_menu_builder.mm

But not everything from the hamburger menu needs to be echoed there; see GetShortcutsNotPresentInMainMenu in src/chrome/browser/global_keyboard_shortcuts_mac.mm.

@srirambv
Copy link
Contributor

hamburger menu shows New Private window with Tor on master (Windows)
image

@bbondy bbondy added this to the 1.x Backlog milestone Oct 18, 2018
riastradh-brave added a commit to brave/brave-core that referenced this issue Oct 18, 2018
@riastradh-brave
Keep the menu items in private windows with Tor same as in others.
7a23038 
fix brave/brave-browser#1627

The result is a little silly -- because private windows with Tor are
implemented in a guest session, all new windows open in the same
session, whether with 'New window' or 'New incognito window' (soon to
be 'New private window') or 'New private window with Tor').

On the other hand, this is perhaps justifiable because we don't want
to make it easy to accidentally _stop_ using Tor.  You can do that
explicitly through the profile menu -- but not just by casually
hitting Ctrl-N.

On the third hand, control-click on links _greys out_ the 'Open link
in private window' item when you're in a private window, rather than
making it just...do what it says.  ('Open link in new window' also
opens in a new private window in that case.)  For consistency, maybe
we should do that instead, when we are on less of a deadline?
@riastradh-brave riastradh-brave mentioned this issue Oct 18, 2018
Closed
18 tasks
@LaurenWags
Copy link
Member

LaurenWags commented Oct 18, 2018 •
edited
Loading

@riastradh-brave does this issue also cover adding 'Open in Private Window with Tor' to the 3 dots menu from Bookmarks (as mentioned in description of #1387 )? If you'd like a different issue logged please let me know.

Logged #1699 as bookmarks issue occurs on Win/Linux/MacOS and this issue is macOS specific.

@rebron rebron added the priority/P4 Planned work. We expect to get to it "soon". label Oct 19, 2018
@riastradh-brave riastradh-brave added the feature/tor/guest-semantics Exposing the fact that private windows with Tor are built on guest sessions. label Oct 23, 2018
@davidtemkin davidtemkin mentioned this issue Oct 23, 2018
Closed
4 tasks
@rebron rebron removed this from the 1.x Backlog milestone Oct 30, 2018
@bbondy bbondy added this to the 1.x Backlog milestone Oct 30, 2018
@tildelowengrimm tildelowengrimm added priority/P3 The next thing for us to work on. It'll ride the trains. and removed priority/P4 Planned work. We expect to get to it "soon". labels Nov 28, 2018
@rebron rebron modified the milestone: 1.x Backlog Feb 7, 2019
@tildelowengrimm
Copy link
Contributor

@simonhong Could you take care of this?

@simonhong simonhong self-assigned this Apr 22, 2019
@simonhong
Copy link
Member

@tomlowenthal yup. assigned to me.

@simonhong simonhong mentioned this issue May 6, 2019
Merged
28 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@simonhong simonhong

@riastradh-brave riastradh-brave

Labels
feature/private-browsing feature/tor/guest-semantics Exposing the fact that private windows with Tor are built on guest sessions. feature/tor OS/macOS priority/P3 The next thing for us to work on. It'll ride the trains.
Projects
None yet
Milestone
0.66.x - Release (Release Channel)
7 participants
@tildelowengrimm @bbondy @rebron @simonhong @srirambv @LaurenWags @riastradh-brave