Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Closing last tab should open a new tab (not exit browser) #5873

Closed
Gelo3D opened this issue Nov 28, 2016 · 22 comments
Closed

Closing last tab should open a new tab (not exit browser) #5873

Gelo3D opened this issue Nov 28, 2016 · 22 comments

Comments

@Gelo3D
Copy link

Gelo3D commented Nov 28, 2016

Did you search for similar issues before submitting this one?

yes

Describe the issue you encountered:

Exit last tab do new tab not exit browser

Expected behavior:

  • Platform (Win7, 8, 10? macOS? Linux distro?):

  • Brave Version:

  • Steps to reproduce:
    1.
    2.
    3.

  • Screenshot if needed:

  • Any related issues:

@Gelo3D Gelo3D changed the title [Request [Request] Exit last tab do new tab not exit browser Nov 28, 2016
@bsclifton bsclifton changed the title [Request] Exit last tab do new tab not exit browser Closing last tab should open a new tab (not exit browser) Nov 28, 2016
@srirambv
Copy link
Collaborator

+1 on this

@NejcZdovc
Copy link
Contributor

Or something like this #1515

@srirambv
Copy link
Collaborator

Not exactly as #1515. That is specifically to warn when user clicks the browser close button. This is for when there is only one tab and you close the tab it should create a about:newtab instead of closing the browser itself.

@NejcZdovc
Copy link
Contributor

you are right, not completely the same

@kumarrishav
Copy link
Contributor

@NejcZdovc @srirambv should this be default (only) behaviour or configurable from preference @bsclifton

@srirambv
Copy link
Collaborator

+1 for adding it as a preference under tabs and off by default.

@kumarrishav
Copy link
Contributor

off by default means : closing last tab should close the browser . right? @srirambv

@srirambv
Copy link
Collaborator

Yup that's correct.
Disable switch (default) - Close last tab, close browser window
Enable switch - Close last tab, create about:newtab and retain the window

@NejcZdovc
Copy link
Contributor

NejcZdovc commented May 11, 2017

cc @bradleyrichter for his thoughts

@luixxiul
Copy link
Contributor

+1 from me based on the fact that for now BF cache is cleared when closing the browser.

the request has the common motive with #1382

@srirambv
Copy link
Collaborator

srirambv commented Jul 3, 2017

@Jacalz
Copy link
Contributor

Jacalz commented Jul 3, 2017

+1 from me

@bradleyrichter
Copy link
Contributor

Agree - if the tab to be closed is the last remaining tab not including pinned tabs, then it should be replaced with a new tab and NOT close the browser. We should not need to add a preference for this.

@KutX9JtmXrZP
Copy link

+1

For reference in firefox: about:config
browser.tabs.closeWindowWithLastTab setting

@cezaraugusto cezaraugusto added this to the Triage Backlog milestone Nov 8, 2017
@RGBD
Copy link

RGBD commented Nov 30, 2017

+1

@bradleyrichter bradleyrichter modified the milestones: Triage Backlog, 0.20.x (Beta Channel) Nov 30, 2017
@NejcZdovc NejcZdovc modified the milestones: 0.20.x (Beta Channel), Backlog (Prioritized) Dec 22, 2017
@NejcZdovc NejcZdovc added the priority/P4 Minor loss of function. Workaround usually present. label Dec 22, 2017
@eljuno
Copy link
Contributor

eljuno commented Jan 15, 2018

@lordstrudel
Copy link

+1 from me

@bradleyrichter
Copy link
Contributor

@petemill is this something small you can add to a near future PR?

ryanml added a commit to ryanml/browser-laptop that referenced this issue Mar 23, 2018
ryanml added a commit to ryanml/browser-laptop that referenced this issue Mar 23, 2018
@AlexUhde
Copy link

AlexUhde commented May 7, 2018

+1

@nCrazed
Copy link

nCrazed commented Jul 17, 2018

I keep coming back to trying Brave just to find that it's still unusable due to the application window disappearing when it shouldn't.

@Fafofu
Copy link

Fafofu commented Sep 3, 2018

How long does it take to wait !? Do it faster!

@bsclifton
Copy link
Member

Closing in favor of brave/brave-browser#1002

@bsclifton bsclifton removed this from the Backlog (Prioritized) milestone Sep 7, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests