Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

reward banner stackable when clicking on "Send a Tip" multiple times #1683

Closed
kjozwiak opened this issue Oct 18, 2018 · 2 comments
Closed

reward banner stackable when clicking on "Send a Tip" multiple times #1683

kjozwiak opened this issue Oct 18, 2018 · 2 comments
Labels
feature/rewards priority/P5 Not scheduled. Don't anticipate work on this any time soon. QA/Test-Plan-Specified QA/Yes

Comments

@kjozwiak
Copy link
Member

Description

When clicking on Send a Tip.. via the Rewards panel in the URL, you'll stack several banners on top of each other. We shouldn't be stacking the same banner.

Steps to Reproduce

  1. launch brave (used 0.55.17 Chromium: 70.0.3538.67)
  2. enable rewards via brave://rewards
  3. once enabled, visit a random website and wait a few seconds
  4. click on the BAT icon in the URL and click on Send a Tip..
  5. once the tipping banner appears, click on the BAT icon in the URL and repeat 4-5 a few times

You'll notice that you can stack the same banner multiple times.

Actual result:

bannerstacking

Expected result:

The tip banner shouldn't be stackable.

Reproduces how often:

100% reproducible using the above STR.

Brave version (brave://version info)

Brave 0.55.17 Chromium: 70.0.3538.67 (Official Build) (64-bit)
Revision 9ab0cfab84ded083718d3a4ff830726efd38869f-refs/branch-heads/3538@{#1002}
OS Mac OS X

Reproducible on current release:

  • Does it reproduce on brave-browser dev/beta builds?

Yes, reproducible under beta & dev.

  • Does it reproduce on browser-laptop?

N/A

@kjozwiak kjozwiak added this to the 1.0 milestone Oct 18, 2018
@srirambv srirambv mentioned this issue Oct 18, 2018
@NejcZdovc NejcZdovc modified the milestones: 1.0, 0.56.x - Beta Oct 22, 2018
@bbondy bbondy modified the milestones: 0.57.x - Dev, 1.x Backlog Oct 30, 2018
@NejcZdovc NejcZdovc added the priority/P5 Not scheduled. Don't anticipate work on this any time soon. label Oct 30, 2018
@mandar-brave mandar-brave added priority/P3 The next thing for us to work on. It'll ride the trains. and removed priority/P5 Not scheduled. Don't anticipate work on this any time soon. labels Dec 17, 2018
@rebron rebron modified the milestone: 1.x Backlog Feb 7, 2019
@Miyayes Miyayes added priority/P5 Not scheduled. Don't anticipate work on this any time soon. and removed priority/P3 The next thing for us to work on. It'll ride the trains. labels Oct 8, 2021
@Miyayes
Copy link
Collaborator

Miyayes commented Oct 8, 2021

Reproduced in v1.31+, so still technically valid issue. Will get triaged in next meeting.

@Miyayes
Copy link
Collaborator

Miyayes commented Apr 20, 2023

No longer an issue with Contribution Banner 3.0.

@Miyayes Miyayes closed this as not planned Won't fix, can't repro, duplicate, stale Apr 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature/rewards priority/P5 Not scheduled. Don't anticipate work on this any time soon. QA/Test-Plan-Specified QA/Yes
Projects
None yet
Development

No branches or pull requests

7 participants