-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Some of the blocked requests appear to be processed/sent twice #1213
Labels
feature/shields
The overall Shields feature in Brave.
needs-investigation
A bug not 100% confirmed/fixed
priority/P4
Planned work. We expect to get to it "soon".
Comments
rebron
added
priority/P3
The next thing for us to work on. It'll ride the trains.
feature/shields
The overall Shields feature in Brave.
labels
Sep 28, 2018
tildelowengrimm
added
needs-investigation
A bug not 100% confirmed/fixed
priority/P4
Planned work. We expect to get to it "soon".
and removed
priority/P3
The next thing for us to work on. It'll ride the trains.
labels
Oct 31, 2018
@srirambv could you check and see if this is fixed? |
@brave/legacy_qa — can you reproduce this? |
Will check and update results today |
This was referenced Jul 28, 2022
This was referenced Jul 29, 2022
This was referenced Jul 29, 2022
This was referenced Jul 29, 2022
71 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
feature/shields
The overall Shields feature in Brave.
needs-investigation
A bug not 100% confirmed/fixed
priority/P4
Planned work. We expect to get to it "soon".
Description
Some network requests that get blocked appear processed and potentially resent twice among "Ads and Trackers Blocked" as well as in the Network tab in Dev Tools. Such duplicates do not appear in stable release (either counters, or network tab).
Steps to Reproduce
For stability, should be done via a web replay proxy, but can be reproduced with less dynamic sites
Actual result:
visiting qz.com for example produces list:
Expected result:
On stable release the duplicates are not present.
Reproduces how often:
Easily reproduced, however best using a page replay proxy
Brave version (chrome://version info)
Reproducible on current release:
No
Website problems only:
Disabling shields and observing requests received at the proxy, the duplicates are not present
The text was updated successfully, but these errors were encountered: