Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Page could not be translated message rendered when switching between supported languages in the Brave translate extension bubble #24649

Open
MadhaviSeelam opened this issue Aug 12, 2022 · 7 comments
Labels
brave-translate OS/Desktop priority/P3 The next thing for us to work on. It'll ride the trains.

Comments

@MadhaviSeelam
Copy link

Description

Steps to Reproduce

  1. Install 1.43.54
  2. open brave://flags/#brave-translate-go and select Enabled
  3. relaunch the browser
  4. view a site in one of the supported languages German - https://www.faz.net/
  5. click Brave translate extension in the URL bar
  6. click Choose another language in the hamburger menu in the bubble
  7. select Portuguese and click translate

Actual result:

This page could not be translated message displayed
image

Expected result:

This page could not be translated message should not be rendered. Page should be translated as per the selection of the language.

Reproduces how often:

Intermittently (got this error twice for Hindi and Portuguese)

Brave version (brave://version info)

Brave 1.43.54 Chromium: 104.0.5112.69 (Official Build) beta (64-bit)
Revision 7ce2902023c722af8564068e6b26e934b83fd774-refs/branch-heads/5112@{#1213}
OS Windows 11 Version 21H2 (Build 22000.856)

Version/Channel Information:

  • Can you reproduce this issue with the current release? n/a
  • Can you reproduce this issue with the beta channel? Yes
  • Can you reproduce this issue with the nightly channel? n/a

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields?
  • Does the issue resolve itself when disabling Brave Rewards?
  • Is the issue reproducible on the latest version of Chrome?

Miscellaneous Information:

cc: @rebron @brave/qa-team

@MadhaviSeelam MadhaviSeelam changed the title Page could not be translated message rendered when switching between supported languages in the Brave translate extension bubble Page could not be translated message rendered when switching between supported languages in the Brave translate extension bubble Aug 12, 2022
@rebron
Copy link
Collaborator

rebron commented Aug 15, 2022

cc: @atuchin-m

@rebron rebron added brave-translate priority/P3 The next thing for us to work on. It'll ride the trains. labels Aug 15, 2022
@rebron
Copy link
Collaborator

rebron commented Aug 16, 2022

Screenshot 2022-08-16 at 8 05 51 AM

I'm wondering if this is intermittent. I couldn't reproduce.

@stephendonner
Copy link

There's definitely a timing/race-condition here, which I meant to mention while verifying #24075 - it's definitely improved (in places) but still around. Sorry for not mentioning that, and thanks for filing, @MadhaviSeelam !

@atuchin-m
Copy link
Contributor

@stephendonner #24075 is only about the first call to translate.
If it is the reason the next attempts should work smooth.

@atuchin-m
Copy link
Contributor

@MadhaviSeelam Sadly I can't reproduce the bug by the provided scenario.

  1. Does it happens only on the first translation attempt after relaunch? (I also suspect Adjust translate initialization timeouts #24075)
  2. If not, could you please provide brave://translate-internals/ + chrome://histograms saved as webpages?

@MadhaviSeelam
Copy link
Author

MadhaviSeelam commented Aug 17, 2022

@atuchin-m - I was able to reproduce the issue with a new install. Sent you links via DM for brave://translate-internals/ + chrome://histograms

  1. Install 1.43.73
  2. launch brave
  3. restart the browser to enable Brave translate via griffin
  4. visit https://www.lemonde.fr/
  5. click Brave translate in the URL bar
  6. click Page is not French in the hamburger menu in the bubble
  7. select English and click translate
  8. throws that message 100% if it is English-->English but not sure if that's expected.

2022-08-17_10h29_24

@atuchin-m
Copy link
Contributor

@MadhaviSeelam @rebron the way I see it is that it's the backend issue, not the client one.

I suggest rechecking it after #24303 is resolved.
If it doesn't helps we need the check the requests to translate.brave.com in devtools to see which one is failed and why.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
brave-translate OS/Desktop priority/P3 The next thing for us to work on. It'll ride the trains.
Projects
None yet
Development

No branches or pull requests

4 participants