-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[hackerone] IPFS crash #23646
Comments
please don't share the link publicly that causes the crash |
@cypt4 @diracdeltas 👋 do you have a step-by-step testcase handy QA can follow? If there's something to be not made public in the verification, we can create an internal issue and cross-link here. Marking |
Verified
|
Brave | 1.42.62 Chromium: 103.0.5060.114 (Official Build) beta (x86_64) |
---|---|
Revision | a1c2360c5b02a6d4d6ab33796ad8a268a6128226-refs/branch-heads/5060@{#1124} |
OS | macOS Version 13.0 (Build 22A5295i) |
Conversation with the original link (now defunct) and minimal testcase (which works) is in https://bravesoftware.slack.com/archives/G2KN13Z8C/p1657739382970029?thread_ts=1657733235.918989&cid=G2KN13Z8C
Steps:
- installed
1.42.62
- launched Brave
- created a minimal testcase from the above Slack link, and saved it
- set
Method to resolve IPFS resources
toDisabled
, inbrave://settings/ipfs
- loaded the minimal testcase
Confirmed I don't crash, and the IPFS resource was blocked
IPFS disabled | testcase blocked |
---|---|
Verification PASSED on
Brave | 1.42.80 Chromium: 104.0.5112.57 (Official Build) (64-bit)
-- | --
Revision | 212fd173a0da1e0a024f328295bb56a2529190bb-refs/branch-heads/5112@{#1042}
OS | Windows 10 Version 21H2 (Build 19044.1826)
- Verified the steps above
- Confirmed that there is no crash when the IPFS resource was blocked
IPFS disabled | testcase blocked |
---|---|
Verification passed on
Brave | 1.42.81 Chromium: 104.0.5112.69 (Official Build) (64-bit) |
---|---|
Revision | 7ce2902023c722af8564068e6b26e934b83fd774-refs/branch-heads/5112@{#1213} |
OS | Ubuntu 18.04 LTS |
- Verified the steps above
- Confirmed that there is no crash when the IPFS resource was blocked
IPFS disabled | testcase blocked |
---|---|
https://hackerone.com/reports/1610343
credit:
neeythann
The text was updated successfully, but these errors were encountered: