Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable Widevine setting is not translated #14144

Closed
btlechowski opened this issue Feb 13, 2021 · 5 comments
Closed

Enable Widevine setting is not translated #14144

btlechowski opened this issue Feb 13, 2021 · 5 comments

Comments

@btlechowski
Copy link

Follow up from #2791

Steps to Reproduce

  1. Run Brave in Polish (PL) locale
  2. Open brave://settings/extensions
  3. Check Enable Widevine

Actual result:

Enable Widevine setting is not translated
Enable Widevine description is not translated
image
image

Expected result:

Enable Widevine setting is translated

Reproduces how often:

Easily reproduced

Brave version (brave://version info)

Brave 1.21.52 Chromium: 88.0.4324.152 (Official Build) dev (64-bit)
Revision 6579930fc53b4dc589c042bec9d0a3778326974d-refs/branch-heads/4324@{#2106}
OS Ubuntu 18.04 LTS
Brave 1.22.23 Chromium: 89.0.4389.48 (Oficjalna wersja) nightly (64-bitowa)
Wersja 0fe3c4589a6cf5ce719d167834dfa9cd8978937a-refs/branch-heads/4389@{#873}
System operacyjny Linux

cc @brave/legacy_qa @mkarolin @rebron

@btlechowski
Copy link
Author

In 1.21.65, the string changed again.
image

@rebron rebron added the priority/P2 A bad problem. We might uplift this to the next planned release. label Mar 1, 2021
@rebron
Copy link
Collaborator

rebron commented Mar 1, 2021

cc: @mkarolin Should be addressed with the next l10n pull.

@mkarolin
Copy link
Contributor

mkarolin commented Mar 1, 2021

Correct. @btlechowski, please re-test once #14369 has been closed.

@kjozwiak
Copy link
Member

kjozwiak commented Mar 2, 2021

As per #14369 (comment), moving issue into https://github.com/brave/brave-browser/milestone/167 now that brave/brave-core#8093 was merged into 1.22.x and 1.21.x via brave/brave-core#8096 & brave/brave-core#8097.

@brave/legacy_qa if it's still an issue, please re-open and remove it from the milestone as there was no code associated with the issues so we can just re-open then and decide if it's release blocking or not.

@kjozwiak kjozwiak added this to the 1.21.x - Release milestone Mar 2, 2021
@kjozwiak kjozwiak closed this as completed Mar 2, 2021
@btlechowski
Copy link
Author

btlechowski commented Mar 2, 2021

Verification passed on

Brave 1.21.71 Chromium: 89.0.4389.72 (Official Build) (64-bit)
Revision 3f345f156bfd157bd1bea06310e55f3fb2490359-refs/branch-heads/4389@{#1393}
OS Ubuntu 18.04 LTS

Polish locale
image


Verification passed on


Brave | 1.21.71 Chromium: 89.0.4389.72 (Offizieller Build) (64-Bit)
-- | --
Überarbeitung | 3f345f156bfd157bd1bea06310e55f3fb2490359-refs/branch-heads/4389@{#1393}
Betriebssystem | Windows 10 OS Version 2004 (Build 19041.804)

German locale

image

France locale
image

Kannada locale
image


Verified passed with

Brave | 1.21.71 Chromium: 89.0.4389.72 (Build oficial) (x86_64)
-- | --
Revisión | 3f345f156bfd157bd1bea06310e55f3fb2490359-refs/branch-heads/4389@{#1393}
Sistema operativo | macOS Versión 10.15.7 (Compilación 19H512)

Verified STR using Spanish (Spain).

Spanish

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants