Tipping doesn't do anything

[junkguy]

Description

Tipping lets you go through the process to send a tip, but wallet's BAT amount doesn't change and the tip is not listed in brave://rewards/

Steps to Reproduce

1. In brave://rewards/, restore a wallet from a recovery key. The wallet has previous user grants, but is not self funded.
2. On any site, click the rewards icon, click "Send A Tip...", select any amount of BAT, click "Send my tip"
3. "Thank You" popup appears.
4. Overall BAT amount is unchanged.

Actual result:

BAT amount is unchanged after tipping. On brave://rewards/, "Tips" section is empty

Expected result:

BAT amount should be deducted by the tipped amount.

Reproduces how often:

Always (when using a restored wallet. Haven't tried with a new wallet)

Brave version (brave://version info)

Brave	0.56.12 Chromium: 70.0.3538.77 (Official Build) (64-bit)
Revision	0f6ce0b0cd63a12cb4eccea3637b1bc9a29148d9-refs/branch-heads/3538@{#1039}
OS	Mac OS X

Reproducible on current release:

• Does it reproduce on brave-browser dev/beta builds?
  Don't know

Website problems only:

• Does the issue resolve itself when disabling Brave Shields?
  No

• Is the issue reproducible on the latest version of Chrome?
  N/A

Additional Information

The restored wallet was from the Muon version of Brave.

[LaurenWags]

Hey @junkguy - I'd like to get some additional information from you so the team can investigate but some of it is sensitive (it pertains to your wallet). Are you a member of our community (community.brave.com)? You can DM me there - I'm LaurenWags on community as well. Or if you're on Twitter, my handle is bravelaurenwags and we can DM there.

[Brave-Matt]

+1 for this but I'm not sure if this is a widespread issue or specific to some users:
https://www.reddit.com/r/brave_browser/comments/9vmn4y/brave_version_05612_now_available_on_release/e9mxnrm/?context=3&utm_content=context&utm_medium=message&utm_source=reddit&utm_name=frontpage

[eljuno]

+1s from Community https://community.brave.com/t/brave-rewards-for-publishers/37390?u=eljuno

[rebron]

We think users from 55.22.x upgrading to 56.x are experiencing this issue. Would like to get this fixed for 0.57.x

[NejcZdovc]

@kjozwiak @LaurenWags do we have STR for this one?

[LaurenWags]

@NejcZdovc I connected with the OP. seems like their wallets are now allowing them to tip. I'm wondering if at the time of attempting to tip there was a server issue which prevented them from doing so, which we've experienced before. So, it seems like we might be better served by putting in some kind of notification which lets users know that the server is unable to complete their tip request at present time. I did some looking and I'm wondering if this issue #1481 cover that scenario? cc @kjozwiak

[LaurenWags]

Encountered this again today. We really need some kind of UI messaging to tell the user if their Tip didn't go thru and they should try again later. As it stands now, the only indication that your tip didn't go thru is that your balance doesn't go down and the tip isn't listed. If you're not watching those like a hawk you'll never know. A notification on the BAT logo would be helpful to let a user know that the tip failed. cc @rebron @kjozwiak

[NejcZdovc]

@LaurenWags can you please paste ledger_state here, when this happens again. Thank you

[LaurenWags]

@NejcZdovc doesn't that have potentially sensitive info on my wallet?

[NejcZdovc]

@LaurenWags is this not staging testing wallet?

[LaurenWags]

@NejcZdovc no, this was on Production.

[eljuno]

+1 from Community https://community.brave.com/t/send-a-tip-function-not-working/38958?u=eljuno

[kiwina]

PUT /v2/wallet/xxxxxxxxxxx
{"requestType":"httpSignature","signedTx":{"headers":{"digest":"SHA-256=xxxxxxxx","signature":"keyId=\"primary\",algorithm=\"ed25519\",headers=\"digest\",signature=\"xxxxxxxxxx\""},"body":{"denomination":{"amount":"1","currency":"BAT"},"destination":"xxxxxxxxxx"},"octets":"{\"denomination\":{\"amount\":\"1\",\"currency\":\"BAT\"},\"destination\":\"xxxxxxx\"}"},"surveyorId":"xxxxxxxx","viewingId":"xxxxxxx"}
{"statusCode":400,"error":"Bad Request","message":"Response Error: 400 Bad Request"}
happens on
Version 0.56.15 Chromium: 70.0.3538.110 (Official Build) (64-bit)
Version 0.57.18 Chromium: 71.0.3578.80 (Official Build) (64-bit)
Version 0.59.2 Chromium: 71.0.3578.80 (Official Build) dev (64-bit)
tried several sites and asked several people all the same

[LaurenWags]

Logged #2453 to improve error flow for tipping.

[Biglulux]

I also have an issue where tipping doesn't work, where in some cases I don't get the option to tip at all for some websites. It seems to be random. The tip button also appears for some YouTubers, but not for others. Their verified status does not seem to make a difference. For example, I can tip GitHub (and GitHub is not verified) right now, but I cannot tip Google.
Version: Version 0.58.21 Chromium: 71.0.3578.98 (Official Build) (64-bit). Live release.

I am using a wallet that only has ever had user grants, never self funded, and not recovered.

[NejcZdovc]

closing as stale