Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BAP popup can overlap rewards panel in certain cases #14108

Closed
LaurenWags opened this issue Feb 11, 2021 · 4 comments · Fixed by brave/brave-core#7935
Closed

BAP popup can overlap rewards panel in certain cases #14108

LaurenWags opened this issue Feb 11, 2021 · 4 comments · Fixed by brave/brave-core#7935

Comments

@LaurenWags
Copy link
Member

Description

Found while testing brave/brave-core#7698

Sometimes the BAP popup can overlap the rewards panel.

Steps to Reproduce

  1. Clean profile, region = Japan, staging environment
  2. Opened NTP
  3. Opened Rewards panel, dismissed onboarding modal
  4. Claimed UGP grant
  5. Completed captcha
  6. Waited a few seconds (for grant to process), then closed "It's your lucky day" overlay.
  7. Clicked elsewhere so Brave was not in focus
  8. Then the BAP popup displayed overlapping the rewards panel

Actual result:

Screen Shot 2021-02-11 at 12 04 30

Expected result:

No overlay. Or, per suggestion of @Miyayes an "x" or close button.

Reproduces how often:

easily

Brave version (brave://version info)

Brave	1.22.19 Chromium: 89.0.4389.40 (Official Build) nightly (x86_64)
Revision	2c2ed83cd507b23e4845edd09a7d1dfc727daf4b-refs/branch-heads/4389@{#602}
OS	macOS Version 10.15.7 (Build 19H512)

Version/Channel Information:

  • Can you reproduce this issue with the current release?
  • Can you reproduce this issue with the beta channel?
  • Can you reproduce this issue with the nightly channel? yes

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields?
  • Does the issue resolve itself when disabling Brave Rewards?
  • Is the issue reproducible on the latest version of Chrome?

Miscellaneous Information:

cc @zenparsing @Miyayes @brave/legacy_qa

@LaurenWags
Copy link
Member Author

Verified passed with

Brave | 1.22.22 Chromium: 89.0.4389.40 (Official Build) nightly (x86_64)
-- | --
Revision | 2c2ed83cd507b23e4845edd09a7d1dfc727daf4b-refs/branch-heads/4389@{#602}
OS | macOS Version 10.15.7 (Build 19H512)

Verified STR from description.
Confirmed no overlapping popup/panel observed.

@GeetaSarvadnya
Copy link

GeetaSarvadnya commented Feb 17, 2021

Verification passed on

Brave	1.20.104 Chromium: 88.0.4324.152 (Official Build) (64 ビット)
変更履歴	6579930fc53b4dc589c042bec9d0a3778326974d-refs/branch-heads/4324@{#2106}
OS	Windows 10 OS Version 1809 (Build 17763.1637)
  • Verified the STR from the description
  • Confirmed no overlapping popup/panel observed.
    image

Verification passed on

Brave 1.20.104 Chromium: 88.0.4324.152 (Official Build) (64-bit)
Revision 6579930fc53b4dc589c042bec9d0a3778326974d-refs/branch-heads/4324@{#2106}
OS Ubuntu 18.04 LTS
  • Verified the STR from the description
  • Confirmed no overlapping popup/panel observed.

image

Verified FIXED using

Brave 1.20.104 Chromium: 88.0.4324.152 (Official Build) (x86_64)
Revision 6579930fc53b4dc589c042bec9d0a3778326974d-refs/branch-heads/4324@{#2106}
OS macOS Version 11.2.1 (Build 20D74)

rewards-bap

@kjozwiak
Copy link
Member

Moving this into 1.22.x as the BAP work is being reverted via brave/brave-core#8088. Once we have more information next week, we'll re-revert brave/brave-core#8088 and move everything back into 1.21.x and release 1.21.x - Release #2.

@kjozwiak
Copy link
Member

Labeling this as QA/No as the case re: the tooltip being displayed isn't valid as per https://github.com/brave/internal/issues/747#issuecomment-761233483. The above tooltip stops being displayed ~a week before March 13th. Seeing as March 13th is in ~2 days, this isn't valid anymore.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment