Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BAP & Shields tooltip overlap on each other #14158

Closed
srirambv opened this issue Feb 15, 2021 · 5 comments
Closed

BAP & Shields tooltip overlap on each other #14158

srirambv opened this issue Feb 15, 2021 · 5 comments

Comments

@srirambv
Copy link
Contributor

Description

BAP & Shields tooltip overlap on each other

Steps to reproduce

Pre-requisite: Device should be set to JP as the bug is region specific

  1. Install 1.20.x nightly build
  2. Visit any page to trigger shields modal
  3. Upgrade to 1.22.41 x64 nightly build
  4. Launch browser, page loads
  5. BAP modal is shown and when page load completes, shields tooltip is shown overlapping BAP message

Actual result

Expected result

Should show only one tooltip at a time. Closing one should trigger the other

Issue reproduces how often

Easy

Version/Channel Information:

  • Can you reproduce this issue with the current Play Store version? NA
  • Can you reproduce this issue with the current Play Store Beta version? NA
  • Can you reproduce this issue with the current Play Store Nightly version? Yes

Device details

  • Install type (ARM, x86): ARM
  • Device type (Phone, Tablet, Phablet): Phone
  • Android version: 10

Brave version

1.22.24 x64 Nightly build

Website problems only

  • Does the issue resolve itself when disabling Brave Shields? NA
  • Does the issue resolve itself when disabling Brave Rewards? NA
  • Is the issue reproducible on the latest version of Chrome? NA

Additional information

Similar Desktop bug #14108

@kjozwiak
Copy link
Member

Added release-blocking as we'll want to include this in 1.20.x - Release #2 after speaking with @deeppandya and @Miyayes.

@deeppandya
Copy link

the issue is fixed in brave/brave-core@8622599

@kjozwiak
Copy link
Member

Closing as this was fixed as per #14158 (comment).

@kjozwiak
Copy link
Member

Moving this into 1.22.x as the BAP work is being reverted via brave/brave-core#8088. Once we have more information next week, we'll re-revert brave/brave-core#8088 and move everything back into 1.21.x and release 1.21.x - Release #2.

@srirambv
Copy link
Contributor Author

This is not a valid issue anymore. Tooltip was to be shown only till March 6 which means tooltips won't show up anymore. Marking as QA/No

cc: @Miyayes @deeppandya @brave/legacy_qa

@srirambv srirambv added QA/No and removed QA/Yes labels Mar 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants