Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Blocking Youtube Autoplay is not working properly #14266

Closed
BraveSauce opened this issue Feb 19, 2021 · 19 comments
Closed

Blocking Youtube Autoplay is not working properly #14266

BraveSauce opened this issue Feb 19, 2021 · 19 comments

Comments

@BraveSauce
Copy link

Description

While blocking Autoplay globally and also explicitly for youtube.com, any video content that is opened in a new tab ignores the setting.

Steps to Reproduce

  1. Browse youtube.com
  2. Open any video in a new tab
  3. Switch to the newly opened tab.

Actual result:

Video starts playing, ignoring the setting.

Expected result:

The setting should be respected and the video must not autoplay.

Reproduces how often:

Every time.

Brave version (brave://version info)

Brave | 1.20.103 Chromium: 88.0.4324.152 (Official Build) (64-bit)
Revision | 6579930fc53b4dc589c042bec9d0a3778326974d-refs/branch-heads/4324@{#2106}
OS | Windows 10 OS Version 2009 (Build 19042.804)

Version/Channel Information:

I have not tested with beta or nightly versions.

Other Additional Information:

Miscellaneous Information:

Using a random extension for the same functionality works as intended.

@LanceTrahan
Copy link

LanceTrahan commented Feb 20, 2021

I can confirm this is also occurs on Mac OS Mojave. It's been going on ever since I recently switched to the browser (love it by the way) and had just gotten fed up with this bug and was about to post an issue until I found this recent post.

Hope it can be fixed soon. It's annoying when I have a number of youtube videos tabbed but jump away and then mistakenly jump to the wrong tab and have a video I wasn't ready to start watching yet start playing.

EDIT: The worst part is Brave shows up in the address bar that autoplay was blocked from playing video for the tab, but clearly it was not blocked.

@rebron
Copy link
Collaborator

rebron commented Mar 1, 2021

@BraveSauce @LanceTrahan
Is this what you have in Settings? I tried on Windows and macOS and with these settings, I have to select the play button on the video and autoplay blocking is working.

I'm also on our latest 1.20.110.

Screen Shot 2021-03-01 at 1 48 16 PM

@LanceTrahan
Copy link

@rebron I'm on the same version with the same exact settings and opening a new YouTube tab from an existing YouTube tab causes them to play as soon as you click over to one of the new tabs that was opened. I've also tried it with Block enabled and with the explicit block setting set for the youtube.com site.

@BraveSauce
Copy link
Author

@BraveSauce @LanceTrahan
Is this what you have in Settings? I tried on Windows and macOS and with these settings, I have to select the play button on the video and autoplay blocking is working.

I'm also on our latest 1.20.110.

Screen Shot 2021-03-01 at 1 48 16 PM

Yes, these are my settings. Of course I experimented with different combinations such as a global block without site specific settings and a global allow with specific block for youtube.

Please make sure to test while opening videos in new tabs, as the issue only occurs there.

@rebron
Copy link
Collaborator

rebron commented Mar 2, 2021

cc: @LaurenWags I may need some help here reproducing. I can't get YouTube to autoplay when blocked.

@BraveSauce @LanceTrahan A couple more things, this one might not matter but are you logged-in to YouTube? Any extensions you have running that you think might conflict?

@LanceTrahan
Copy link

@rebron I'm logged into YouTube. Besides the Brave Shields being active, I'm only running a dark mode reader extension (which is disabled for YouTube as it has built-in dark mode) and OneTab to condense my tabs down when they get too numerous.

@LanceTrahan
Copy link

@rebron Did a short record of me experiencing the issue. It was also occurring when logged out of YouTube as well.

brave-youtube-autoplay-issue.mp4

@BraveSauce
Copy link
Author

BraveSauce commented Mar 2, 2021

@rebron I tried in a sandbox with no extensions, signed out. Exactly the same behavior.

The video above is the exact issue I'm having, the video opened in a new tab starts playing automatically, even with the icon showing that it has been blocked.

Update: I'm sorry, I wasn't trying clean after all. It turns out that UBlock Origin extension is the issue in my case.

@LanceTrahan
Copy link

Update: I'm sorry, I wasn't trying clean after all. It turns out that UBlock Origin extension is the issue in my case.

@rebron
I'm not using uBlock Origin because Brave's Shields has become a suitable replacement for it in my mind. I've tried the process again with all of my extensions disabled just to be 100% sure and still encountered the issue.

@rebron rebron added feature/autoplay feature/settings priority/P3 The next thing for us to work on. It'll ride the trains. labels Mar 2, 2021
@rebron
Copy link
Collaborator

rebron commented Mar 2, 2021

@darkdh Looks like we're still running into an issue on YouTube for autoplay.

@LaurenWags
Copy link
Member

@rebron I can reproduce this issue, here are my STR:

  1. Clean profile
  2. Open settings, navigate to brave://settings/content/autoplay
  3. Set Autoplay to blocked
  4. Open new tab, navigate to youtube
  5. Do a search
  6. Open a video in a new tab (right click > Open in new tab, I also tried cmd + click on the link)
  7. When you click on the tab, the video starts to play and URL bar shows the blocked icon

Screen Shot 2021-03-02 at 3 27 34 PM

Brave | 1.21.71 Chromium: 89.0.4389.72 (Official Build) (x86_64)
-- | --
Revision | 3f345f156bfd157bd1bea06310e55f3fb2490359-refs/branch-heads/4389@{#1393}
OS | macOS Version 10.15.7 (Build 19H512)

@LanceTrahan
Copy link

LanceTrahan commented Mar 3, 2021

@rebron Just another observation. This seems particular to YouTube as I tried doing this for video pages on BitChute and Dailymotion and could not reproduce the issue.

EDIT: Also tried videos on Vimeo and had the same issues as on YouTube. That includes global block and adding a specific block for Vimeo.

@ardunster
Copy link

Just found this thread as I also have this issue. Very annoying. So far Brave is the only acceptable ad blocking solution I've found on youtube on my Mac, but I really don't like the video autoplaying if I happen to close the tab that was in front of it, or click to the wrong tab, etc.

As others have stated, the problem only occurs with a video that was loaded in a new tab that I haven't clicked on yet. (It DID not occur on tabs created that way, but not accessed until after I reloaded the browser from the last update.)

@Legion99A
Copy link

Can confirm this issue. Exactly as described in OP, very annoying and needs fixing ASAP.

Brave Version 1.24.86. Linux Mint x 2 and Windows 10 x 2.

@RizzeKnight
Copy link

RizzeKnight commented Sep 26, 2021

Just created my account especially for the Brave browser, which I sincerely hope will succeed (even more / long term) - it's simply the best principles out there of any browser, right now (imho). Looking to add my experiences (getting annoyed) with autoplay blocking actually TOO much, but could not resist attempting a repro here.

Is this issue still relevant, has it maybe been patched away already? Nearly 6 months old now...

Tried and was unable to repro it on my Win10 machine with Autoplay 'blocked' (and global Shields UP btw).
Depending on the global Autoplay setting, either all media is blocked from playing automatically, or all is allowed. Also (YT or other) content in new tabs is either played or blocked, accordingly. So again, repro 0% for me.
Would also like to know whatever specifics are triggering this odd behavior for some users.

EDIT: also seeing the video and at least 1 comment above, maybe Mac (and Linux?) specific? But OP was Win10 as well? Very strange difference...

EDIT2: no, BraveSauce was the Win10 OP and he found the issue on his end in a plugin on 2 March

Update: I'm sorry, I wasn't trying clean after all. It turns out that UBlock Origin extension is the issue in my case.

So, maybe the issue IS actually OS specific. At the very least, checking your plugins (inter)acting strangely with the browser should be priority here, though.

In general, the Autoplay blocker does seem to be very nice and aggressive, so please try to maintain this (and THANK you :P)!

@life777eternal
Copy link

life777eternal commented Nov 14, 2021

Blocking Autoplay on Bitchute.com isn't working. Also I just opened two youtube videos that someone on FB sent to me, and the autoplay on the second one that I opened wasn't blocked. Even though the blocked autoplay icon is showing at the top. The autoplay is not blocked when I reload the video from the original tab that was opened form FB. Though it is blocked when opening the link from below.

https://youtube.com/watch?v=-1c9EAiXL-M

https://youtube.com/watch?v=qSiaMEVWvfI

@spylogsster
Copy link

cannot reproduce with mentioned steps, can someone take a look too @brave/qa-team

@MadhaviSeelam
Copy link

@spylogsster Not able to reproduce using STR above in Win 11 x64

Brave | 1.42.97 Chromium: 104.0.5112.102 (Official Build) (64-bit)
-- | --
Revision | 8e5396254975ef939f2ef7d0bd334e48a052b536-refs/branch-heads/5112@{#1478}
OS | Windows 11 Version 21H2 (Build 22000.856)

@rebron
Copy link
Collaborator

rebron commented Aug 19, 2022

@spylogsster I'm not able to reproduce either using the following these steps: #14266 (comment)

Brave 1.42.97 Chromium: 104.0.5112.102 (Official Build) (arm64)
Revision 8e5396254975ef939f2ef7d0bd334e48a052b536-refs/branch-heads/5112@{#1478}
OS macOS Version 13.0 (Build 22A5321d)
JavaScript V8 10.4.132.22
User Agent Mozilla/5.0 (Macintosh; Intel Mac OS X 10_15_7) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/104.0.5112.102 Safari/537.36

I'm going to close this one out as this looks fixed from likely a prior autoplay fix.

We can reopen if folks in this issue are still encountering the problem.

@rebron rebron removed the priority/P3 The next thing for us to work on. It'll ride the trains. label Aug 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

10 participants