Use brave download link and brave link from "brave://flags" for stable/beta release #1422

GeetaSarvadnya · 2018-10-04T14:34:06Z

Description

Dev channel link under "Chrome://flags" is redirecting to chrome download page. Dev channel link needs to removed from the chrome flags page.

Steps to Reproduce

Open Brave beta
Navigate to "Chrome://flags"
Click on "dev channel" link

Actual result:

dev channel link is redirecting to "Download Chrome for Windows" page.

Expected result:

Our dev channel link should be used from the brave://flags page for beta channel
and our beta channel link should be used from the brave://flags page for stable channel.

Reproduces how often:

Always

Brave version (chrome://version info)

Brave	0.55.10 Chromium: 70.0.3538.22 (Official Build) beta (64-bit)
Revision	ac9418ba9c3bd7f6baaffa0b055dfe147e0f8364-refs/branch-heads/3538@{#468}
OS	Windows

Reproducible on current release:

Does it reproduce on brave-browser dev/beta builds? NA
Does it reproduce on browser-laptop? NA

Website problems only:

Does the issue resolve itself when disabling Brave Shields? NA
Is the issue reproducible on the latest version of Chrome? NA

Additional Information

cc @bbondy

kjozwiak · 2018-10-05T05:37:08Z

Nice catch @GeetaSarvadnya 👍BTW, this is only reproducible on the 0.55.x and not 0.56.x.

0.56.2 Chromium: 70.0.3538.35 - not reproducible/link seems to be removed from the top
0.55.11 Chromium: 70.0.3538.35 - Reproducible

kjozwiak · 2018-12-18T19:34:04Z

Quick example of the issue @GeetaSarvadnya mentioned above:

Used the following build:

Brave	0.58.14 Chromium: 71.0.3578.98 (Official Build) (64-bit)
Revision	15234034d19b85dcd9a03b164ae89d04145d8368-refs/branch-heads/3578@{#897}
OS	Mac OS X

jonathansampson · 2019-01-30T19:14:05Z

Still an issue. Came here after noticing it myself.

rebron · 2019-03-13T20:57:51Z

This is still showing on release channel: 0.61.51 Chromium: 73.0.3683.75
Interested in cool new Chrome features? Try our beta channel.

and beta channel: 0.62.25 Chromium: 73.0.3683.67
Interested in cool new Chrome features? Try our dev channel

rebron · 2019-03-13T20:59:29Z

We can just hide the whole line for all channels but especially for release channel.
If we do keep in beta channel link should be: https://brave.com/download-beta/
and for dev channel should be: https://brave.com/download-dev/

Although dev channel doesn't have the text at all.

fix brave/brave-browser#1422

bsclifton · 2020-05-12T06:52:56Z

Re-opening after revert was done with brave/brave-core#5521
cc: @simonhong

btlechowski · 2020-05-26T02:11:53Z

edit: description and test plan changed and the issue is not applicable to Linux.

simonhong · 2020-05-26T05:10:54Z

@btlechowski This issue is not for linux. Originally, flags page in linux doesn't have dev channel link in beta release and beta channel link in stable release. Only mac/windows has channel link.
So, fixes for this issue don't make any difference for linux.

#if defined(OS_WIN) || defined(OS_MACOSX) || defined(OS_CHROMEOS)
  version_info::Channel channel = chrome::GetChannel();
  results.SetBoolean(
      flags_ui::kShowBetaChannelPromotion,
      channel == version_info::Channel::STABLE && !deprecated_features_only_);
  results.SetBoolean(
      flags_ui::kShowDevChannelPromotion,
      channel == version_info::Channel::BETA && !deprecated_features_only_);
#else
  results.SetBoolean(flags_ui::kShowBetaChannelPromotion, false);
  results.SetBoolean(flags_ui::kShowDevChannelPromotion, false);
#endif

GeetaSarvadnya · 2020-05-26T10:11:07Z

Verification passed on

Brave | 1.10.71 Chromium: 81.0.4044.138 (Official Build) dev (64-bit)
-- | --
Revision | 8c6c7ba89cc9453625af54f11fd83179e23450fa-refs/branch-heads/4044@{#999}
OS | Windows 10 OS Version 1803 (Build 17134.1006)

Reproduce the issue in 1.9.x, click on beta channel in chrome://flags is redirecting to download chrome page
Verified the STR from the description
Verified that dev channel link is not shown in chrome://flags page

simonhong · 2020-05-26T10:41:14Z

@GeetaSarvadnya My PR that resolves this issues is brave/brave-core#4601.
That PR replaced chrome branding and chrome link with brave branding and brave link instead of removing chrome link. This issue should be updated.

And, chrome link was only visible by stable and beta release.
In stable release, Interested in cool new Brave features? Try our beta channel. will be used.
In beta release, Interested in cool new Brave features? Try our dev channel..
And other channel (dev/nightly) don't have this link.

simonhong · 2020-05-26T10:44:10Z

Description and issue title are updated. Sorry for late update.
Forgot to update when I work on this issue :)

btlechowski · 2020-05-26T15:46:15Z

Deleted QA Pass-Win64 as based on #1422 (comment) this issue needs to be tested on Beta and Release channels.

LaurenWags · 2020-05-27T14:35:17Z

Verification passed using:

Nightly:

Brave | 1.11.28 Chromium: 81.0.4044.138 (Official Build) nightly (64-bit)
-- | --
Revision | 8c6c7ba89cc9453625af54f11fd83179e23450fa-refs/branch-heads/4044@{#999}
OS | macOS Version 10.14.6 (Build 18G3020)

Per Use brave download link and brave link from "brave://flags" for stable/beta release #1422 (comment), confirmed brave://flags on Nightly does not have the link mentioned:

Dev:

Brave | 1.10.74 Chromium: 81.0.4044.138 (Official Build) dev (64-bit)
-- | --
Revision | 8c6c7ba89cc9453625af54f11fd83179e23450fa-refs/branch-heads/4044@{#999}
OS | macOS Version 10.14.6 (Build 18G3020)

Per Use brave download link and brave link from "brave://flags" for stable/beta release #1422 (comment), confirmed brave://flags on Dev does not have the link mentioned:

Beta:

Brave | 1.10.73 Chromium: 81.0.4044.138 (Official Build) beta (64-bit)
-- | --
Revision | 8c6c7ba89cc9453625af54f11fd83179e23450fa-refs/branch-heads/4044@{#999}
OS | macOS Version 10.14.6 (Build 18G3020)

Per Use brave download link and brave link from "brave://flags" for stable/beta release #1422 (comment), confirmed brave://flags on Beta does have the link mentioned:

However, link is pointing to https://brave.com/download-beta/ but I'm already using Beta. We should perhaps use another link for this - either Dev (as the link text says) or Nightly. Logged follow up issue for this: #9968

Release:

Brave | 1.10.86 Chromium: 83.0.4103.61 (Official Build) (64-bit)
-- | --
Revision | 94f915a8d7c408b09cc7352161ad592299f384d2-refs/branch-heads/4103@{#561}
OS | macOS Version 10.14.6 (Build 18G3020)

Per Use brave download link and brave link from "brave://flags" for stable/beta release #1422 (comment), confirmed brave://flags on Release channel does have the link mentioned:

Confirmed link is pointing to https://brave.com/download-beta/ and clicking on the link opens the expected page.

Verification passed on

Beta

Brave | 1.10.85 Chromium: 81.0.4044.138 (Official Build) beta (64-bit)
-- | --
Revision | 8c6c7ba89cc9453625af54f11fd83179e23450fa-refs/branch-heads/4044@{#999}
OS | Windows 10 OS Version 1803 (Build 17134.1006)

Per Use brave download link and brave link from "brave://flags" for stable/beta release #1422 (comment), confirmed brave://flags on Beta does have the link mentioned:

Encountered [Desktop] update link/link text on brave://flags in Beta channel to promote Nightly - follow up to 1422 #9968

Release


Brave | 1.10.86 Chromium: 83.0.4103.61 (Official Build) (64-bit)
-- | --
Revision | 94f915a8d7c408b09cc7352161ad592299f384d2-refs/branch-heads/4103@{#561}
OS | Windows 10 OS Version 1803 (Build 17134.1006)

Per Use brave download link and brave link from "brave://flags" for stable/beta release #1422 (comment), confirmed brave://flags on Release does have the link mentioned:

Verified Dev and Nightly channel, as per the Use brave download link and brave link from "brave://flags" for stable/beta release #1422 (comment), confirmed brave://flags on Dev and Nightly doesn't have the link mentioned:

GeetaSarvadnya added bug about-pages/rebrand Rebranding work on top of Chrome's Polymer-powered pages labels Oct 4, 2018

GeetaSarvadnya added this to the 1.x Backlog milestone Oct 4, 2018

kjozwiak added QA/Yes QA/Test-Plan-Specified labels Oct 4, 2018

rebron added the priority/P5 Not scheduled. Don't anticipate work on this any time soon. label Oct 5, 2018

rebron added priority/P3 The next thing for us to work on. It'll ride the trains. and removed priority/P5 Not scheduled. Don't anticipate work on this any time soon. labels Dec 18, 2018

rebron modified the milestone: 1.x Backlog Feb 7, 2019

rebron assigned mkarolin Feb 12, 2019

rebron unassigned mkarolin Jun 4, 2019

simonhong self-assigned this Feb 12, 2020

simonhong added this to the 1.6.x - Nightly milestone Feb 12, 2020

simonhong added a commit to brave/brave-core that referenced this issue Feb 12, 2020

Use brave download line and Brave brand in brave://flags for download

c54e479

fix brave/brave-browser#1422

simonhong mentioned this issue Feb 12, 2020

Use brave download link and Brave brand in brave://flags for download brave/brave-core#4601

Merged

32 tasks

simonhong added a commit to brave/brave-core that referenced this issue May 6, 2020

Use brave download line and Brave brand in brave://flags for download

a395c25

fix brave/brave-browser#1422

simonhong closed this as completed in brave/brave-core#4601 May 6, 2020

rebron added the release-notes/exclude label May 7, 2020

bsclifton reopened this May 12, 2020

bsclifton removed this from the 1.10.x - Nightly milestone May 12, 2020

simonhong mentioned this issue May 12, 2020

Replace chrome link with brave link from "chrome://flags brave/brave-core#5526

Merged

32 tasks

simonhong added this to the 1.10.x - Nightly milestone May 13, 2020

simonhong closed this as completed in brave/brave-core#5526 May 14, 2020

btlechowski added the QA Pass-Linux label May 26, 2020

GeetaSarvadnya added QA Pass-Win64 OS/macOS OS/Windows and removed QA Pass-Linux labels May 26, 2020

simonhong changed the title ~~Remove chrome link from "chrome://flags"~~ Use brave download link and brave link from "brave://flags" for stable/beta release May 26, 2020

btlechowski removed the QA Pass-Win64 label May 26, 2020

LaurenWags mentioned this issue May 27, 2020

[Desktop] update link/link text on brave://flags in Beta channel to promote Nightly - follow up to 1422 #9968

Closed

GeetaSarvadnya added the QA Pass-Win64 label Jun 8, 2020

LaurenWags added the QA Pass-macOS label Jun 8, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Use brave download link and brave link from "brave://flags" for stable/beta release #1422

Use brave download link and brave link from "brave://flags" for stable/beta release #1422

GeetaSarvadnya commented Oct 4, 2018 •

edited by simonhong

Loading

kjozwiak commented Oct 5, 2018 •

edited

Loading

kjozwiak commented Dec 18, 2018 •

edited

Loading

jonathansampson commented Jan 30, 2019

rebron commented Mar 13, 2019

rebron commented Mar 13, 2019

bsclifton commented May 12, 2020

btlechowski commented May 26, 2020 •

edited

Loading

simonhong commented May 26, 2020 •

edited

Loading

GeetaSarvadnya commented May 26, 2020

simonhong commented May 26, 2020

simonhong commented May 26, 2020 •

edited

Loading

btlechowski commented May 26, 2020

LaurenWags commented May 27, 2020 •

edited

Loading

Use brave download link and brave link from "brave://flags" for stable/beta release #1422

Use brave download link and brave link from "brave://flags" for stable/beta release #1422

Comments

GeetaSarvadnya commented Oct 4, 2018 • edited by simonhong Loading

Description

Steps to Reproduce

Actual result:

Expected result:

Reproduces how often:

Brave version (chrome://version info)

Reproducible on current release:

Website problems only:

Additional Information

kjozwiak commented Oct 5, 2018 • edited Loading

kjozwiak commented Dec 18, 2018 • edited Loading

jonathansampson commented Jan 30, 2019

rebron commented Mar 13, 2019

rebron commented Mar 13, 2019

bsclifton commented May 12, 2020

btlechowski commented May 26, 2020 • edited Loading

simonhong commented May 26, 2020 • edited Loading

GeetaSarvadnya commented May 26, 2020

simonhong commented May 26, 2020

simonhong commented May 26, 2020 • edited Loading

btlechowski commented May 26, 2020

LaurenWags commented May 27, 2020 • edited Loading

GeetaSarvadnya commented Oct 4, 2018 •

edited by simonhong

Loading

kjozwiak commented Oct 5, 2018 •

edited

Loading

kjozwiak commented Dec 18, 2018 •

edited

Loading

btlechowski commented May 26, 2020 •

edited

Loading

simonhong commented May 26, 2020 •

edited

Loading

simonhong commented May 26, 2020 •

edited

Loading

LaurenWags commented May 27, 2020 •

edited

Loading