-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove patches/chrome-browser-profiles-profile_io_data.cc.patch #14238
Comments
Miscellaneous Information:For QA purposes: this cleanup touched code added to fix bugs #2861 and #2849, so please make sure behaviour remains the same. There is a test plan in the associated PR in brave/brave-core#1196 |
The idea of this patch was simply to make sure that the brave:// scheme gets considered by ProfileIOData::IsHandledProtocol() along with other schemes, but we can achieve the same goal just using chromium_src overrides, so let's do that instead. Fixes brave/brave-browser#14238
The idea of this patch was simply to make sure that the brave:// scheme gets considered by ProfileIOData::IsHandledProtocol() along with other schemes, but we can achieve the same goal just using chromium_src overrides, so let's do that instead. Fixes brave/brave-browser#14238
Verified
Test 1: Confirmed that Test 2: Navigate to The above testcase was for previous UI; I instead used the 3rd page in Verified that it opened
Test 3: Open I confirmed via #brave-core in Slack that this is also outdated UI; @simonhong confirmed that the new test is actually to make sure that Verified that right-clicking and choosing
|
Verification passed on OnePlus 6T with Android 10 running 1.22.54 x64 beta build
Verification passed on Samsung Tab A with Android 10 running 1.22.54 x64 beta build
|
Description
The idea of this patch is simply to make sure that the
brave://
scheme gets considered byProfileIOData::IsHandledProtocol()
along with other schemes, but we can achieve the same goal just using chromium_src overrides, so let's do that instead.Desktop Brave version:
Brave 1.22.28 (Chromium 89.0.4389.48)
Miscellaneous Information:
For QA purposes: this cleanup touched code added to fix bugs #2861 and #2849, so please make sure behaviour remains the same.
There is a test plan in the associated PR in brave/brave-core#1196
The text was updated successfully, but these errors were encountered: