Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing translations for onboarding modal on first launch #14309

Closed
srirambv opened this issue Feb 23, 2021 · 2 comments
Closed

Missing translations for onboarding modal on first launch #14309

srirambv opened this issue Feb 23, 2021 · 2 comments
Labels
closed/duplicate Issue has already been reported

Comments

@srirambv
Copy link
Contributor

Description

Missing translations for onboarding modal on first launch

Steps to Reproduce

  1. Set locale to France (FR)
  2. Install 1.21.65 x64 beta build
  3. Launch browser, trigger onboarding modal that is not translated

Actual result:

image

Expected result:

Translated strings when locale is not EN

Reproduces how often:

Easy

Brave version (brave://version info)

Brave 1.21.62 Chromium: 88.0.4324.182 (Official Build) beta (64-bit)
Revision 73ee5087001dcef33047c4ed650471b225dd8caf-refs/branch-heads/4324@{#2202}
OS Linux

Version/Channel Information:

  • Can you reproduce this issue with the current release? NA
  • Can you reproduce this issue with the beta channel? Yes
  • Can you reproduce this issue with the nightly channel? Yes

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields? NA
  • Does the issue resolve itself when disabling Brave Rewards? NA
  • Is the issue reproducible on the latest version of Chrome? NA

Miscellaneous Information:

cc: @rebron @mkarolin

@srirambv srirambv added l10n QA/Yes release-notes/exclude onboarding Front-end related to helping a new user learn about features within the browser. OS/Desktop labels Feb 23, 2021
@rebron rebron added the priority/P2 A bad problem. We might uplift this to the next planned release. label Feb 23, 2021
@rebron rebron self-assigned this Feb 23, 2021
@btlechowski
Copy link

Dupe of #14163

@srirambv
Copy link
Contributor Author

Thanks for linking @btlechowski . Closing as dupe of #14163

@srirambv srirambv added closed/duplicate Issue has already been reported and removed OS/Desktop QA/Yes l10n onboarding Front-end related to helping a new user learn about features within the browser. priority/P2 A bad problem. We might uplift this to the next planned release. release-notes/exclude labels Feb 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
closed/duplicate Issue has already been reported
Projects
None yet
Development

No branches or pull requests

3 participants