Brave shields are not working properly

[JohnnyX071]

Since the last brave update, YouTube ads started showing up even though shields are on. I even tried putting them on aggressive but still. There are no steps to reproduce, it always happens. You can see some screenshots

I am using brave Version 1.21.73

[FoxMcloud5655]

I have this same issue. Likely, Google found a way to bypass it and Brave will have to find another way of blocking it. Unfortunately an endless cycle...

I tried blocking the entire element directly and it works until the page is refreshed.

[alekny]

Same for me, as well as custom filters stopped working completely. You can add objects via rightclick->block and after a page refresh they are all back.

[ff2000]

Same issue here.
Firefox with uBlock origin blocks the ads with no issue.

[ryanbr]

The above screenshot is just cosmetic issue, see #11955 @JohnnyX071

Unless it's another issue with youtube?

[JohnnyX071]

The above screenshot is just cosmetic issue, see #11955 @JohnnyX071

Unless it's another issue with youtube?

It's not just that, I get ads on some videos too but I don't have screenshot for that

[ff2000]

Ad in a video:

And when the video starts an ad pops on top of the video list:

I have set aggressive blocking.

[tnup]

same as @ff2000 said.

Version 1.21.73 Chromium: 89.0.4389.72 (Official Build) (64-bit)

[stephendonner]

A good repro case to see the Skip Ads overlay— at least on nightly (and 1.21.73) — is to:

1. sign in with a non-Premium account
2. load a video
3. click a video on the right from the suggested list
4. click back
5. now click forward

[LaurenWags]

Able to reproduce issue from #14471 (comment) a few times using the below steps, but it was not consistent:

1. Clean profile
2. Navigate to youtube.com
3. Login
4. View a couple of videos (either in the same tab or open video in a new tab)
5. Go back to youtube.com
6. Right click on tab and select "Duplicate"
7. Do step 6 a few times, one of the times you will get an "Ad" video in the first slot, other times it is blank

Brave | 1.21.73 Chromium: 89.0.4389.72 (Official Build) (x86_64)
-- | --
Revision | 3f345f156bfd157bd1bea06310e55f3fb2490359-refs/branch-heads/4389@{#1393}
OS | macOS Version 10.15.7 (Build 19H512)

[FoxMcloud5655]

That's because YouTube doesn't show an ad every single time, but yes, this is reproducible; can confirm.

[stephendonner]

With both nightly and 1.21.73: I should also mention another use-case, where, instead of ads, I see a blank/empty region (where others are seeing the ad, as already mentioned).

1. log in to non-Premium account
2. load youtube.com

I see a placeholder on the top-left spot, instead:

[stephendonner]

There's also ads on nightly in the search-results page, where I don't see them using 1.19.88:

1. log in to non-Premium account on `youtube.com
2. search for, e.g. a car (lexus is 350): https://www.youtube.com/results?search_query=lexus+is+350
3. look at the results page

1.19.98	nightly

[LaurenWags]

Verified passed with

Brave	1.21.74 Chromium: 89.0.4389.72 (Official Build) (64-bit)
Revision	3f345f156bfd157bd1bea06310e55f3fb2490359-refs/branch-heads/4389@{#1393}
OS	Linux

Reproduced issue originally reported under #14471 (comment) with 1.21.73. Was unable to reproduce using 1.21.74 after fix was applied using steps from #14471 (comment).

1.21.73	1.21.74

---

Verified PASSED with

Brave	1.21.74 Chromium: 89.0.4389.72 (Official Build) (x86_64)
Revision	3f345f156bfd157bd1bea06310e55f3fb2490359-refs/branch-heads/4389@{#1393}
OS	macOS Version 11.2.2 (Build 20D80)

Used the steps to reproduce in #14471 (comment) and was able to see the issue using 1.21.73; updating to 1.21.74, I was no longer able to reproduce the original issue either.

1.21.73	1.21.74

[beatschubser]

spiegel.de was full of ads with 1.21.73. Looks good again on 1.21.74. Thank you!

[ff2000]

Just updated to 1.21.77 and ads are back.

[kjozwiak]

@ff2000 which website where you seeing ads on? Would it be possible for you to add a screenshot? There's a few issues that we're aware of regarding a race condition in the cosmetic filter where sometimes ads will get through due to the script loading either too late or too early. Refreshing usually removes them. We're close to having a fix which will be deployed in Nightly first.

However, if you're seeing something different and the ads appearing all the time, let us know the website and we'll take a look/address it 👍

[ScamCast]

This is somewhat still an issue. The ad is blocked but leaves an empty space because of the parent "ytd-rich-item-renderer" element styling. That element would need to be hidden if it contains the "ytd-display-ad-renderer" element.

[ff2000]

@ff2000 which website where you seeing ads on? Would it be possible for you to add a screenshot? There's a few issues that we're aware of regarding a race condition in the cosmetic filter where sometimes ads will get through due to the script loading either too late or too early. Refreshing usually removes them. We're close to having a fix which will be deployed in Nightly first.

However, if you're seeing something different and the ads appearing all the time, let us know the website and we'll take a look/address it

Today came another update. After restarting I got ads again. I didn't respond earlier because I wanted to wait for this update to verify my suspicion.

• I closed brave with youtube being the active tab.
• I updated brave
• I restarted brave
• The youtube tab loads and immediately shows an ad overlay - sometimes with an ad running, sometimes just a plain white overlay.
• For some time I get in-video ads and the ad in the top left box on the youtube home page.
• At some point ad blocking works again. I can't say ATM what exactly fixed the ad blocker.

So my issue might be unrelated but connected to updating brave.