Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add rounded corners to macOS/Linux custom ad notifications #14809

Closed
tmancey opened this issue Mar 18, 2021 · 2 comments
Closed

Add rounded corners to macOS/Linux custom ad notifications #14809

tmancey opened this issue Mar 18, 2021 · 2 comments

Comments

@tmancey
Copy link
Contributor

tmancey commented Mar 18, 2021

No description provided.

@tmancey tmancey added enhancement OS/macOS priority/P3 The next thing for us to work on. It'll ride the trains. QA/Yes feature/ads OS/Desktop labels Mar 18, 2021
@tmancey tmancey self-assigned this Mar 18, 2021
@tmancey tmancey changed the title Add rounded corners to macOS custom ad notifications Add rounded corners to macOS/Linux custom ad notifications Apr 29, 2021
@tmancey
Copy link
Contributor Author

tmancey commented Apr 29, 2021

Resolved as part of #13132, please test as part of the new custom ad notifications

@tmancey tmancey closed this as completed Apr 29, 2021
@tmancey tmancey added this to the 1.26.x - Nightly milestone Apr 29, 2021
@stephendonner
Copy link

stephendonner commented May 5, 2021

Verified PASSED on macOS using

Brave 1.26.7 Chromium: 90.0.4430.93 (Official Build) nightly (x86_64)
Revision 4df112c29cfe9a2c69b14195c0275faed4e997a7-refs/branch-heads/4430@{#1348}
OS macOS Version 11.3.1 (Build 20E241)

and compared to:

Brave 1.25.43 Chromium: 90.0.4430.85 (Official Build) nightly (x86_64)
Revision 5bc145d831c180d9ff94f29a0d7a2e1cbd30ef36-refs/branch-heads/4430@{#1311}
OS macOS Version 11.3.1 (Build 20E241)

Steps:

  1. new profile
  2. launched with --enable-logging=stderr --vmodule="*/bat-native-ledger/*"=6,"*/brave_rewards/*"=6,"*/bat-native-ads/*"=6,"*/bat-native-confirmations/*"=6,"*/brave_ads/*"=9,"*/brave_user_model/*"=6 --brave-ads-staging --brave-ads-debug --rewards=staging=true,reconcile-interval=5
  3. clicked through the Welcome page
  4. enabled Rewards
  5. opened a few new-tab pages
  6. waited
  7. confirmed I got the system notification for ads
rounded, ads staging (1.26.7) rounded, ads prod (1.26.7) square, ads staging (1.25.43) square, ads prod (1.25.43)
Screen Shot 2021-05-05 at 1 20 00 PM Screen Shot 2021-05-05 at 1 24 05 PM Screen Shot 2021-05-05 at 1 33 52 PM Screen Shot 2021-05-05 at 1 37 07 PM

Verification passed on

Brave 1.26.45 Chromium: 91.0.4472.77 (Official Build) beta (64-bit)
Revision 1cecd5c8a856bc2a5adda436e7b84d8d21b339b6-refs/branch-heads/4472@{#1246}
OS Ubuntu 18.04 LTS

Verified that ads have rounded corners on Linux

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

No branches or pull requests

4 participants