Implement new custom ad notification design #13132

tmancey · 2020-12-10T08:01:02Z

tmancey · 2021-03-12T11:52:44Z

Discuss browser theme (light/dark), animations and overall design across desktop and mobile

GeetaSarvadnya · 2021-06-08T09:32:53Z

Verification passed on

<!--StartFragment-->
Brave | 1.26.50 Chromium: 91.0.4472.77&nbsp;(Official Build)&nbsp;beta&nbsp;(64-bit)
-- | --
Revision | 1cecd5c8a856bc2a5adda436e7b84d8d21b339b6-refs/branch-heads/4472@{#1246}
OS | Windows&nbsp;10 OS Version 2004 (Build 19041.985)

<!--EndFragment-->

Verified the test plan from Implement new custom ad notification design brave-core#8377

Confirmed custom Ad notifications are shown

Confirmed users are rewarded for viewing ads

[11320:14312:0608/143904.884:VERBOSE1:confirmations.cc(248)] Successfully redeemed unblinded token with confirmation id 95b67c23-8f1a-4296-9c3d-0020f459e744, creative instance id 4983dc92-09fd-4e5c-94c3-616a4728c1d9 and view
[11320:14312:0608/143904.886:VERBOSE1:confirmations.cc(271)] Added 1 unblinded payment token with an estimated redemption value of 0.01 BAT, you now have 1 unblinded payment tokens

Confirmed custom Ads can be dragged on desktop

Encountered #16241

Confirmed Test ad notifications are shown in the same position after restarting the browser on desktop only, i.e. after dragging an ad notification

Example	Example	Example

Test ad notifications are shown correctly for dark mode, Light mode and same as window

Light mode	Dark mode	Same as window

Confirmed ad notifications can be dragged to multiple displays/resolutions on desktop only
https://drive.google.com/file/d/19TJr7put6p30ltKm8wqQWxTXLGCllBYq/view?usp=sharing

Confirmed Test ad notifications cannot be dragged underneath the Task Bar or system tray on Windows

Confirmed Test ad notifications are realigned if the user repositions the Task Bar on Windows

Verification passed on

Brave	1.26.53 Chromium: 91.0.4472.77 (Official Build) beta (64-bit)
Revision	1cecd5c8a856bc2a5adda436e7b84d8d21b339b6-refs/branch-heads/4472@{#1246}
OS	Ubuntu 18.04 LTS

Verified the test plan from brave/brave-core#8377
Verification performed in #13137 (comment), #15624 (comment), #14810 (comment), #14811 (comment), #14813 (comment), #16024 (comment)

Also verified ads history in brave://rewards. Verified the ads are added to the history.

Verified custom ad is shown

Verified Ads received this month is increased by 1 and Estimated pending rewards is increased

Verified the ad is listed in ads history. Verified the ad status is viewed

Verified that after the ad was clicked, the status in of the ad in ads history changed to clicked

Verified 2nd custom ad was shown. Verified Ads received this month is increased by 1 and Estimated pending rewards is increased

Verified the ad is listed in ads history. Verified the ad status is viewed

Verified that after the ad was closed, the status in of the ad in ads history changed to dismissed

Also Verified ads per hour setting

Verified able to change ads per hour setting in brave://rewards

Verified ads per hour setting is respected (1 ad per hour)
First ad shown at 22:33:18

[25877:25877:0608/223318.231204:VERBOSE1:ad_notification_serving.cc(105)] Ad notification delivered:
  uuid: 30361f40-0e9d-4a82-8e1c-7bbfbbac9744
  creativeInstanceId: 7898a259-664a-4052-8382-9c7279ae3249
  creativeSetId: 5e96fecc-2926-4c72-bb76-4e745bf6b539
  campaignId: 0d01425b-c970-4a25-b2d0-ccf748cfaf6e
  advertiserId: ecbcc833-8b1d-4867-98f7-ad2341396ce8
  segment: untargeted
  title: Ad Set 2 - Creative 1 - Ad 1
  body: Ad Set 2 - Creative 1 - Ad 1
  targetUrl: https://youtube.com

Attempt to show ad after 55 minutes was not successful as expected

[27037:27037:0608/233117.115308:VERBOSE2:permission_rule_util.cc(23)] You have exceeded the allowed ads per hour
[27037:27037:0608/233117.115397:VERBOSE1:ad_notification_serving.cc(150)] Ad notification not served: Not allowed

Verified ad was shown after 60+ minutes

[27037:27037:0608/233750.757575:VERBOSE1:ad_notification_serving.cc(105)] Ad notification delivered:
  uuid: deed7997-3083-4dcd-875a-7fe58c79934a
  creativeInstanceId: 4cda3ae7-1f70-4bca-b361-ca01d6a8f1ed
  creativeSetId: 5f8c4787-8431-49a5-9d09-bba40f8ad5f4
  campaignId: d1e25388-b362-4f30-bd4b-36b8205e59e5
  advertiserId: a34de75d-5654-4331-8713-8f4d4e2b6bf7
  segment: untargeted
  title: Vivamus sagittis lacus vel aug
  body: Duis mollis, est non commodo luctus, nisi erat porttitor lig
  targetUrl: https://www.apple.com

Verified PASSED using the test plan from brave/brave-core#8377 on build

Brave	1.26.54 Chromium: 91.0.4472.88 (Official Build) beta (x86_64)
Revision	109e9cd038b94a631aea7d40ee3d56c1278f2597-refs/branch-heads/4472@{#1385}
OS	macOS Version 11.4 (Build 20F71)

Verifications performed in #13137 (comment), #15624 (comment), #14810 (comment), #14811 (comment), #14813 (comment), #16024 (comment)

Confirmed users are rewarded for viewing ads:

[33519:259:0607/120838.605574:VERBOSE1:confirmations.cc(248)] Successfully redeemed unblinded token with confirmation id fb94fc45-8c5b-44bd-b613-c4dd730b0b9c, creative instance id 7a49c681-76ee-48ee-a627-1bd80de82854 and view
[33519:259:0607/120838.606180:VERBOSE1:confirmations.cc(271)] Added 1 unblinded payment token with an estimated redemption value of 0.3 BAT, you now have 1 unblinded payment tokens

Verified ads are added to the 7-day Ads History in brave://rewards (with viewed, clicked, dismissed states, some not shown)

Verified Maximum Ads Per Hour setting

1st ad at 4:53pm

[39548:259:0608/165532.651113:VERBOSE1:ad_notification_serving.cc(105)] Ad notification delivered:
  uuid: dfc4f3e7-8ac1-420e-a794-a0c881101fbe
  creativeInstanceId: a0369601-b46f-46aa-93e1-2c9bafda3c35
  creativeSetId: 5e96fecc-2926-4c72-bb76-4e745bf6b539
  campaignId: 0d01425b-c970-4a25-b2d0-ccf748cfaf6e
  advertiserId: ecbcc833-8b1d-4867-98f7-ad2341396ce8
  segment: untargeted
  title: Ad Set 2 - Creative 2 - Ad 2
  body: Ad Set 2 - Creative 2 - Ad 2
  targetUrl: https://youtube.com

2nd ad attempted at 5:46pm

[39548:259:0608/174604.348272:VERBOSE2:permission_rule_util.cc(23)] You have exceeded the allowed ads per hour
[39548:259:0608/174604.348351:VERBOSE1:ad_notification_serving.cc(150)] Ad notification not served: Not allowed
[39548:259:0608/174604.348401:VERBOSE1:ad_notification_serving.cc(91)] Ad notification not delivered

3rd ad at 5:56pm

[39548:259:0608/175612.421873:VERBOSE1:ad_notification_serving.cc(105)] Ad notification delivered:
  uuid: 13a7d998-1316-4a6e-8b5f-d81596cecdff
  creativeInstanceId: 4cda3ae7-1f70-4bca-b361-ca01d6a8f1ed
  creativeSetId: 5f8c4787-8431-49a5-9d09-bba40f8ad5f4
  campaignId: d1e25388-b362-4f30-bd4b-36b8205e59e5
  advertiserId: a34de75d-5654-4331-8713-8f4d4e2b6bf7
  segment: untargeted
  title: Vivamus sagittis lacus vel aug
  body: Duis mollis, est non commodo luctus, nisi erat porttitor lig
  targetUrl: https://www.apple.com

Verified custom-ad notification can be dragged to a multiple-monitor display

MacBook Pro	external LG display

Verified VoiceOver correctly represents the custom-ad notification & its text (apologies: I didn't capture the audio, but confirmed it was read aloud)

GeetaSarvadnya · 2021-06-10T17:22:16Z

Verification passed on Samsung Galaxy Tab version 10 running brave Beta build Bravemonoarm64 1.26.56.apk
Verified the test plan from brave/brave-core#8377

Confirmed custom AD notifications are served in Android
Confirmed custom AD notification are shown correctly in Light mode
Confirmed custom AD notification are shown correctly in Dark mode
Logged Custom ad notifications do not respect dark mode on Android #16350

Custom AD	Light Mode	Dark Mode

Verification passed on OnePlus 6T with Android 10 running 1.26.59 x64 Beta Build

Verified custom ad notifications are shown when args are passed
Verfied custom ads are shown on both light and dark mode
Encountered Custom ad notifications do not respect dark mode on Android #16350

Light Mode	Dark Mode

tmancey added enhancement priority/P3 The next thing for us to work on. It'll ride the trains. QA/Yes release-notes/exclude feature/ads OS/Desktop labels Dec 10, 2020

tmancey changed the title ~~[Ads] Add rounded corners to custom ad notification~~ Implement new custom ad notification design Mar 12, 2021

tmancey mentioned this issue Mar 12, 2021

[Ads] Custom ad notification should visually scale-up/down #13133

Closed

tmancey mentioned this issue Mar 12, 2021

Custom ad notifications should respect browser theme #12910

Closed

tmancey self-assigned this Mar 12, 2021

tmancey mentioned this issue Mar 12, 2021

Change ads image in Custom Notification to a button #11798

Closed

tmancey added Epic and removed Epic labels Mar 18, 2021

tmancey added the Epic label Mar 22, 2021

tmancey mentioned this issue Mar 29, 2021

Implement new custom ad notification design brave/brave-core#8377

Merged

24 tasks

tmancey mentioned this issue Apr 23, 2021

Brave crashes after closing the Ad notification window #15173

Closed

tmancey closed this as completed in brave/brave-core#8377 Apr 29, 2021

tmancey added this to the 1.26.x - Nightly milestone Apr 29, 2021

tmancey added release-notes/include and removed design/needs-mock-up needs-mockup A feature which needs design mockup to be implemented. needs-discussion Although the issue is clear, we haven't yet reached a decision about the right solution. labels Apr 29, 2021

tmancey mentioned this issue Apr 29, 2021

Implement custom ad notification dark mode #14810

Closed

tmancey added the OS/Android Fixes related to Android browser functionality label Apr 29, 2021

tmancey added the QA/Yes label Apr 30, 2021

btlechowski added the QA/Test-All-Platforms label May 28, 2021

GeetaSarvadnya added the QA Pass-Win64 label Jun 8, 2021

btlechowski added the QA Pass-Linux label Jun 8, 2021

stephendonner added the QA Pass-macOS label Jun 9, 2021

GeetaSarvadnya mentioned this issue Jun 10, 2021

Custom ad notifications do not respect dark mode on Android #16350

Closed

GeetaSarvadnya added the QA Pass - Android Tab label Jun 10, 2021

srirambv added the QA Pass - Android ARM label Jun 14, 2021

rebron added release-notes/exclude and removed release-notes/include labels Jun 21, 2021

tmancey added this to Ads Jun 10, 2024

tmancey moved this to Done in Ads Jun 10, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Implement new custom ad notification design #13132

Implement new custom ad notification design #13132

tmancey commented Dec 10, 2020

tmancey commented Mar 12, 2021

GeetaSarvadnya commented Jun 8, 2021 •

edited by stephendonner

Loading

GeetaSarvadnya commented Jun 10, 2021 •

edited by srirambv

Loading

Implement new custom ad notification design #13132

Implement new custom ad notification design #13132

Comments

tmancey commented Dec 10, 2020

tmancey commented Mar 12, 2021

GeetaSarvadnya commented Jun 8, 2021 • edited by stephendonner Loading

GeetaSarvadnya commented Jun 10, 2021 • edited by srirambv Loading

GeetaSarvadnya commented Jun 8, 2021 •

edited by stephendonner

Loading

GeetaSarvadnya commented Jun 10, 2021 •

edited by srirambv

Loading