Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Brave crashes after closing the Ad notification window #15173

Closed
GeetaSarvadnya opened this issue Apr 7, 2021 · 4 comments
Closed

Brave crashes after closing the Ad notification window #15173

GeetaSarvadnya opened this issue Apr 7, 2021 · 4 comments
Assignees
Labels
closed/duplicate Issue has already been reported crash feature/ads OS/Desktop priority/P3 The next thing for us to work on. It'll ride the trains. QA/Test-Plan-Specified QA/Yes regression

Comments

@GeetaSarvadnya
Copy link

GeetaSarvadnya commented Apr 7, 2021

Description

Brave crashes after closing the Ad notification window

Steps to Reproduce

  1. Clean profile 1.24.52
  2. Enable rewards
  3. View an Ad
  4. Close the Ad notification window
    [Note: In 1.22.71 Ad notification popup is shown when Ad is triggered but in 1.24.52 Ad notification browser window is shown, after clicking on the browser close x icon on Ad window, keep brave idle for ~2 mins after that brave crashes]

image

Actual result:

Brave crash nightly build

Brave crash
Uploaded Crash Report ID: a83a0000-f4c3-1a06-0000-000000000000
Upload Time: Wednesday, April 7, 2021 at 5:58:39 PM

Expected result:

Should not be any crash

Reproduces how often:

Easy

Brave version (brave://version info)

Brave 1.24.52 Chromium: 90.0.4430.51 (Official Build) nightly (64-bit)
Revision 32e5fa33a31641bded70a90e60121060691e7125-refs/branch-heads/4430@{#927}
OS Windows 10 OS Version 2004 (Build 19041.867)

Version/Channel Information:

  • Can you reproduce this issue with the current release? No
  • Can you reproduce this issue with the beta channel? Not sure
  • Can you reproduce this issue with the nightly channel? Yes

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields? NA
  • Does the issue resolve itself when disabling Brave Rewards? NA
  • Is the issue reproducible on the latest version of Chrome? NA

Miscellaneous Information:

cc: @brave/legacy_qa @tmancey @rebron @jsecretan

@LaurenWags
Copy link
Member

@tmancey is this related to custom ad notifications?

@tmancey
Copy link
Contributor

tmancey commented Apr 9, 2021

@LaurenWags This is due to custom ad notifications and will be fixed by brave/brave-core#8377

@LaurenWags
Copy link
Member

thanks! wanted to be sure this wasn't something we needed to worry about for 1.23.x release 👍🏻

@rebron rebron added the priority/P3 The next thing for us to work on. It'll ride the trains. label Apr 15, 2021
@tmancey tmancey added the closed/duplicate Issue has already been reported label Apr 23, 2021
@tmancey
Copy link
Contributor

tmancey commented Apr 23, 2021

Closing as will be fixed by #13132 which is due to be merged very soon

@tmancey tmancey closed this as completed Apr 23, 2021
@tmancey tmancey added this to Ads Jun 10, 2024
@tmancey tmancey moved this to Done in Ads Jun 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
closed/duplicate Issue has already been reported crash feature/ads OS/Desktop priority/P3 The next thing for us to work on. It'll ride the trains. QA/Test-Plan-Specified QA/Yes regression
Projects
Archived in project
Development

No branches or pull requests

4 participants