Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not clear favicons #927

Closed
NejcZdovc opened this issue Sep 2, 2018 · 5 comments
Closed

Do not clear favicons #927

NejcZdovc opened this issue Sep 2, 2018 · 5 comments

Comments

@NejcZdovc
Copy link
Contributor

Now when you clear images, we lose icons on rewards page. We need to persist them.

image

One temp proposal is that we detect onerror when loading images and if that happens we load faviconUrl and trigger re-cache.

@NejcZdovc NejcZdovc added this to the Releasable builds 0.55.x milestone Sep 2, 2018
@bbondy bbondy modified the milestones: Releasable builds 0.55.x, 1.0 Sep 3, 2018
@rebron rebron modified the milestones: 1.0, 1.x Backlog Sep 25, 2018
@rebron rebron added the priority/P5 Not scheduled. Don't anticipate work on this any time soon. label Sep 28, 2018
@rebron
Copy link
Collaborator

rebron commented Sep 28, 2018

Fix should be in Rewards, people would perceive this as an issue.

@rebron rebron closed this as completed Sep 28, 2018
@NejcZdovc
Copy link
Contributor Author

NejcZdovc commented Sep 28, 2018

@rebron why was this one closed?

@rebron rebron modified the milestones: 1.x Backlog, Dupe / Invalid / Not actionable Sep 28, 2018
@bsclifton
Copy link
Member

@NejcZdovc during a mini-triage, a few of us discussed and basically if a user picks to delete icons/files/etc, they expect EVERYTHING to be deleted

Keeping something just because we use it for Rewards is just like how Google Chrome clears all the cookies... except your Google account ones (something that folks were vocally opposed to). You can hit up @bbondy and @rebron over Slack if you'd like more information

@NejcZdovc
Copy link
Contributor Author

@bsclifton already talked with @rebron about it and he will create a follow up. It's not that I am apposed to closing it, but we need to fix this or say we will not fix it. So we need issue to track that

@bsclifton
Copy link
Member

@NejcZdovc awesome- I'd like to propose whatever the solution is as something that shows in here too (ex: Brave Rewards would show as something you can clear under Clear browsing data) 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants