Do not clear favicons

[NejcZdovc]

Now when you clear images, we lose icons on rewards page. We need to persist them.

One temp proposal is that we detect onerror when loading images and if that happens we load faviconUrl and trigger re-cache.

[rebron]

Fix should be in Rewards, people would perceive this as an issue.

[NejcZdovc]

@rebron why was this one closed?

[bsclifton]

@NejcZdovc during a mini-triage, a few of us discussed and basically if a user picks to delete icons/files/etc, they expect EVERYTHING to be deleted

Keeping something just because we use it for Rewards is just like how Google Chrome clears all the cookies... except your Google account ones (something that folks were vocally opposed to). You can hit up @bbondy and @rebron over Slack if you'd like more information

[NejcZdovc]

@bsclifton already talked with @rebron about it and he will create a follow up. It's not that I am apposed to closing it, but we need to fix this or say we will not fix it. So we need issue to track that

[bsclifton]

@NejcZdovc awesome- I'd like to propose whatever the solution is as something that shows in here too (ex: Brave Rewards would show as something you can clear under Clear browsing data) 😄