Implement custom Brave Ad notifications #9592

tmancey · 2020-05-03T04:44:03Z

Implement custom Brave Ad notifications

tmancey · 2020-05-03T05:10:49Z

Resolving this issue would close the following issues:

#5541 Fix user earns while native macOS notifications are suppressed
#5205 Clearly mark all Brave Ads as Brave Ads
#2887 Brave Ads notification icon is too small and almost invisible
#4007 Brave Ads notification uses release channel icon
#6913 Brave Ads - major UX problem
#4194 Feature request: Track what fraction of Brave Ads system notifications sent cannot be delivered, on a per-platform basis
#7867 Investigate Chromium XPC service native notification changes for macOS Catalina
#5542 Fix user earns while native Brave Ads Linux notifications are suppressed

UtkarshVerma · 2021-05-21T12:11:20Z

@tmancey This is how my ad notifications look like.

@tmancey Any thoughts?

tmancey · 2021-05-21T13:07:37Z

@UtkarshVerma you cannot disable custom ad notifications. If you are experiencing issues, please raise a new github issue with steps to reproduce. Thank you

GeetaSarvadnya · 2021-06-08T15:40:31Z

Verification passed on



<!--StartFragment-->
Brave | 1.26.54 Chromium: 91.0.4472.88&nbsp;(Official Build)&nbsp;beta&nbsp;(64-bit)
-- | --
Revision | 109e9cd038b94a631aea7d40ee3d56c1278f2597-refs/branch-heads/4472@{#1385}
OS | Windows&nbsp;10 OS Version 2004 (Build 19041.985)

<!--EndFragment-->

Verified the issue in Implement new custom ad notification design #13132 (comment) and Implement custom ad notification fade in/out transition #14811 (comment)

Verification passed on

Brave	1.26.53 Chromium: 91.0.4472.77 (Official Build) beta (64-bit)
Revision	1cecd5c8a856bc2a5adda436e7b84d8d21b339b6-refs/branch-heads/4472@{#1246}
OS	Ubuntu 18.04 LTS

Verification done in #13132 (comment)

Verified PASSED using

Brave	1.26.54 Chromium: 91.0.4472.88 (Official Build) beta (x86_64)
Revision	109e9cd038b94a631aea7d40ee3d56c1278f2597-refs/branch-heads/4472@{#1385}
OS	macOS Version 11.4 (Build 20F71)

Verification done in #13132 (comment)

GeetaSarvadnya · 2021-06-14T11:24:35Z

Verification passed on Samsung Galaxy Tab version 10 running brave Beta build Bravemonoarm64 1.26.56.apk
Verified the test plan from brave/brave-core#8377

Confirmed custom Ad notifications are served in Android
Confirmed custom Ad notification are shown correctly in Light mode
Confirmed custom Ad notification are shown correctly in Dark mode
Encountered Custom ad notifications do not respect dark mode on Android #16350, [ads] Add fade transition to custom notification ads on Android #16400 and Follow up of #13038 - swiping up ad notification doesn't trigger the dismiss event type #16361
Confirmed users are rewarded for viewing custom ads
Additional testing is covered in Implement swipe-to-dismiss for Brave Ads custom ad notifications #13038 (comment) and Custom ad notification field trials #15624 (comment)

Brave://rewards - Ads panel:

Verification passed on OnePlus 6T with Android 10 running 1.26.59 x64 beta build

Verified custom ad notifications are shown
Verified View/Click/Landed events are captured correctly
Verified ad notification is auto-dismissed after 30 secs of no interaction
Verified swiping between apps when custom ad notification is shown is still retained within 30 secs
Verified clicking on the ad notification loads the landing page
Verified users are rewarded for viewing custom ads

View Event

2021-06-14 10:14:43.870 27076-27076/? V/chromium: [VERBOSE1:ad_notification_serving.cc(105)] Ad notification delivered:
      uuid: 03022852-d38a-493a-8bb0-47ffcfbf9704
      creativeInstanceId: ed6c467a-8643-42eb-a7cd-32e878fa3cd4
      creativeSetId: a9f0b49c-3298-4c1b-a8b5-76a71e8d7332
      campaignId: 0e70c893-b0c0-4dab-860d-7e65446f0f0f
      advertiserId: 8d2f4191-b76e-4369-8983-3d9ff551c5ad
      segment: untargeted
      title: This is a test
      body: This is a test
      targetUrl: https://www.brave.com
2021-06-14 10:14:43.906 27076-27076/? V/chromium: [VERBOSE3:ad_notification_event_viewed.cc(24)] Viewed ad notification with uuid 03022852-d38a-493a-8bb0-47ffcfbf9704 and creative instance id ed6c467a-8643-42eb-a7cd-32e878fa3cd4

Click Event

2021-06-14 10:14:53.988 27076-27076/? V/chromium: [VERBOSE6:redeem_unblinded_token.cc(84)] URL Response:
      URL: https://ads-serve.bravesoftware.com/v1/confirmation/3b55467f-9299-4555-8c1a-aadcfc017970/eyJwYXlsb2FkIjoie1wiYmxpbmRlZFBheW1lbnRUb2tlblwiOlwiMXIxRHVGRWMrcjAwY3o0SWJHYkJSUmEvallHaWozcS9EVG5PdzRNZ1ZpST1cIixcImJ1aWxkQ2hhbm5lbFwiOlwiYmV0YVwiLFwiY3JlYXRpdmVJbnN0YW5jZUlkXCI6XCJlZDZjNDY3YS04NjQzLTQyZWItYTdjZC0zMmU4NzhmYTNjZDRcIixcInBheWxvYWRcIjp7fSxcInBsYXRmb3JtXCI6XCJhbmRyb2lkXCIsXCJzdHVkaWVzXCI6W10sXCJ0eXBlXCI6XCJjbGlja1wifSIsInNpZ25hdHVyZSI6ImQrakdObGk3VVRPN0Q0QzlpMUZuZTFIeHA4Vnh3OWFjTUdmaWk0SEd1WHU0SnJ3RldIY2Qzd3gvbHhnY1QrbUZoZE1WMEZ5dFl0dWN0Z2dWZHhLNUtRPT0iLCJ0IjoiNndxSHNQRGEvSjEvajJybHV2OHlneHdqR3NjZDdmYW85L2habUQ3SkZxRXpUT2FkZlplR0RFZ3FYd1JZL0VwNFVNQzB5UzZERm8ralowU0hTZzRPK2c9PSJ9
      Response Status Code: 201
      Response: {"id":"3b55467f-9299-4555-8c1a-aadcfc017970","payload":{},"createdAt":"2021-06-14T14:14:53.832Z","type":"click","modifiedAt":"2021-06-14T14:14:53.832Z","creativeInstanceId":"ed6c467a-8643-42eb-a7cd-32e878fa3cd4"}

Landed Event

2021-06-14 10:15:07.246 27076-27076/? V/chromium: [VERBOSE6:redeem_unblinded_token.cc(84)] URL Response:
      URL: https://ads-serve.bravesoftware.com/v1/confirmation/d7bc4109-3864-43dd-a74c-e2bbc026504b/eyJwYXlsb2FkIjoie1wiYmxpbmRlZFBheW1lbnRUb2tlblwiOlwiTU1pWUorWExtWHM5K0FseFpVVTJRQ1JCWWhsNjlPOE8yank4MW9McktFZz1cIixcImJ1aWxkQ2hhbm5lbFwiOlwiYmV0YVwiLFwiY3JlYXRpdmVJbnN0YW5jZUlkXCI6XCJlZDZjNDY3YS04NjQzLTQyZWItYTdjZC0zMmU4NzhmYTNjZDRcIixcInBheWxvYWRcIjp7fSxcInBsYXRmb3JtXCI6XCJhbmRyb2lkXCIsXCJzdHVkaWVzXCI6W10sXCJ0eXBlXCI6XCJsYW5kZWRcIn0iLCJzaWduYXR1cmUiOiJkbmR5Q3UzQ0J3UGdGbHlVWkFjWVpsWC9qSVhFd2RuUW5zUFdDNFZ1WnJkbjZlazdSZ0tiNkFKcTdSMTBNNlNLYTNZcVpKMzhSM01LMUM4dGl1ZGVyQT09IiwidCI6InFWYzl5R25jczV1VHZIRDl2UEZrZ2FWWDlacUVQQW5zakppeUpkYmZPclJrYmlHZ091a2NEdkN6LzVJaXZycDRDRDQwUHR0RDc1RGRFRDVSSkQ5aXpBPT0ifQ==
      Response Status Code: 201
      Response: {"id":"d7bc4109-3864-43dd-a74c-e2bbc026504b","payload":{},"createdAt":"2021-06-14T14:15:06.928Z","type":"landed","modifiedAt":"2021-06-14T14:15:06.928Z","creativeInstanceId":"ed6c467a-8643-42eb-a7cd-32e878fa3cd4"}

Dismiss event

Encountered Follow up of #13038 - swiping up ad notification doesn't trigger the dismiss event type #16361

CodeDead · 2021-07-29T12:16:04Z

Notifications are not working on the Wayland display server.

Steps to reproduce:

Use Linux
Use Wayland
Use Brave

mattfbacon · 2021-10-07T23:29:54Z

PLEASE add an option to disable this. I hate these notifications, they display on top of actual notifications, they are ugly compared to my actual notifications. Everything was working fine before.

tmancey · 2021-10-08T04:16:02Z

Hi. You can disable custom ad notifications in brave://flags. Thanks

mattfbacon · 2021-10-09T04:07:10Z

Is that "Enable system notifications"? Or some other key?

mattfbacon · 2021-10-09T04:08:37Z

Nevermind, it's "Enable Brave Ads custom notifications". Thanks. Hope this helps anyone that wants system notifications.

mattfbacon · 2021-10-11T17:13:32Z

Actually, that doesn't work. Could you give the specific flag to set?

UndarkAido · 2021-10-17T21:27:49Z

brave://flags/#brave-ads-custom-notifications isn't working for me either. I'm just going to turn off ads for now.

UndarkAido · 2021-10-17T21:30:40Z

Looks like #18798 covers this issue though for anyone coming through

tmancey · 2021-10-18T18:45:48Z

Please try again as you should now see native notifications on the release build

tmancey mentioned this issue May 3, 2020

Native notifications on Linux not working #6569

Closed

rebron self-assigned this May 6, 2020

rebron added OS/Desktop priority/P3 The next thing for us to work on. It'll ride the trains. labels Jun 12, 2020

tmancey added the QA/Yes label Jun 15, 2020

tmancey assigned yachtcaptain23 and unassigned rebron Jun 27, 2020

tmancey added the release-notes/include label Jul 10, 2020

tmancey closed this as completed Apr 29, 2021

This was referenced May 14, 2021

Display an error message to the user if Brave Ads are not supported due to missing system components #13696

Closed

Brave Ads are not displayed on Wayland #13866

Closed

btlechowski added the QA/Test-All-Platforms label May 28, 2021

GeetaSarvadnya added the QA Pass-Win64 label Jun 8, 2021

btlechowski added the QA Pass-Linux label Jun 8, 2021

stephendonner added the QA Pass-macOS label Jun 9, 2021

GeetaSarvadnya added the QA Pass - Android Tab label Jun 14, 2021

srirambv added the QA Pass - Android ARM label Jun 14, 2021

GeetaSarvadnya mentioned this issue Jun 15, 2021

Add custom scripts for Verifiable Advertiser Conversions #15491

Closed

AdnanHodzic mentioned this issue Sep 25, 2021

[Desktop] Pinch-to-Zoom not working on Linux (Pop OS 20.04, Wayland) #11609

Open

AdnanHodzic mentioned this issue Aug 30, 2022

Brave won't start with "Preferred Ozone platform" flag set to "Wayland" on snap package (Ubuntu) #25074

Open

tmancey added this to Ads Jun 10, 2024

tmancey moved this to Done in Ads Jun 10, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Implement custom Brave Ad notifications #9592

Implement custom Brave Ad notifications #9592

tmancey commented May 3, 2020

tmancey commented May 3, 2020 •

edited

Loading

UtkarshVerma commented May 21, 2021

tmancey commented May 21, 2021

GeetaSarvadnya commented Jun 8, 2021 •

edited by stephendonner

Loading

GeetaSarvadnya commented Jun 14, 2021 •

edited by srirambv

Loading

CodeDead commented Jul 29, 2021

mattfbacon commented Oct 7, 2021

tmancey commented Oct 8, 2021

mattfbacon commented Oct 9, 2021

mattfbacon commented Oct 9, 2021

mattfbacon commented Oct 11, 2021

UndarkAido commented Oct 17, 2021 •

edited

Loading

UndarkAido commented Oct 17, 2021

tmancey commented Oct 18, 2021

Implement custom Brave Ad notifications #9592

Implement custom Brave Ad notifications #9592

Comments

tmancey commented May 3, 2020

tmancey commented May 3, 2020 • edited Loading

UtkarshVerma commented May 21, 2021

tmancey commented May 21, 2021

GeetaSarvadnya commented Jun 8, 2021 • edited by stephendonner Loading

GeetaSarvadnya commented Jun 14, 2021 • edited by srirambv Loading

CodeDead commented Jul 29, 2021

mattfbacon commented Oct 7, 2021

tmancey commented Oct 8, 2021

mattfbacon commented Oct 9, 2021

mattfbacon commented Oct 9, 2021

mattfbacon commented Oct 11, 2021

UndarkAido commented Oct 17, 2021 • edited Loading

UndarkAido commented Oct 17, 2021

tmancey commented Oct 18, 2021

tmancey commented May 3, 2020 •

edited

Loading

GeetaSarvadnya commented Jun 8, 2021 •

edited by stephendonner

Loading

GeetaSarvadnya commented Jun 14, 2021 •

edited by srirambv

Loading

UndarkAido commented Oct 17, 2021 •

edited

Loading