Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Native notifications on Linux not working #6569

Closed
RatanRSur opened this issue Oct 21, 2019 · 15 comments
Closed

Native notifications on Linux not working #6569

RatanRSur opened this issue Oct 21, 2019 · 15 comments
Labels
closed/invalid closed/wontfix feature/ads needs-investigation A bug not 100% confirmed/fixed OS/Linux priority/P3 The next thing for us to work on. It'll ride the trains.

Comments

@RatanRSur
Copy link

Description

I went to brave://flags and enabled native notifications but I still see the chromium styles ones.

Steps to Reproduce

  1. Get a notification, such as a brave ad

Actual result:

Chromium styled notification

Expected result:

My custom styled notifications using
https://wiki.archlinux.org/index.php/Dunst

Reproduces how often:

Every time

Brave version (brave://version info)

0.69.135 Chromium: 77.0.3865.120 (Official Build) unknown (64-bit)

Version/Channel Information:

  • Can you reproduce this issue with the current release?
  • Can you reproduce this issue with the beta channel?
  • Can you reproduce this issue with the dev channel?
  • Can you reproduce this issue with the nightly channel?

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields?
  • Does the issue resolve itself when disabling Brave Rewards?
  • Is the issue reproducible on the latest version of Chrome?

Miscellaneous Information:

If I remember correctly the experimental flag worked in a previous version but not anymore. I can't remember which version that was unfortunately

@fmarier
Copy link
Member

fmarier commented Oct 25, 2019

0.69.135 Chromium: 77.0.3865.120 (Official Build) unknown (64-bit)

I don't see anything about "native notifications" in brave://flags if I search for "notif" in 0.70, the current stable Brave version.

I have however been running Brave Ads with dunst without any problems since it launched a few months ago, without doing anything special configuration-wise. So I'm not sure what's different between your machine and mine other than the distro (Ubuntu 18.04 v. Arch).

Can you take a screenshot of the notifications you see in Brave 0.70?

Is dunst running (try pgrep dunst)?

@RatanRSur
Copy link
Author

I definitely had it in one of the recent versions! But yes, it's not in the options any longer. dunst is running but if the option for native notifications was removed then it's not surprising it doesn't work. Could that be added back as an experimental feature?

@fmarier
Copy link
Member

fmarier commented Oct 31, 2019

I'm not sure exactly what we would add because it's working fine for me using default options:
Screenshot from 2019-10-31 11-20-03

@bsclifton
Copy link
Member

bsclifton commented Nov 5, 2019

@RatanRSur if it's not showing in brave://flags, there may not be a straight-forward way to toggle the flag (it may have been removed with Chromium 78)

@RatanRSur
Copy link
Author

I can't repro this in chromium :/ The native notifications work fine there.

@rebron rebron added the priority/P3 The next thing for us to work on. It'll ride the trains. label Nov 15, 2019
@rebron
Copy link
Collaborator

rebron commented Nov 15, 2019

cc: @jsecretan @tmancey

@tmancey tmancey self-assigned this Nov 15, 2019
@tmancey
Copy link
Contributor

tmancey commented Nov 15, 2019

@rebron I am investigating and will update when I found out more information. Thanks

@mcamou
Copy link

mcamou commented Dec 23, 2019

I'm seeing this same problem on 1.1.23 Chromium: 79.0.3945.88 (Official Build) (64-bit). I do see the "Enable native notifications" flag and have it enabled.

@elcrec
Copy link

elcrec commented Jan 15, 2020

I do not experience this problem - dunst notifications work for all kind of websites: slack, whatsapp etc.

$ uname -r
5.4.11-arch1-1
$ brave --version
Brave Browser 79.1.2.42 unknown
$ pacman -Qi brave
Targets         : brave-browser
Name            : brave-bin
Version         : 1:1.2.42-2
Description     : Web browser that blocks ads and trackers by default (binary release).
Architecture    : x86_64
URL             : https://brave.com/download
Build Date      : Di 14 Jan 2020 21:41:57 CET
$ pacman -Qi dunst
Name            : dunst
Version         : 1.4.1-1
Description     : Customizable and lightweight notification-daemon
Architecture    : x86_64
URL             : https://dunst-project.org/
Provides        : notification-daemon
Build Date      : Sa 06 Jul 2019 21:30:40 CEST

I did have to change the flag "Enable native notifications" from Default to Enabled and restart brave.

@mcamou
Copy link

mcamou commented Jan 15, 2020

In my case, I'm running KDE Plasma 5.17.5 on top of Ubuntu 19.10 (not Kubuntu, a normal Ubuntu with apt install plasma-desktop). All Chrome notifications (WhatsApp, GMail, Slack, etc) show up as Chrome notifications instead of KDE notifications.

@tmancey tmancey removed their assignment Feb 27, 2020
@tmancey tmancey added needs-investigation A bug not 100% confirmed/fixed and removed feature/notifications priority/P3 The next thing for us to work on. It'll ride the trains. labels Feb 27, 2020
@tmancey tmancey added QA/Yes priority/P3 The next thing for us to work on. It'll ride the trains. labels May 1, 2020
@tmancey
Copy link
Contributor

tmancey commented May 3, 2020

Brave Ads support Chrome notifications which do not support KDE. Closing issue as #9592 will resolve this issue.

@tmancey tmancey closed this as completed May 3, 2020
@tmancey tmancey added this to the Dupe / Invalid / Not actionable milestone May 3, 2020
@wackbyte
Copy link

wackbyte commented May 7, 2020

I'm using sway and mako on Arch Linux and this recently started happening. Never mind, it magically started working again.

@bbondy bbondy removed this from the Dupe / Invalid / Not actionable milestone May 30, 2020
@BachoSeven
Copy link

I use dunst and experienced the following Issue on Arch Linux, Brave Nightly build: without native notifications enabled, I was seeing ads notifications from dunst but was not able to click them; with the native notifications flag, I was able to see and click notifications.

@fmarier
Copy link
Member

fmarier commented Jun 8, 2020

I was seeing ads notifications from dunst but was not able to click them

To click on ads from dunst, I use the following (default?) key binding: Ctrl+Shift+.

@BachoSeven
Copy link

Yea that one was not working and still doesn't, however, Middle click also triggers the action by default, and that one is now working.

@tmancey tmancey added this to Ads Jun 10, 2024
@tmancey tmancey moved this to Done in Ads Jun 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
closed/invalid closed/wontfix feature/ads needs-investigation A bug not 100% confirmed/fixed OS/Linux priority/P3 The next thing for us to work on. It'll ride the trains.
Projects
Archived in project
Development

No branches or pull requests