Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ads] Add fade transition to custom notification ads on Android #16400

Open
GeetaSarvadnya opened this issue Jun 14, 2021 · 0 comments
Open

[ads] Add fade transition to custom notification ads on Android #16400

GeetaSarvadnya opened this issue Jun 14, 2021 · 0 comments
Labels
enhancement feature/ads OS/Android Fixes related to Android browser functionality

Comments

@GeetaSarvadnya
Copy link

Description

Follow up of #14811- Unable to see ad notification fade in/out transition animation in Android

Steps to reproduce

  1. Clean profile 1.26.56
  2. Launch brave
  3. Enter the cmd --variations-server-url=https://no-thanks.invalid --enable-features="AdNotifications<CommandLineStudy" --force-fieldtrials="*CommandLineStudy/Enabled" --force-fieldtrial-params="CommandLineStudy.Enabled:should_show_custom_notifications/true/ad_notification_timeout/0/ad_notification_fade_duration/2000" in command line sting under QA preferences
  4. Relaunch brave
  5. Enable rewards and view a custom Ad
  6. Custom Ad is shown but there is no fade in/out transition animation

Actual result

Unable to see ad notification fade in/out transition animation in Android

Expected result

Should see the fade in/out animation for custom ad notification

Issue reproduces how often

Easy

Version/Channel Information:

  • Can you reproduce this issue with the current Play Store version? NA
  • Can you reproduce this issue with the current Play Store Beta version? Yes
  • Can you reproduce this issue with the current Play Store Nightly version? Not sure

Device details

  • Install type (ARM, x86): ARM
  • Device type (Phone, Tablet, Phablet): Android Tablet
  • Android version: 10

Brave version

1.26.56

Website problems only

  • Does the issue resolve itself when disabling Brave Shields? NA
  • Does the issue resolve itself when disabling Brave Rewards? NA
  • Is the issue reproducible on the latest version of Chrome? NA

Additional information

cc: @brave/legacy_qa @tmancey

@tmancey tmancey changed the title Follow up of #14811- Unable to see ad notification fade in/out transition animation in Android Follow up of #14811- Fix unable to see Brave Ad notification fade in/out transition animation in Android Apr 13, 2023
@tmancey tmancey changed the title Follow up of #14811- Fix unable to see Brave Ad notification fade in/out transition animation in Android Follow up of #14811- Fix Brave Ad notification should fade in/out on Android Apr 13, 2023
@tmancey tmancey changed the title Follow up of #14811- Fix Brave Ad notification should fade in/out on Android Follow up of #14811- Fix Brave Ad custom notifications should fade in/out on Android Apr 13, 2023
@tmancey tmancey added blocked needs-discussion Although the issue is clear, we haven't yet reached a decision about the right solution. labels Apr 13, 2023
@tmancey tmancey removed needs-discussion Although the issue is clear, we haven't yet reached a decision about the right solution. blocked labels Jun 14, 2023
@tmancey tmancey changed the title Follow up of #14811- Fix Brave Ad custom notifications should fade in/out on Android [ads] Add fade transition to custom notification ads on Android Oct 25, 2023
@tmancey tmancey added enhancement and removed bug labels Oct 25, 2023
@tmancey tmancey added this to Ads Jun 10, 2024
@tmancey tmancey moved this to Custom notification ads in Ads Jun 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement feature/ads OS/Android Fixes related to Android browser functionality
Projects
Status: Custom notification ads 🚫
Development

No branches or pull requests

2 participants