Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

User earns while native Brave Ads Linux notifications are suppressed #5542

Closed
tmancey opened this issue Aug 5, 2019 · 2 comments
Closed

Comments

@tmancey
Copy link
Contributor

tmancey commented Aug 5, 2019

Description

When notifications are disabled for the browser, ad notifications still register as having been displayed and the user is able to earn BAT in spite of never having seen a notification or ad.

Steps to Reproduce

  1. Enable Brave Rewards and Ads
  2. Visit Preferences in Linux Settings
  3. Disable notifications for Brave

Actual result:

The browser believes it is showing ad notifications from time to time.

Expected result:

The browser ceases to show notifications, or is aware that they aren't visible.

Reproduces how often:

Easily reproduced

Brave version (brave://version info)

0.70.x

Version/Channel Information:

  • Can you reproduce this issue with the current release? Yes
  • Can you reproduce this issue with the beta channel? Yes
  • Can you reproduce this issue with the dev channel? Yes
  • Can you reproduce this issue with the nightly channel? Yes

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields? N/A
  • Does the issue resolve itself when disabling Brave Rewards? No
  • Is the issue reproducible on the latest version of Chrome? N/A

Miscellaneous Information:

@tmancey tmancey added the priority/P2 A bad problem. We might uplift this to the next planned release. label Aug 5, 2019
@NejcZdovc NejcZdovc added priority/P3 The next thing for us to work on. It'll ride the trains. and removed priority/P2 A bad problem. We might uplift this to the next planned release. labels Nov 15, 2019
@tmancey tmancey changed the title Fix user earns while native Linux notifications are suppressed Fix user earns while native Brave Ads Linux notifications are suppressed Jan 20, 2020
@tmancey tmancey removed QA/Yes priority/P3 The next thing for us to work on. It'll ride the trains. labels May 16, 2020
@tmancey tmancey added priority/P3 The next thing for us to work on. It'll ride the trains. QA/Yes labels Jun 4, 2020
@tmancey tmancey self-assigned this Jun 4, 2020
@tmancey tmancey changed the title Fix user earns while native Brave Ads Linux notifications are suppressed User earns while native Brave Ads Linux notifications are suppressed Jun 4, 2020
@tmancey tmancey added blocked and removed QA/Yes priority/P3 The next thing for us to work on. It'll ride the trains. release-notes/include labels Aug 5, 2020
@tmancey
Copy link
Contributor Author

tmancey commented Aug 5, 2020

Blocked as issue will be closed once #9592 has been implemented

@tmancey tmancey closed this as completed Aug 5, 2020
@tmancey tmancey reopened this Aug 5, 2020
@tmancey tmancey removed their assignment Aug 20, 2020
@tmancey
Copy link
Contributor Author

tmancey commented Oct 22, 2020

Closing issue as superseded by #9592

@tmancey tmancey closed this as completed Oct 22, 2020
@tmancey tmancey added this to Ads Jun 10, 2024
@tmancey tmancey moved this to Done in Ads Jun 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

2 participants