Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Brave Ads notification always uses release channel icon #4007

Closed
srirambv opened this issue Apr 4, 2019 · 2 comments
Closed

Brave Ads notification always uses release channel icon #4007

srirambv opened this issue Apr 4, 2019 · 2 comments

Comments

@srirambv
Copy link
Contributor

srirambv commented Apr 4, 2019

Description

Ad notification uses release channel icon

Steps to Reproduce

  1. Install Dev(0.64.36)/Beta(0.63.31)
  2. Enable Rewards/Ads
  3. Finish ad trigger critera and wait for the ad to show up
  4. Ad uses release channel icon instead of Dev/Beta respectively

Actual result:

Screenshot from 2019-04-04 16-19-45

Expected result:

Should use respective channel icon to differentiate which channel build is showing ad notification

Reproduces how often:

Easy

Brave version (brave://version info)

Brave 0.63.31 Chromium: 73.0.3683.75 (Official Build) beta(64-bit)
Revision 909ee014fcea6828f9a610e6716145bc0b3ebf4a-refs/branch-heads/3683@{#803}
OS Linux
Brave 0.64.36 Chromium: 73.0.3683.75 (Official Build) dev(64-bit)
Revision 909ee014fcea6828f9a610e6716145bc0b3ebf4a-refs/branch-heads/3683@{#803}
OS Linux

Reproducible on current release:

  • Does it reproduce on brave-browser dev/beta builds?
    Yes

Website problems only:

  • Does the issue resolve itself when disabling Brave Shields?
  • Is the issue reproducible on the latest version of Chrome?

Additional Information

Also too small icon similar to #2887
cc: @tmancey @bridiver

@rebron rebron added the priority/P4 Planned work. We expect to get to it "soon". label Apr 5, 2019
@jsecretan jsecretan reopened this Apr 10, 2019
@tmancey tmancey changed the title Ad notification uses release channel icon Brave Ads notification uses release channel icon Jan 20, 2020
@tmancey tmancey removed QA/Test-Plan-Specified QA/Yes priority/P4 Planned work. We expect to get to it "soon". labels Jan 20, 2020
@tmancey tmancey changed the title Brave Ads notification uses release channel icon Brave Ads notification on Linux always uses release channel icon May 3, 2020
@tmancey tmancey changed the title Brave Ads notification on Linux always uses release channel icon Brave Ads notification always uses release channel icon May 3, 2020
@tmancey
Copy link
Contributor

tmancey commented May 29, 2020

Blocked as issue will be closed once #9592 has been implemented

@tmancey tmancey removed the blocked label Oct 22, 2020
@tmancey
Copy link
Contributor

tmancey commented Oct 22, 2020

Closing issue as superseded by #9592

@tmancey tmancey closed this as completed Oct 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

No branches or pull requests

4 participants