Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update URL bar icon flyout text for IPFS local node connections #14889

Closed
bbondy opened this issue Mar 23, 2021 · 2 comments · Fixed by brave/brave-core#8359
Closed

Update URL bar icon flyout text for IPFS local node connections #14889

bbondy opened this issue Mar 23, 2021 · 2 comments · Fixed by brave/brave-core#8359

Comments

@bbondy
Copy link
Member

bbondy commented Mar 23, 2021

When an ipfs:// page is loaded (only when we display ipfs:// and ipns:// in the URL bar and have the IPFS icon), then we want to update the flyout under the URL bar icon text as well.

Update this flyout from:
Screen Shot 2021-03-23 at 9 24 54 AM

To this, but apply the text changes to the new look below:
image

It's ok to not have the exclamation icon, i.e. keep the same normal styling that is already there for now.

Text changes from the new design:

This content was loaded over the IPFS protocol

InterPlanetary File System (IPFS) is a public network for peer-to-peer data storage and delivery. You can learn more about Brave's integration or configure your IPFS settings at any time.

Security review: https://github.com/brave/security/issues/384

@spylogsster
Copy link

Final variant
image

@stephendonner
Copy link

stephendonner commented Apr 5, 2021

Verified FIXED using

Brave 1.24.47 Chromium: 90.0.4430.41 (Official Build) nightly (x86_64)
Revision e9c92b1eaca8487e212f3f6bc081fdb6d4863759-refs/branch-heads/4430@{#723}
OS macOS Version 11.2.3 (Build 20D91)

URLs used were:

  • ipfs://bafybeiemxf5abjwjbikoz4mc3a3dla6ual3jsgpdr4cjr3oz3evfyavhwq/wiki/Vincent_van_Gogh.html
  • ipfs:QmYwAPJzv5CZsnA625s3Xf2nemtYgPpHdWEz79ojWnPbdG/readme
  • ipns://en.wikipedia-on-ipfs.org/wiki/Tokyo_National_Museum.html
  • ipns://brantly.eth
Example Example Example Example Example Example Example Example
Screen Shot 2021-04-05 at 3 43 49 PM Screen Shot 2021-04-05 at 3 43 44 PM Screen Shot 2021-04-05 at 3 43 37 PM Screen Shot 2021-04-05 at 3 43 28 PM Screen Shot 2021-04-05 at 3 42 05 PM Screen Shot 2021-04-05 at 3 43 15 PM Screen Shot 2021-04-05 at 3 42 51 PM Screen Shot 2021-04-05 at 3 42 22 PM

Verification passed on

Brave | 1.24.72 Chromium: 90.0.4430.72 (Official Build) dev (64-bit)
-- | --
Revision | b6172ef8d07ef486489a4b11b66b2eaeed50d132-refs/branch-heads/4430@{#1233}
OS | Windows 10 OS Version 2004 (Build 19041.928)

URLs used were:

  • ipfs://bafybeiemxf5abjwjbikoz4mc3a3dla6ual3jsgpdr4cjr3oz3evfyavhwq/wiki/Vincent_van_Gogh.html
  • ipfs:QmYwAPJzv5CZsnA625s3Xf2nemtYgPpHdWEz79ojWnPbdG/readme
  • ipns://brantly.eth
image image image image image image

Verification passed on

Brave 1.24.70 Chromium: 90.0.4430.72 (Official Build) beta (64-bit)
Revision b6172ef8d07ef486489a4b11b66b2eaeed50d132-refs/branch-heads/4430@{#1233}
OS Ubuntu 18.04 LTS

Verified test plan from the description

image image image image image image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment