Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ipfs page info bubble #8359

Merged
merged 2 commits into from
Mar 30, 2021
Merged

Add ipfs page info bubble #8359

merged 2 commits into from
Mar 30, 2021

Conversation

spylogsster
Copy link
Contributor

@spylogsster spylogsster commented Mar 25, 2021

Resolves brave/brave-browser#14889

image

Submitter Checklist:

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

  • Open IPFS link
  • Click by badge in address bar

@spylogsster spylogsster requested a review from bbondy March 25, 2021 15:58
@spylogsster spylogsster force-pushed the flyout-view branch 8 times, most recently from 1385570 to 65cc770 Compare March 29, 2021 07:48
@spylogsster spylogsster requested a review from a team as a code owner March 29, 2021 17:35
@spylogsster spylogsster force-pushed the flyout-view branch 2 times, most recently from afcceec to 3688c5c Compare March 29, 2021 18:48
@mkarolin
Copy link
Collaborator

mkarolin commented Mar 29, 2021

The wording seems a bit repetitive with Learn more at the end. Maybe something like:
InterPlanetary File System (IPFS) is a public network for peer-to-peer data storage and delivery. You can configure your IPFS settings at any time in the browser Settings. <link>Learn more</link> about Brave's IPFS integration. cc: @bbondy

Edit: never mind, didn't notice that the link takes you to the settings page.

@spylogsster spylogsster force-pushed the flyout-view branch 2 times, most recently from c86e8ca to c35b149 Compare March 29, 2021 20:13
@spylogsster spylogsster requested a review from bridiver as a code owner March 29, 2021 20:13
Copy link
Collaborator

@mkarolin mkarolin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

chromium_src changes LGTM

@bbondy bbondy merged commit 3d6bfa5 into master Mar 30, 2021
@bbondy bbondy deleted the flyout-view branch March 30, 2021 13:10
@bbondy bbondy added this to the 1.24.x - Nightly milestone Mar 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update URL bar icon flyout text for IPFS local node connections
3 participants