Remove topbar and non-search settings from brave://settings for guest windows

[emerick]

Description

When opening brave://settings in a guest window, we shouldn't show the topbar or non-search related settings.

Steps to Reproduce

1. Launch Brave
2. Hamburger menu -> Open Guest Window
3. From the newly opened Guest window: Hamburger menu -> Settings

Actual result:

We show a navigation topbar in Guest windows that includes features that are inaccessible from a Guest window (e.g., Brave Rewards) and we show settings that aren't

Expected result:

We shouldn't show the navigation topbar in Guest windows (especially since it has things like "Brave Rewards" which require a regular profile and will crash in non-regular profiles). In addition, we should only show search-related settings here (as Chrome does).

@rebron suggested it should look like this instead:

Reproduces how often:

Easily reproduced.

Desktop Brave version:

Latest master.

Android Device details:

• Install type (ARM, x86):
• Device type (Phone, Tablet, Phablet):
• Android version:

Version/Channel Information:

• Can you reproduce this issue with the current release?
• Can you reproduce this issue with the beta channel?
• Can you reproduce this issue with the nightly channel?

Other Additional Information:

• Does the issue resolve itself when disabling Brave Shields?
• Does the issue resolve itself when disabling Brave Rewards?
• Is the issue reproducible on the latest version of Chrome?

Miscellaneous Information:

[rebron]

cc: @spylogsster Can you take a look at this one as well since you were in here already via: brave/brave-core#8445

[jcsavage2]

Hello! I would like to investigate this issue. is it still available and are you looking for help? I'd love to give this a shot!

[rebron]

We can probably change this to wontfix. wdyt @emerick? The top navigation in guest doesn't have Rewards there and bookmarks and history show a proper warning.

Other settings for Shields and Social Media blocking seem fine.

[emerick]

Yes, wontfix makes sense for this.