Crash when clicking on Rewards pane in Settings, while in Guest mode

[stephendonner]

Description

Crash when clicking on Rewards pane in Settings, while in Guest mode

Steps to Reproduce

1. new profile
2. launch Brave
3. click on the "hamburger" menu and choose Open Guest Window
4. click on the menu again and now choose Settings
5. click on the Rewards pane

Actual result:

Instantly crashes upon click on the Rewards pane, in:

[ 00 ] BraveRewardsPageUI::BraveRewardsPageUI(content::WebUI*, std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > const&)
[ 01 ] (anonymous namespace)::NewWebUI(content::WebUI*, GURL const&)
[ 02 ] content::WebUIControllerFactoryRegistry::CreateWebUIControllerForURL(content::WebUI*, GURL const&)
[ 03 ] content::WebContentsImpl::CreateWebUI(content::RenderFrameHostImpl*, GURL const&)
[ 04 ] content::RenderFrameHostImpl::CreateWebUI(GURL const&, int)
[ 05 ] content::RenderFrameHostManager::GetFrameHostForNavigation(content::NavigationRequest*, std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> >*)
[ 06 ] content::RenderFrameHostManager::DidCreateNavigationRequest(content::NavigationRequest*)
[ 07 ] <name omitted>
[ 08 ] <name omitted>
[ 09 ] content::NavigationControllerImpl::NavigateWithoutEntry(content::NavigationController::LoadURLParams const&)
[ 10 ] content::NavigationControllerImpl::LoadURLWithParams(content::NavigationController::LoadURLParams const&)
[ 11 ] (anonymous namespace)::LoadURLInContents(content::WebContents*, GURL const&, NavigateParams*)
[ 12 ] Navigate(NavigateParams*)
[ 13 ] Browser::OpenURLFromTab(content::WebContents*, content::OpenURLParams const&)
[ 14 ] content::WebContentsImpl::OpenURL(content::OpenURLParams const&)
[ 15 ] <name omitted>
[ 16 ] content::RenderFrameHostImpl::OpenURL(mojo::StructPtr<blink::mojom::OpenURLParams>)
[ 17 ] content::mojom::FrameHostStubDispatch::Accept(content::mojom::FrameHost*, mojo::Message*)
[ 18 ] mojo::InterfaceEndpointClient::HandleValidatedMessage(mojo::Message*)
[ 19 ] mojo::MessageDispatcher::Accept(mojo::Message*)
[ 20 ] IPC::(anonymous namespace)::ChannelAssociatedGroupController::AcceptOnProxyThread(mojo::Message)
[ 21 ] base::internal::Invoker<base::internal::BindState<void (IPC::(anonymous namespace)::ChannelAssociatedGroupController::*)(mojo::Message), scoped_refptr<IPC::(anonymous namespace)::ChannelAssociatedGroupController>, mojo::Message>, void ()>::RunOnce(base::internal::BindStateBase*)
[ 22 ] <name omitted>
[ 23 ] base::sequence_manager::internal::ThreadControllerWithMessagePumpImpl::DoWorkImpl(base::sequence_manager::LazyNow*)
[ 24 ] base::sequence_manager::internal::ThreadControllerWithMessagePumpImpl::DoWork()
[ 25 ] invocation function for block in base::MessagePumpCFRunLoopBase::RunWorkSource(void*)
[ 26 ] base::mac::CallWithEHFrame(void () block_pointer)
[ 27 ] base::MessagePumpCFRunLoopBase::RunWorkSource(void*)
[ 28 ] 0x7fff204c697c
[ 29 ] 0x7fff204c68e4
[ 30 ] 0x7fff204c6664
[ 31 ] 0x7fff204c508c
[ 32 ] 0x7fff204c464c
[ 33 ] 0x7fff28702ab3
[ 34 ] 0x7fff28702815
[ 35 ] 0x7fff287025b3
[ 36 ] 0x7fff22cc56f2
[ 37 ] 0x7fff22cc3ec5
[ 38 ] __71-[BrowserCrApplication nextEventMatchingMask:untilDate:inMode:dequeue:]_block_invoke
[ 39 ] base::mac::CallWithEHFrame(void () block_pointer)
[ 40 ] -[BrowserCrApplication nextEventMatchingMask:untilDate:inMode:dequeue:]
[ 41 ] 0x7fff22cb6239
[ 42 ] base::MessagePumpNSApplication::DoRun(base::MessagePump::Delegate*)
[ 43 ] base::MessagePumpCFRunLoopBase::Run(base::MessagePump::Delegate*)
[ 44 ] base::sequence_manager::internal::ThreadControllerWithMessagePumpImpl::Run(bool, base::TimeDelta)
[ 45 ] <name omitted>
[ 46 ] content::BrowserMainLoop::RunMainMessageLoop()
[ 47 ] content::BrowserMainRunnerImpl::Run()
[ 48 ] content::BrowserMain(content::MainFunctionParams const&)
[ 49 ] content::ContentMainRunnerImpl::RunBrowser(content::MainFunctionParams&, bool)
[ 50 ] content::ContentMainRunnerImpl::Run(bool)
[ 51 ] content::RunContentProcess(content::ContentMainParams const&, content::ContentMainRunner*)
[ 52 ] content::ContentMain(content::ContentMainParams const&)
[ 53 ] ChromeMain
[ 54 ] main
[ 55 ] 0x7fff203e8f5d

Expected result:

No crash; Rewards isn't available in Guest mode, like History, etc.

Reproduces how often:

100%

Brave version (brave://version info)

Brave	1.28.37 Chromium: 91.0.4472.124 (Official Build) nightly (x86_64)
Revision	7345a6d1bfcaff81162a957e9b7d52649fe2ac38-refs/branch-heads/4472_114@{#6}
OS	macOS Version 11.4 (Build 20F71)

Version/Channel Information:

• Can you reproduce this issue with the current release? yes
• Can you reproduce this issue with the beta channel? yes
• Can you reproduce this issue with the nightly channel? yes

/cc @rebron @zenparsing @emerick @iefremov @LaurenWags

[kjozwiak]

Great find @stephendonner 👍 Reproduced on Win 10 x64 on Nightly as well using the following:

Brave | 1.28.37 Chromium: 91.0.4472.124 (Official Build) nightly (64-bit)
--- | ---
Revision | 7345a6d1bfcaff81162a957e9b7d52649fe2ac38-refs/branch-heads/4472_114@{#6}
OS | Windows 10 OS Version 2009 (Build 19042.1081)

[GeetaSarvadnya]

Dup of #14995 @emerick logged a follow-up issue to address the issue #15053