Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reddit Tip button is incorrectly positioned #15287

Closed
emerick opened this issue Apr 14, 2021 · 1 comment · Fixed by brave/brave-site-specific-scripts#55
Closed

Reddit Tip button is incorrectly positioned #15287

emerick opened this issue Apr 14, 2021 · 1 comment · Fixed by brave/brave-site-specific-scripts#55

Comments

@emerick
Copy link
Contributor

emerick commented Apr 14, 2021

Description

The Rewards "Tip" button is formatted incorrectly when visiting reddit.com. Possibly related to #9556.

Steps to Reproduce

  1. Visit reddit.com

Actual result:

"Tip" button is incorrectly formatted:

image

Expected result:

Tip button is correctly formatted, appearing between Save and ... buttons.

Reproduces how often:

Easily.

Brave version (brave://version info)

Current master.

Version/Channel Information:

  • Can you reproduce this issue with the current release?
  • Can you reproduce this issue with the beta channel?
  • Can you reproduce this issue with the nightly channel?

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields?
  • Does the issue resolve itself when disabling Brave Rewards?
  • Is the issue reproducible on the latest version of Chrome?

Miscellaneous Information:

@LaurenWags
Copy link
Member

LaurenWags commented Jul 26, 2021

Verified passed with

Brave | 1.27.108 Chromium: 92.0.4515.107 (Official Build) (x86_64)
-- | --
Revision | 87a818b10553a07434ea9e2b6dccf3cbe7895134-refs/branch-heads/4515@{#1634}
OS | macOS Version 10.15.7 (Build 19H1217)

and dev component version 1.0.48.

Reproduced the issue with prod component version 1.0.42.
Confirmed when using 1.0.48 the Tip button is spaced correctly on comments I've authored when logged in to Reddit.

1.0.42 1.0.48
15287-prod 15287-dev

Verification PASSED on Win 10 x64 using the following build:

Brave | 1.27.108 Chromium: 92.0.4515.107 (Official Build) (64-bit)
--- | ---
Revision | 87a818b10553a07434ea9e2b6dccf3cbe7895134-refs/branch-heads/4515@{#1634}
OS | Windows 10 OS Version 2009 (Build 19042.1110)

Reproduced the original issue using Brave Local Data Updater - Version: 1.0.42 and verified that a BAT tipping icon was incorrectly positioned.

Using Brave Local Data Updater - Version: 1.0.49, verified that the same BAT tipping icon was correctly being positioned via the following cases:

  • Upgrading a profile from Brave Local Data Updater - Version: 1.0.42 to Brave Local Data Updater - Version: 1.0.49
  • verified that using Brave Local Data Updater - Version: 1.0.49 correctly positioned the BAT tipping icon
1.0.42 1.0.49
image image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment