Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tip button placement changed with GL dev component 1.0.48 #17167

Closed
LaurenWags opened this issue Jul 26, 2021 · 2 comments
Closed

Tip button placement changed with GL dev component 1.0.48 #17167

LaurenWags opened this issue Jul 26, 2021 · 2 comments

Comments

@LaurenWags
Copy link
Member

Description

Found while testing #15687 for GL component version 1.0.43, but could be related to changes made for #15287 as part of the same component version.

In certain cases on a user's profile the Tip button isn't placed correctly on a tile type view.

Steps to Reproduce

  1. Clean profile w/ --use-dev-goupdater-url to get dev component version 1.0.48 for Brave Local Data Updater
  2. Enable Rewards
  3. Login to Reddit
  4. Visit https://www.reddit.com/user/meejle
  5. Look at tiles on user's profile

Repeat above when not logged in to Reddit also.

Additionally, when this is fixed, confirm that #15287 still works as expected.

Actual result:

1.0.48 (dev):
1 0 48

Expected result:

1.0.42 (prod):
1 0 42

Reproduces how often:

easily

Brave version (brave://version info)

Brave | 1.27.108 Chromium: 92.0.4515.107 (Official Build) (x86_64)
-- | --
Revision | 87a818b10553a07434ea9e2b6dccf3cbe7895134-refs/branch-heads/4515@{#1634}
OS | macOS Version 10.15.7 (Build 19H1217)

And dev component version 1.0.48.

Version/Channel Information:

  • Can you reproduce this issue with the current release? yes w/ dev component
  • Can you reproduce this issue with the beta channel?
  • Can you reproduce this issue with the nightly channel?

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields?
  • Does the issue resolve itself when disabling Brave Rewards?
  • Is the issue reproducible on the latest version of Chrome?

Miscellaneous Information:

cc @emerick @kjozwiak

@emerick
Copy link
Contributor

emerick commented Nov 7, 2023

Closing as this has been superseded by #33783

@emerick emerick closed this as completed Nov 7, 2023
@emerick emerick added this to the 1.62.x - Nightly milestone Nov 7, 2023
@LaurenWags
Copy link
Member Author

Verified with

Brave | 1.62.93 Chromium: 120.0.6099.35 (Official Build) beta (x86_64)
-- | --
Revision | 2032da61e85b8d826ab474ee36fee9a9cee09907
OS | macOS Version 13.6.1 (Build 22G313)

Using STR, confirmed tip buttons no longer display on reddit.com or old.reddit.com

Screenshot 2023-11-30 at 4 20 54 PM Screenshot 2023-11-30 at 4 24 33 PM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

No branches or pull requests

3 participants